All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Eugenio Perez Martin <eperezma@redhat.com>
Cc: Yongji Xie <xieyongji@bytedance.com>,
	linux-kernel@vger.kernel.org,
	Maxime Coquelin <mcoqueli@redhat.com>,
	Stefano Garzarella <sgarzare@redhat.com>,
	Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
	Cindy Lu <lulu@redhat.com>,
	virtualization@lists.linux.dev,
	Laurent Vivier <lvivier@redhat.com>,
	jasowang@redhat.com
Subject: Re: [PATCH v5 0/6] Add multiple address spaces support to VDUSE
Date: Mon, 29 Sep 2025 03:56:27 -0400	[thread overview]
Message-ID: <20250929035620-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CAJaqyWfeiAiNOBtGoEYK7PLncXLMO+wZ=Gse+=X0FO65qQO4LQ@mail.gmail.com>

On Mon, Sep 29, 2025 at 07:41:13AM +0200, Eugenio Perez Martin wrote:
> On Fri, Sep 26, 2025 at 4:37 PM Michael S. Tsirkin <mst@redhat.com> wrote:
> >
> > On Fri, Sep 26, 2025 at 12:14:26PM +0200, Eugenio Pérez wrote:
> > > PATCH v5:
> > > * Properly return errno if copy_to_user returns >0 in VDUSE_IOTLB_GET_FD
> > >   ioctl (Jason).
> >
> > ???
> >
> > I think copy_to_user returns an unsigned value: the number of bytes copied.
> >
> >
> > static __always_inline unsigned long __must_check
> > copy_from_user(void *to, const void __user *from, unsigned long n)
> > {
> >         if (!check_copy_size(to, n, false))
> >                 return n;
> > #ifdef INLINE_COPY_FROM_USER
> >         return _inline_copy_from_user(to, from, n);
> > #else
> >         return _copy_from_user(to, from, n);
> > #endif
> > }
> >
> >
> > so, how does the patch work then?
> >
> 
> copy_from_user returns the number of bytes that could not be copied.
> For example when the object size in the kernel is less than n bytes
> long, check_copy_size returns false and copy_from_user returns n, the
> amount of size requested to copy.

oh, right. thanks!


      reply	other threads:[~2025-09-29  7:56 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-26 10:14 [PATCH v5 0/6] Add multiple address spaces support to VDUSE Eugenio Pérez
2025-09-26 10:14 ` [PATCH v5 1/6] vduse: make domain_lock an rwlock Eugenio Pérez
2025-09-26 10:14 ` [PATCH v5 2/6] vduse: add v1 API definition Eugenio Pérez
2025-09-26 10:14 ` [PATCH v5 3/6] vduse: add vq group support Eugenio Pérez
2025-09-26 14:59   ` Michael S. Tsirkin
2025-09-29  5:54     ` Eugenio Perez Martin
2025-09-26 15:26   ` Michael S. Tsirkin
2025-09-29  5:55     ` Eugenio Perez Martin
2025-09-29  7:55       ` Michael S. Tsirkin
2025-09-29  8:52         ` Eugenio Perez Martin
2025-09-29  9:29           ` Michael S. Tsirkin
2025-09-29  9:31             ` Eugenio Perez Martin
2025-09-26 10:14 ` [PATCH v5 4/6] vduse: return internal vq group struct as map token Eugenio Pérez
2025-09-26 10:14 ` [PATCH v5 5/6] vduse: add vq group asid support Eugenio Pérez
2025-09-26 15:22   ` Michael S. Tsirkin
2025-09-29 11:29     ` Eugenio Perez Martin
2025-09-26 15:25   ` Michael S. Tsirkin
2025-09-29 11:28     ` Eugenio Perez Martin
2025-09-27 20:00   ` Michael S. Tsirkin
2025-09-29 11:27     ` Eugenio Perez Martin
2025-09-26 10:14 ` [PATCH v5 6/6] vduse: bump version number Eugenio Pérez
2025-09-26 14:37 ` [PATCH v5 0/6] Add multiple address spaces support to VDUSE Michael S. Tsirkin
2025-09-29  5:41   ` Eugenio Perez Martin
2025-09-29  7:56     ` Michael S. Tsirkin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250929035620-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=eperezma@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lulu@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=mcoqueli@redhat.com \
    --cc=sgarzare@redhat.com \
    --cc=virtualization@lists.linux.dev \
    --cc=xieyongji@bytedance.com \
    --cc=xuanzhuo@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.