All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Hamilton <adhamilt@gmail.com>
To: grub-devel@gnu.org
Cc: daniel.kiper@oracle.com, safinaskar@zohomail.com,
	benh@debian.org, bluca@debian.org, kibi@debian.org,
	Andrew Hamilton <adhamilt@gmail.com>
Subject: [PATCH v2 0/1] Correct Video Corruption for EFI Plus Bochs/Cirrus
Date: Mon, 29 Sep 2025 21:23:39 -0500	[thread overview]
Message-ID: <20250930022340.146838-1-adhamilt@gmail.com> (raw)

Disable building video_bochs and video_cirrus for EFI x86 platforms (i386_efi
and x86_64_efi). For x86 EFI platforms efi_gop or efi_uga should provide the
video support. Currently, in EFI platforms there is a risk that both the
legacy device is present and the EFI video interface - which can cause
unexpected video corruption when a mix of the two interfaces are used. This
can happen when all_video is loaded for simplicity in a GRUB config.

There is some additional analysis from the Qemu team in this thread:
https://gitlab.com/qemu-project/qemu/-/issues/2562

This is an issue on some major distros such as Debian on EFI
when running under Qemu and potentially other scenarios.

There is some discussion on the Debian side in this thread:
https://salsa.debian.org/kernel-team/linux/-/merge_requests/1453

This relates to this discussion from grub-devel also:
https://lists.gnu.org/archive/html/grub-devel/2025-09/msg00244.html

Following this change, for x86_64_efi the following modules would
be loaded by "all_video": "efi_gop" "efi_uga"

Link to v1 thread:
https://lists.gnu.org/archive/html/grub-devel/2025-09/msg00254.html

Fixes: https://savannah.gnu.org/bugs/index.php?66200

Changes v1 => v2:
Also remove video_cirrus when building for i386 EFI or x86-64 EFI

Andrew Hamilton (1):
  build: Disable building video_bochs/cirrus for EFI x86 platforms

 grub-core/Makefile.core.def | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

-- 
2.47.3


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

             reply	other threads:[~2025-09-30  2:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-30  2:23 Andrew Hamilton [this message]
2025-09-30  2:23 ` [PATCH v2 1/1] build: Disable building video_bochs/cirrus for EFI x86 Andrew Hamilton
2025-10-01  2:59 ` [PATCH v2 0/1] Correct Video Corruption for EFI Plus Bochs/Cirrus Askar Safin via Grub-devel
2025-10-14  8:59 ` Askar Safin
2025-10-14 15:17   ` Andrew Hamilton
2025-10-15 13:30     ` Daniel Kiper via Grub-devel
2025-10-15 15:16       ` Gerd Hoffmann via Grub-devel
2025-10-15 16:49         ` Daniel Kiper via Grub-devel
2025-10-16  7:07           ` Askar Safin
2025-10-16 10:38             ` Daniel Kiper via Grub-devel
2025-10-17 11:37               ` Daniel Kiper via Grub-devel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250930022340.146838-1-adhamilt@gmail.com \
    --to=adhamilt@gmail.com \
    --cc=benh@debian.org \
    --cc=bluca@debian.org \
    --cc=daniel.kiper@oracle.com \
    --cc=grub-devel@gnu.org \
    --cc=kibi@debian.org \
    --cc=safinaskar@zohomail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.