From: Jakub Kicinski <kuba@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
andrew+netdev@lunn.ch, horms@kernel.org, petrm@nvidia.com,
willemb@google.com, shuah@kernel.org, daniel.zahka@gmail.com,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next v3 2/8] selftests: drv-net: base device access API test
Date: Tue, 30 Sep 2025 06:32:08 -0700 [thread overview]
Message-ID: <20250930063208.41ae93fe@kernel.org> (raw)
In-Reply-To: <9d215979-6c6d-4e9b-9cdd-39cff595866e@redhat.com>
On Tue, 30 Sep 2025 15:16:43 +0200 Paolo Abeni wrote:
> On 9/28/25 12:54 AM, Jakub Kicinski wrote:
> > diff --git a/tools/testing/selftests/drivers/net/hw/lib/py/__init__.py b/tools/testing/selftests/drivers/net/hw/lib/py/__init__.py
> > index 1462a339a74b..559c572e296a 100644
> > --- a/tools/testing/selftests/drivers/net/hw/lib/py/__init__.py
> > +++ b/tools/testing/selftests/drivers/net/hw/lib/py/__init__.py
> > @@ -13,7 +13,7 @@ KSFT_DIR = (Path(__file__).parent / "../../../../..").resolve()
> >
> > # Import one by one to avoid pylint false positives
> > from net.lib.py import EthtoolFamily, NetdevFamily, NetshaperFamily, \
> > - NlError, RtnlFamily, DevlinkFamily
> > + NlError, RtnlFamily, DevlinkFamily, PSPFamily
>
> Side question:
> There is a consistent false positive ruff check about this kind of
> change (with the added import being labeled as unused even in a __init__
> file.
>
> I'm wondering if is possible to explicitly disable such warnings?
I think it's possible to fix them by using __all__
It seemed to work but I wasn't confident enough that it's "the right
thing" to make it part of the series. I'm planning to follow up.
next prev parent reply other threads:[~2025-09-30 13:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-27 22:54 [PATCH net-next v3 0/8] psp: add a kselftest suite and netdevsim implementation Jakub Kicinski
2025-09-27 22:54 ` [PATCH net-next v3 1/8] netdevsim: a basic test PSP implementation Jakub Kicinski
2025-09-28 16:02 ` Willem de Bruijn
2025-09-27 22:54 ` [PATCH net-next v3 2/8] selftests: drv-net: base device access API test Jakub Kicinski
2025-09-30 13:16 ` Paolo Abeni
2025-09-30 13:32 ` Jakub Kicinski [this message]
2025-09-27 22:54 ` [PATCH net-next v3 3/8] selftests: drv-net: add PSP responder Jakub Kicinski
2025-09-28 16:05 ` Willem de Bruijn
2025-09-27 22:54 ` [PATCH net-next v3 4/8] selftests: drv-net: psp: add basic data transfer and key rotation tests Jakub Kicinski
2025-09-27 22:54 ` [PATCH net-next v3 5/8] selftests: drv-net: psp: add association tests Jakub Kicinski
2025-09-27 22:54 ` [PATCH net-next v3 6/8] selftests: drv-net: psp: add connection breaking tests Jakub Kicinski
2025-09-27 22:54 ` [PATCH net-next v3 7/8] selftests: drv-net: psp: add test for auto-adjusting TCP MSS Jakub Kicinski
2025-09-27 22:54 ` [PATCH net-next v3 8/8] selftests: drv-net: psp: add tests for destroying devices Jakub Kicinski
2025-09-28 16:00 ` [PATCH net-next v3 0/8] psp: add a kselftest suite and netdevsim implementation Willem de Bruijn
2025-09-29 19:04 ` Jakub Kicinski
2025-09-29 19:58 ` Willem de Bruijn
2025-09-30 13:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250930063208.41ae93fe@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=daniel.zahka@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=shuah@kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.