From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BC675CCA468 for ; Tue, 30 Sep 2025 10:46:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 46B1510E56A; Tue, 30 Sep 2025 10:46:17 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=collabora.com header.i=@collabora.com header.b="QTjlXH2q"; dkim-atps=neutral Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6BBA310E560; Tue, 30 Sep 2025 10:46:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1759229173; bh=D7FPMpVUID4VWIVsRLfS5OjhCnjT47sZGTl0id6lZQU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=QTjlXH2qlSMLT94RF69MdmWM6gnsmuNpbnGAeDVk1OFSCE7ihPVo6rNvTIG/Tpe8w vNGepnhvL010tfDYKJQl6E05PrKb8kutNjqacgZjs/Kq5Hss/drZ9NpqvKNbm4J2pC 8HxDIJ7eFltlQetIVqrN6rrC3ye9kzs/tS+mOE/1FOm2Q4+S/Ef7Ouj35S5BMygvHH 5xxg9pkWPGbseOA6vdpLQwJmreCPctFohglY6D0BHYsgGQVNUUXyoJeKZpiFa9qXs6 PpSBuODe7zdLCk3IdG3klbaab4KPtqvbO+ITsVd+nISzyN9TkGdbvJOT5rJNB1kOhk SW9R625asBKbQ== Received: from fedora (unknown [IPv6:2a01:e0a:2c:6930:d919:a6e:5ea1:8a9f]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by bali.collaboradmins.com (Postfix) with ESMTPSA id B361117E0CF8; Tue, 30 Sep 2025 12:46:12 +0200 (CEST) Date: Tue, 30 Sep 2025 12:45:54 +0200 From: Boris Brezillon To: =?UTF-8?B?TG/Dr2M=?= Molinari Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , Rob Herring , Steven Price , Liviu Dudau , Melissa Wen , =?UTF-8?B?TWHDrXJh?= Canal , Hugh Dickins , Baolin Wang , Andrew Morton , Al Viro , =?UTF-8?B?TWlrb8WCYWo=?= Wasiak , Christian Brauner , Nitin Gote , Andi Shyti , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-mm@kvack.org, kernel@collabora.com Subject: Re: [PATCH 2/8] drm/gem: Introduce drm_gem_get_unmapped_area() fop Message-ID: <20250930124554.5459194c@fedora> In-Reply-To: <20250930123003.75370854@fedora> References: <20250929200316.18417-1-loic.molinari@collabora.com> <20250929200316.18417-3-loic.molinari@collabora.com> <20250930123003.75370854@fedora> Organization: Collabora X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, 30 Sep 2025 12:30:03 +0200 Boris Brezillon wrote: > > +unsigned long drm_gem_get_unmapped_area(struct file *filp, unsigned long uaddr, > > + unsigned long len, unsigned long pgoff, > > + unsigned long flags) > > +{ > > +#ifdef CONFIG_TRANSPARENT_HUGEPAGE > > + struct drm_gem_object *obj; > > + unsigned long ret; > > + > > + obj = drm_gem_object_lookup_from_offset(filp, pgoff, len >> PAGE_SHIFT); > > + if (IS_ERR(obj)) > > Is this supposed to happen? If not, I'd be tempted to add a > WARN_ON_ONCE(). Taking that back. I think you need it for non-GEM backed mappings, like userland IOMEM mappings. > > > + return mm_get_unmapped_area(current->mm, filp, uaddr, len, 0, > > + flags); > > +