From: Lee Jones <lee@kernel.org>
To: Dzmitry Sankouski <dsankouski@gmail.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Subject: Re: [PATCH v4 3/3] dt-bindings: max77705: add interrupt-controller property
Date: Wed, 1 Oct 2025 10:59:04 +0100 [thread overview]
Message-ID: <20251001095904.GQ8757@google.com> (raw)
In-Reply-To: <20250925-starqltechn-correct_max77705_nodes-v4-3-93b706bdda58@gmail.com>
On Thu, 25 Sep 2025, Dzmitry Sankouski wrote:
> Add interrupt-controller property, because max77705 has dedicated interrupt
> source register to determine which sub device triggered an interrupt.
>
> Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
> ---
> Changes in v4:
> - fix commit message: node -> property
> - fix commit message: minor reword and punctuation
Please also fix the subject line. Format should be:
dt-bindings: mfd: <device>: Subject line starting with an uppercase char
> ---
> Documentation/devicetree/bindings/mfd/maxim,max77705.yaml | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/maxim,max77705.yaml b/Documentation/devicetree/bindings/mfd/maxim,max77705.yaml
> index 0ec89f0adc64..d265c8213a08 100644
> --- a/Documentation/devicetree/bindings/mfd/maxim,max77705.yaml
> +++ b/Documentation/devicetree/bindings/mfd/maxim,max77705.yaml
> @@ -26,6 +26,18 @@ properties:
> interrupts:
> maxItems: 1
>
> + interrupt-controller:
> + description:
> + The driver implements an interrupt controller for the sub devices.
> + The interrupt number mapping is as follows
> + 0 - charger
> + 1 - topsys
> + 2 - fuelgauge
> + 3 - usb type-c management block.
> +
> + '#interrupt-cells':
> + const: 1
> +
> haptic:
> type: object
> additionalProperties: false
> @@ -120,8 +132,10 @@ examples:
> reg = <0x66>;
> interrupt-parent = <&pm8998_gpios>;
> interrupts = <11 IRQ_TYPE_LEVEL_LOW>;
> + interrupt-controller;
> pinctrl-0 = <&chg_int_default>;
> pinctrl-names = "default";
> + #interrupt-cells = <1>;
>
> leds {
> compatible = "maxim,max77705-rgb";
>
> --
> 2.39.5
>
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2025-10-01 9:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-25 19:38 [PATCH v4 0/3] starqltechn: fix max77705 device irqs Dzmitry Sankouski
2025-09-25 19:38 ` [PATCH v4 1/3] arm64: dts: qcom: sdm845-starqltechn: remove (address|size)-cells Dzmitry Sankouski
2025-09-25 19:38 ` [PATCH v4 2/3] arch: arm64: dts: qcom: sdm845-starqltechn: fix max77705 interrupts Dzmitry Sankouski
2025-09-25 20:49 ` Dmitry Baryshkov
2025-09-25 19:38 ` [PATCH v4 3/3] dt-bindings: max77705: add interrupt-controller property Dzmitry Sankouski
2025-09-25 20:50 ` Dmitry Baryshkov
2025-10-01 9:59 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251001095904.GQ8757@google.com \
--to=lee@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=dsankouski@gmail.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.