From: Lee Jones <lee@kernel.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Janne Grunau <j@jannau.net>,
asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
LKML <linux-kernel@vger.kernel.org>, Neal Gompa <neal@gompa.dev>,
Sven Peter <sven@kernel.org>
Subject: Re: [PATCH] mfd: macsmc: Initialize mutex
Date: Wed, 1 Oct 2025 13:48:25 +0100 [thread overview]
Message-ID: <20251001124825.GR8757@google.com> (raw)
In-Reply-To: <0acf13d6-d63b-4079-93ba-d53910e624d7@web.de>
On Wed, 01 Oct 2025, Markus Elfring wrote:
> >>> Struct apple_smc's mutex was not initialized before use. Surprisingly
> >>> this only resulted in occasional NULL pointer dereferences in
> >>> apple_smc_read() calls from the probe() functions of sub devices.
> >>
> >> See also:
> >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.17-rc7#n94
> >
> > Provide some context in your own words.
>
> Would contributors like to care more also for the usage of imperative mood
> in proposed commit messages?
>
>
> > Don't expect others to click random links.
>
> Should the mentioned information source be better known since a while?
By all means, provide the link as well.
However, you must also provide your own context.
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2025-10-01 12:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-25 20:33 [PATCH] mfd: macsmc: Initialize mutex Janne Grunau
2025-09-27 2:28 ` Neal Gompa
2025-09-27 13:57 ` Markus Elfring
2025-10-01 9:55 ` Lee Jones
2025-10-01 11:13 ` Markus Elfring
2025-10-01 12:48 ` Lee Jones [this message]
2025-10-01 12:52 ` Markus Elfring
2025-10-08 13:57 ` Lee Jones
2025-10-08 14:20 ` [PATCH] " Sven Peter
2025-10-21 15:09 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251001124825.GR8757@google.com \
--to=lee@kernel.org \
--cc=Markus.Elfring@web.de \
--cc=asahi@lists.linux.dev \
--cc=j@jannau.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neal@gompa.dev \
--cc=sven@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.