Re: [PATCH v12 05/25] cxl: Move CXL driver RCH error handling into CONFIG_CXL_RCH_RAS conditional block

[Jonathan Cameron <jonathan.cameron@huawei.com>]

> > diff --git a/drivers/cxl/core/ras.c b/drivers/cxl/core/ras.c
> > index 0875ce8116ff..1ec4ea8c56f1 100644
> > --- a/drivers/cxl/core/ras.c
> > +++ b/drivers/cxl/core/ras.c
> > @@ -126,6 +126,10 @@ void cxl_ras_exit(void)
> >  	cancel_work_sync(&cxl_cper_prot_err_work);
> >  }
> >  
> > +static void cxl_handle_cor_ras(struct cxl_dev_state *cxlds, void __iomem *ras_base);
> > +static bool cxl_handle_ras(struct cxl_dev_state *cxlds, void __iomem *ras_base);
> > +
> > +#ifdef CONFIG_CXL_RCH_RAS  
> 
> I don't love this in the C file. If we are going to have a Kconfig that we can use to gate the code, maybe we need core/ras_rch.c? Don't forget to add the new object entry to KBuild for cxl_test when you do that. 
> 

Seconded.  Seems worth an extra file to me as well.

J
> DJ