From: Rob Herring <robh@kernel.org>
To: Sibi Sankar <sibi.sankar@oss.qualcomm.com>
Cc: jassisinghbrar@gmail.com, krzk+dt@kernel.org,
conor+dt@kernel.org, mani@kernel.org, andersson@kernel.org,
mathieu.poirier@linaro.org, konradybcio@kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-remoteproc@vger.kernel.org
Subject: Re: [PATCH 4/5] dt-bindings: remoteproc: qcom,sm8550-pas: Document Glymur ADSP
Date: Wed, 1 Oct 2025 19:54:34 -0500 [thread overview]
Message-ID: <20251002005434.GA2796203-robh@kernel.org> (raw)
In-Reply-To: <20250924183726.509202-5-sibi.sankar@oss.qualcomm.com>
On Thu, Sep 25, 2025 at 12:07:25AM +0530, Sibi Sankar wrote:
> Document compatible for Qualcomm Glymur SoC ADSP which is fully compatible
> with SM8750 ADSP. Also with the Linux Host running on EL2, the remoteprocs
> need to be hypervisor independent, the iommu property is mandatory to
> ensure proper functionality.
>
> Signed-off-by: Sibi Sankar <sibi.sankar@oss.qualcomm.com>
> ---
>
> Dependencies:
> Peripheral Image Loader support for Qualcomm SoCs running Linux host at EL2:
> https://patchwork.kernel.org/project/linux-arm-msm/cover/20250921-kvm_rproc_pas-v3-0-458f09647920@oss.qualcomm.com/
> This patch has a dependency on the iommu binding added in ^^ series.
>
> .../bindings/remoteproc/qcom,sm8550-pas.yaml | 16 +++++++++++++++-
> 1 file changed, 15 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
> index 2dd479cf4821..cba45ce2865e 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml
> @@ -28,7 +28,9 @@ properties:
> - qcom,x1e80100-adsp-pas
> - qcom,x1e80100-cdsp-pas
> - items:
> - - const: qcom,sm8750-adsp-pas
> + - enum:
> + - qcom,glymur-adsp-pas
> + - qcom,sm8750-adsp-pas
> - const: qcom,sm8550-adsp-pas
> - items:
> - const: qcom,sm8750-cdsp-pas
> @@ -95,6 +97,7 @@ allOf:
> compatible:
> contains:
> enum:
> + - qcom,glymur-adsp-pas
> - qcom,sm8750-adsp-pas
> then:
> properties:
> @@ -185,6 +188,7 @@ allOf:
> compatible:
> contains:
> enum:
> + - qcom,glymur-adsp-pas
> - qcom,sm8550-adsp-pas
> - qcom,sm8650-adsp-pas
> - qcom,sm8750-adsp-pas
> @@ -238,6 +242,16 @@ allOf:
> - const: cx
> - const: mxc
> - const: nsp
> + - if:
> + properties:
> + compatible:
> + enum:
> + - qcom,glymur-adsp-pas
> + then:
> + properties:
> + iommus:
> + minItems: 1
The min can never be 0, so it is already 1. Drop.
> + maxItems: 1
>
> unevaluatedProperties: false
>
> --
> 2.34.1
>
next prev parent reply other threads:[~2025-10-02 0:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-24 18:37 [PATCH 0/5] dt-bindings: remoteproc: Document Glymur ADSP/CDSP PAS Sibi Sankar
2025-09-24 18:37 ` [PATCH 1/5] dt-bindings: mailbox: qcom-ipcc: Document the Glymur IPCC Sibi Sankar
2025-10-02 0:39 ` Rob Herring
2025-10-09 10:07 ` Sibi Sankar
2025-09-24 18:37 ` [PATCH 2/5] dt-bindings: mailbox: qcom-ipcc: Document Glymur physical client IDs Sibi Sankar
2025-10-02 0:37 ` Rob Herring
2025-09-24 18:37 ` [PATCH 3/5] dt-bindings: soc: qcom,aoss-qmp: Document the Glymur AOSS side channel Sibi Sankar
2025-09-24 18:37 ` [PATCH 4/5] dt-bindings: remoteproc: qcom,sm8550-pas: Document Glymur ADSP Sibi Sankar
2025-10-02 0:54 ` Rob Herring [this message]
2025-10-09 10:09 ` Sibi Sankar
2025-09-24 18:37 ` [PATCH 5/5] dt-bindings: remoteproc: qcom,sm8550-pas: Document Glymur CDSP Sibi Sankar
2025-10-02 0:55 ` Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251002005434.GA2796203-robh@kernel.org \
--to=robh@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=sibi.sankar@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.