Re: [PATCH 2/5] dt-bindings: mfd: sc2731: Reference sprd,sc2731-poweroff

[Rob Herring <robh@kernel.org>]

On Fri, Sep 26, 2025 at 06:23:24PM +0200, Otto Pflüger wrote:
> Reference the new sprd,sc2731-poweroff bindings and add an example.
> 
> Signed-off-by: Otto Pflüger <otto.pflueger@abscue.de>
> ---
>  Documentation/devicetree/bindings/mfd/sprd,sc2731.yaml | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/sprd,sc2731.yaml b/Documentation/devicetree/bindings/mfd/sprd,sc2731.yaml
> index b023e1ef8d3ccdb1d82d64ed1a60d5a712a1b910..a78d7e26b3a2c77b84da84fc23e52f3a22ab14df 100644
> --- a/Documentation/devicetree/bindings/mfd/sprd,sc2731.yaml
> +++ b/Documentation/devicetree/bindings/mfd/sprd,sc2731.yaml
> @@ -52,6 +52,10 @@ properties:
>    '#size-cells':
>      const: 0
>  
> +  poweroff:
> +    type: object
> +    $ref: /schemas/power/reset/sprd,sc2731-poweroff.yaml#

You don't need a child node here as there's no DT resources. Just make 
the parent node the power off provider.

IOW, a node with only a compatible property is pretty much always wrong 
(though yes, you can find examples).

> +
>    regulators:
>      type: object
>      $ref: /schemas/regulator/sprd,sc2731-regulator.yaml#
> @@ -221,6 +225,10 @@ examples:
>            reg = <0xec8>;
>          };
>  
> +        poweroff {
> +          compatible = "sprd,sc2731-poweroff";
> +        };
> +
>          regulators {
>            compatible = "sprd,sc2731-regulator";
>  
> 
> -- 
> 2.50.0
>