All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@collabora.com>
To: Rain Yang <jiyu.yang@oss.nxp.com>
Cc: imx@lists.linux.dev, dri-devel@lists.freedesktop.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	steven.price@arm.com, liviu.dudau@arm.com,
	maarten.lankhorst@linux.intel.com, mripard@kernel.org,
	tzimmermann@suse.de, airlied@gmail.co, simona@ffwll.ch,
	marek.vasut@mailbox.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, Rain Yang <jiyu.yang@nxp.com>
Subject: Re: [PATCH v2 2/2] drm/panthor: skip regulator setup if no such prop
Date: Thu, 2 Oct 2025 08:38:07 +0200	[thread overview]
Message-ID: <20251002083807.1d7d837d@fedora> (raw)
In-Reply-To: <20250928090334.35389-2-jiyu.yang@oss.nxp.com>

On Sun, 28 Sep 2025 17:03:34 +0800
Rain Yang <jiyu.yang@oss.nxp.com> wrote:

> From: Rain Yang <jiyu.yang@nxp.com>
> 
> The regulator is optional, skip the setup instead of returning an
> error if it is not present
> 
> Signed-off-by: Rain Yang <jiyu.yang@nxp.com>

Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>

> ---
>  drivers/gpu/drm/panthor/panthor_devfreq.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panthor/panthor_devfreq.c b/drivers/gpu/drm/panthor/panthor_devfreq.c
> index 3686515d368d..2df1d76d84a0 100644
> --- a/drivers/gpu/drm/panthor/panthor_devfreq.c
> +++ b/drivers/gpu/drm/panthor/panthor_devfreq.c
> @@ -146,10 +146,9 @@ int panthor_devfreq_init(struct panthor_device *ptdev)
>  	ptdev->devfreq = pdevfreq;
>  
>  	ret = devm_pm_opp_set_regulators(dev, reg_names);
> -	if (ret) {
> +	if (ret && ret != -ENODEV) {
>  		if (ret != -EPROBE_DEFER)
>  			DRM_DEV_ERROR(dev, "Couldn't set OPP regulators\n");
> -
>  		return ret;
>  	}
>  


  reply	other threads:[~2025-10-02  6:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-28  9:03 [PATCH v2 1/2] dt-bindings: gpu: mali-valhall: make mali-supply optional Rain Yang
2025-09-28  9:03 ` [PATCH v2 2/2] drm/panthor: skip regulator setup if no such prop Rain Yang
2025-10-02  6:38   ` Boris Brezillon [this message]
2025-10-02  8:21   ` Steven Price
2025-10-02  3:37 ` [PATCH v2 1/2] dt-bindings: gpu: mali-valhall: make mali-supply optional Rob Herring (Arm)
2025-10-02  6:38 ` Boris Brezillon
2025-10-09 13:00 ` Steven Price
2025-10-09 14:43   ` Frank Li
2025-10-09 14:52     ` Boris Brezillon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251002083807.1d7d837d@fedora \
    --to=boris.brezillon@collabora.com \
    --cc=airlied@gmail.co \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=imx@lists.linux.dev \
    --cc=jiyu.yang@nxp.com \
    --cc=jiyu.yang@oss.nxp.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liviu.dudau@arm.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=marek.vasut@mailbox.org \
    --cc=mripard@kernel.org \
    --cc=robh@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=steven.price@arm.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.