From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>,
Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH 3/3] nvme-auth: move declaration of nvme_auth_extract_key()
Date: Fri, 3 Oct 2025 09:35:57 +0200 [thread overview]
Message-ID: <20251003073557.GC12862@lst.de> (raw)
In-Reply-To: <20251001142200.61696-4-hare@kernel.org>
On Wed, Oct 01, 2025 at 04:22:00PM +0200, Hannes Reinecke wrote:
> void nvme_auth_revoke_tls_key(struct nvme_ctrl *ctrl);
> +struct key *nvme_auth_extract_key(struct key *keyring, const u8 *secret,
> + size_t secret_len, bool *generated);
Please use one-tab indent for declarations.
> +static inline struct key *nvme_auth_extract_key(struct key *keyring,
> + const u8 *secret,
> + size_t secret_len,
> + bool *generated)
> +{
And two-tab for definitions.
prev parent reply other threads:[~2025-10-03 7:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-01 14:21 [PATCH 0/3] nvme: kbuild robot fixes Hannes Reinecke
2025-10-01 14:21 ` [PATCH 1/3] nvme-keyring: use correct format specifier Hannes Reinecke
2025-10-03 7:34 ` Christoph Hellwig
2025-10-06 14:18 ` Keith Busch
2025-10-01 14:21 ` [PATCH 2/3] nvme-keyring: typo in nvme_dhchap_psk_lookup() Hannes Reinecke
2025-10-03 7:35 ` Christoph Hellwig
2025-10-03 12:41 ` Keith Busch
2025-10-03 13:12 ` Christoph Hellwig
2025-10-01 14:22 ` [PATCH 3/3] nvme-auth: move declaration of nvme_auth_extract_key() Hannes Reinecke
2025-10-03 7:35 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251003073557.GC12862@lst.de \
--to=hch@lst.de \
--cc=hare@kernel.org \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=lkp@intel.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.