diff for duplicates of <202510031227.18psESZQ-lkp@intel.com> diff --git a/a/1.txt b/N1/1.txt index b4649b8..ddd74b8 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,18 +1,38 @@ +BCC: lkp@intel.com +CC: oe-kbuild-all@lists.linux.dev +In-Reply-To: <f52cda16-4952-4b28-bbf7-d44f4e054490@cybernetics.com> +References: <f52cda16-4952-4b28-bbf7-d44f4e054490@cybernetics.com> +TO: Tony Battersby <tonyb@cybernetics.com> +TO: Nilesh Javali <njavali@marvell.com> +TO: GR-QLogic-Storage-Upstream@marvell.com +TO: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com> +TO: "Martin K. Petersen" <martin.petersen@oracle.com> +CC: "linux-scsi" <linux-scsi@vger.kernel.org> +CC: target-devel@vger.kernel.org +CC: scst-devel@lists.sourceforge.net +CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> +CC: Dmitry Bogdanov <d.bogdanov@yadro.com> +CC: Xose Vazquez Perez <xose.vazquez@gmail.com> + Hi Tony, kernel test robot noticed the following build warnings: +[auto build test WARNING on e5f0a698b34ed76002dc5cff3804a61c80233a7a] + url: https://github.com/intel-lab-lkp/linux/commits/Tony-Battersby/Revert-scsi-qla2xxx-Perform-lockless-command-completion-in-abort-path/20250930-024814 base: e5f0a698b34ed76002dc5cff3804a61c80233a7a patch link: https://lore.kernel.org/r/f52cda16-4952-4b28-bbf7-d44f4e054490%40cybernetics.com patch subject: [PATCH v2 11/16] scsi: qla2xxx: fix TMR failure handling +:::::: branch date: 3 days ago +:::::: commit date: 3 days ago config: i386-randconfig-141-20251002 (https://download.01.org/0day-ci/archive/20251003/202510031227.18psESZQ-lkp@intel.com/config) compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> -| Reported-by: Dan Carpenter <dan.carpenter@linaro.org> +| Reported-by: Dan Carpenter <error27@gmail.com> | Closes: https://lore.kernel.org/r/202510031227.18psESZQ-lkp@intel.com/ New smatch warnings: @@ -23,6 +43,8 @@ drivers/scsi/qla2xxx/qla_target.c:671 qla24xx_delete_sess_fn() warn: can 'fcport vim +/mcmd +5735 drivers/scsi/qla2xxx/qla_target.c +0691094ff3f2cfa Quinn Tran 2018-09-04 5704 +6b0431d6fa20bd1 Quinn Tran 2018-09-04 5705 6b0431d6fa20bd1 Quinn Tran 2018-09-04 5706 static void qlt_handle_abts_completion(struct scsi_qla_host *vha, 6b0431d6fa20bd1 Quinn Tran 2018-09-04 5707 struct rsp_que *rsp, response_t *pkt) 6b0431d6fa20bd1 Quinn Tran 2018-09-04 5708 { @@ -42,9 +64,6 @@ vim +/mcmd +5735 drivers/scsi/qla2xxx/qla_target.c 6b0431d6fa20bd1 Quinn Tran 2018-09-04 5722 6b0431d6fa20bd1 Quinn Tran 2018-09-04 @5723 if (mcmd) 6b0431d6fa20bd1 Quinn Tran 2018-09-04 5724 vha = mcmd->vha; - -mcmd can be NULL - 6b0431d6fa20bd1 Quinn Tran 2018-09-04 5725 vha->vha_tgt.qla_tgt->abts_resp_expected--; 6b0431d6fa20bd1 Quinn Tran 2018-09-04 5726 6b0431d6fa20bd1 Quinn Tran 2018-09-04 5727 ql_dbg(ql_dbg_tgt, vha, 0xe038, @@ -56,10 +75,6 @@ mcmd can be NULL 7ffa5b939751b66 Bart Van Assche 2020-05-18 5733 le32_to_cpu(entry->error_subcode2) == 0) { 6b0431d6fa20bd1 Quinn Tran 2018-09-04 5734 if (qlt_chk_unresolv_exchg(vha, rsp->qpair, entry)) { 74dabbbd8bb833e Tony Battersby 2025-09-29 @5735 qlt_free_ul_mcmd(ha, mcmd); - ^^^^ -But here it is dereferenced without checking. Previously it called -tcm_qla2xxx_free_mcmd() which checks for NULL. - 6b0431d6fa20bd1 Quinn Tran 2018-09-04 5736 return; 6b0431d6fa20bd1 Quinn Tran 2018-09-04 5737 } 6b0431d6fa20bd1 Quinn Tran 2018-09-04 5738 qlt_24xx_retry_term_exchange(vha, rsp->qpair, @@ -76,6 +91,7 @@ e752a04e1bd14cc Bart Van Assche 2019-08-08 5748 } else if (mcmd) { 74dabbbd8bb833e Tony Battersby 2025-09-29 5749 qlt_free_ul_mcmd(ha, mcmd); 6b0431d6fa20bd1 Quinn Tran 2018-09-04 5750 } 6b0431d6fa20bd1 Quinn Tran 2018-09-04 5751 } +6b0431d6fa20bd1 Quinn Tran 2018-09-04 5752 -- 0-DAY CI Kernel Test Service diff --git a/a/content_digest b/N1/content_digest index aa3ec61..c9b7039 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,38 +1,46 @@ - "ref\0f52cda16-4952-4b28-bbf7-d44f4e054490@cybernetics.com\0" - "From\0Dan Carpenter <dan.carpenter@linaro.org>\0" + "From\0kernel test robot <lkp@intel.com>\0" "Subject\0Re: [PATCH v2 11/16] scsi: qla2xxx: fix TMR failure handling\0" - "Date\0Fri, 3 Oct 2025 11:40:33 +0300\0" - "To\0oe-kbuild@lists.linux.dev" - Tony Battersby <tonyb@cybernetics.com> - Nilesh Javali <njavali@marvell.com> - GR-QLogic-Storage-Upstream@marvell.com - James E.J. Bottomley <James.Bottomley@hansenpartnership.com> - " Martin K. Petersen <martin.petersen@oracle.com>\0" + "Date\0Fri, 3 Oct 2025 13:04:52 +0800\0" + "To\0oe-kbuild@lists.linux.dev\0" "Cc\0lkp@intel.com" - oe-kbuild-all@lists.linux.dev - linux-scsi <linux-scsi@vger.kernel.org> - target-devel@vger.kernel.org - scst-devel@lists.sourceforge.net - linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> - Dmitry Bogdanov <d.bogdanov@yadro.com> - " Xose Vazquez Perez <xose.vazquez@gmail.com>\0" + " Dan Carpenter <error27@gmail.com>\0" "\00:1\0" "b\0" + "BCC: lkp@intel.com\n" + "CC: oe-kbuild-all@lists.linux.dev\n" + "In-Reply-To: <f52cda16-4952-4b28-bbf7-d44f4e054490@cybernetics.com>\n" + "References: <f52cda16-4952-4b28-bbf7-d44f4e054490@cybernetics.com>\n" + "TO: Tony Battersby <tonyb@cybernetics.com>\n" + "TO: Nilesh Javali <njavali@marvell.com>\n" + "TO: GR-QLogic-Storage-Upstream@marvell.com\n" + "TO: \"James E.J. Bottomley\" <James.Bottomley@HansenPartnership.com>\n" + "TO: \"Martin K. Petersen\" <martin.petersen@oracle.com>\n" + "CC: \"linux-scsi\" <linux-scsi@vger.kernel.org>\n" + "CC: target-devel@vger.kernel.org\n" + "CC: scst-devel@lists.sourceforge.net\n" + "CC: \"linux-kernel@vger.kernel.org\" <linux-kernel@vger.kernel.org>\n" + "CC: Dmitry Bogdanov <d.bogdanov@yadro.com>\n" + "CC: Xose Vazquez Perez <xose.vazquez@gmail.com>\n" + "\n" "Hi Tony,\n" "\n" "kernel test robot noticed the following build warnings:\n" "\n" + "[auto build test WARNING on e5f0a698b34ed76002dc5cff3804a61c80233a7a]\n" + "\n" "url: https://github.com/intel-lab-lkp/linux/commits/Tony-Battersby/Revert-scsi-qla2xxx-Perform-lockless-command-completion-in-abort-path/20250930-024814\n" "base: e5f0a698b34ed76002dc5cff3804a61c80233a7a\n" "patch link: https://lore.kernel.org/r/f52cda16-4952-4b28-bbf7-d44f4e054490%40cybernetics.com\n" "patch subject: [PATCH v2 11/16] scsi: qla2xxx: fix TMR failure handling\n" + ":::::: branch date: 3 days ago\n" + ":::::: commit date: 3 days ago\n" "config: i386-randconfig-141-20251002 (https://download.01.org/0day-ci/archive/20251003/202510031227.18psESZQ-lkp@intel.com/config)\n" "compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)\n" "\n" "If you fix the issue in a separate patch/commit (i.e. not just a new version of\n" "the same patch/commit), kindly add following tags\n" "| Reported-by: kernel test robot <lkp@intel.com>\n" - "| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>\n" + "| Reported-by: Dan Carpenter <error27@gmail.com>\n" "| Closes: https://lore.kernel.org/r/202510031227.18psESZQ-lkp@intel.com/\n" "\n" "New smatch warnings:\n" @@ -43,6 +51,8 @@ "\n" "vim +/mcmd +5735 drivers/scsi/qla2xxx/qla_target.c\n" "\n" + "0691094ff3f2cfa Quinn Tran 2018-09-04 5704 \n" + "6b0431d6fa20bd1 Quinn Tran 2018-09-04 5705 \n" "6b0431d6fa20bd1 Quinn Tran 2018-09-04 5706 static void qlt_handle_abts_completion(struct scsi_qla_host *vha,\n" "6b0431d6fa20bd1 Quinn Tran 2018-09-04 5707 \tstruct rsp_que *rsp, response_t *pkt)\n" "6b0431d6fa20bd1 Quinn Tran 2018-09-04 5708 {\n" @@ -62,9 +72,6 @@ "6b0431d6fa20bd1 Quinn Tran 2018-09-04 5722 \n" "6b0431d6fa20bd1 Quinn Tran 2018-09-04 @5723 \tif (mcmd)\n" "6b0431d6fa20bd1 Quinn Tran 2018-09-04 5724 \t\tvha = mcmd->vha;\n" - "\n" - "mcmd can be NULL\n" - "\n" "6b0431d6fa20bd1 Quinn Tran 2018-09-04 5725 \tvha->vha_tgt.qla_tgt->abts_resp_expected--;\n" "6b0431d6fa20bd1 Quinn Tran 2018-09-04 5726 \n" "6b0431d6fa20bd1 Quinn Tran 2018-09-04 5727 \tql_dbg(ql_dbg_tgt, vha, 0xe038,\n" @@ -76,10 +83,6 @@ "7ffa5b939751b66 Bart Van Assche 2020-05-18 5733 \t\t le32_to_cpu(entry->error_subcode2) == 0) {\n" "6b0431d6fa20bd1 Quinn Tran 2018-09-04 5734 \t\t\tif (qlt_chk_unresolv_exchg(vha, rsp->qpair, entry)) {\n" "74dabbbd8bb833e Tony Battersby 2025-09-29 @5735 \t\t\t\tqlt_free_ul_mcmd(ha, mcmd);\n" - " ^^^^\n" - "But here it is dereferenced without checking. Previously it called\n" - "tcm_qla2xxx_free_mcmd() which checks for NULL.\n" - "\n" "6b0431d6fa20bd1 Quinn Tran 2018-09-04 5736 \t\t\t\treturn;\n" "6b0431d6fa20bd1 Quinn Tran 2018-09-04 5737 \t\t\t}\n" "6b0431d6fa20bd1 Quinn Tran 2018-09-04 5738 \t\t\tqlt_24xx_retry_term_exchange(vha, rsp->qpair,\n" @@ -96,9 +99,10 @@ "74dabbbd8bb833e Tony Battersby 2025-09-29 5749 \t\tqlt_free_ul_mcmd(ha, mcmd);\n" "6b0431d6fa20bd1 Quinn Tran 2018-09-04 5750 \t}\n" "6b0431d6fa20bd1 Quinn Tran 2018-09-04 5751 }\n" + "6b0431d6fa20bd1 Quinn Tran 2018-09-04 5752 \n" "\n" "-- \n" "0-DAY CI Kernel Test Service\n" https://github.com/intel/lkp-tests/wiki -74f421a1e9d4ce40f13e4bea6240cd60ff5e1cf5f05cc508f53fcb5ddb38c1e4 +cd2950beeba89d490868ec10f456784839254b5697cd59fc79f079d196529180
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.