All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Richard W.M. Jones" <rjones@redhat.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, berrange@redhat.com
Subject: Re: [PATCH v1 0/2] Implement -run-with exit-with-parent=on
Date: Fri, 3 Oct 2025 15:11:43 +0100	[thread overview]
Message-ID: <20251003141143.GA5720@redhat.com> (raw)
In-Reply-To: <20251003133158.3978333-1-rjones@redhat.com>


On Fri, Oct 03, 2025 at 02:24:36PM +0100, Richard W.M. Jones wrote:
> An earlier WIP version was posted here:
> https://lists.gnu.org/archive/html/qemu-devel/2025-10/msg00309.html
> 
> In this version I have incorporated all of Daniel Berrange's feedback,
> and I also tested the change on macOS.
> 
> The new second patch modifies the test suite to use the new flag
> unconditionally, instead of open coding setting PR_SET_PDEATHSIG etc.
> The test suite fails for me both before and after this patch in the
> same way, so I assume this is nothing to do with the patch itself?
> 
>   4/405 qemu:func-quick+func-x86_64 / func-x86_64-bad_vmstate               ERROR            0.15s   exit status 1
> 
> Some points of note:
> 
>  - There's no way to find out if the qemu binary supports
>    exit-with-parent=on except to try it.  Maybe this should be exposed
>    somehow?

.. or exit-with-parent=best, but then it would no longer be a straight
boolean option.

>  - On macOS I wasn't able to find a satisfactory way to force
>    shutdown, except calling 'qemu_system_killed' and pretending we'd
>    been killed by SIGTERM (which does at least emulate what Linux &
>    FreeBSD do).  I suppose it'd be nice if there was a "killed by
>    parent" reason which also forced shutdown.
> 
> Rich.
> 

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org



      parent reply	other threads:[~2025-10-03 14:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-03 13:24 [PATCH v1 0/2] Implement -run-with exit-with-parent=on Richard W.M. Jones
2025-10-03 13:24 ` [PATCH v1 1/2] " Richard W.M. Jones
2025-10-03 14:12   ` Richard W.M. Jones
2025-10-03 13:24 ` [PATCH v1 2/2] tests/qtest: Use exit-with-parent=on in qtest invocations Richard W.M. Jones
2025-10-03 14:11 ` Richard W.M. Jones [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251003141143.GA5720@redhat.com \
    --to=rjones@redhat.com \
    --cc=berrange@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.