From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A3439CCA471 for ; Fri, 3 Oct 2025 14:14:18 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1v4gWY-0002Ur-K4; Fri, 03 Oct 2025 10:12:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v4gWW-0002UQ-Ea for qemu-devel@nongnu.org; Fri, 03 Oct 2025 10:12:40 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1v4gWL-000780-8K for qemu-devel@nongnu.org; Fri, 03 Oct 2025 10:12:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759500742; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=EXWaFOeApoM7+4wyuV8c1wzCNYnJapoNjfQfbaa74S4=; b=H051xXiekqVFj7Uga9teA8c5Rl29LAzsYxgLS8Y5+sKcwRP5g72zhPR1aiVAQJ4ie/l56B vQ62tPJERPB32YseKVpe8K+GvRfTIjas1ZlrC7TAdGHq0K+tCfHy3t0gCY/RX+rHsv9dmb kfooRAQsu/QELrzjzkBObG2M9Z6qhp4= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-680-6BE7UuUePrysxm8QemnlQg-1; Fri, 03 Oct 2025 10:12:20 -0400 X-MC-Unique: 6BE7UuUePrysxm8QemnlQg-1 X-Mimecast-MFC-AGG-ID: 6BE7UuUePrysxm8QemnlQg_1759500740 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id EE235180034A for ; Fri, 3 Oct 2025 14:12:19 +0000 (UTC) Received: from localhost (unknown [10.45.224.22]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 66885300018D; Fri, 3 Oct 2025 14:12:18 +0000 (UTC) Date: Fri, 3 Oct 2025 15:12:18 +0100 From: "Richard W.M. Jones" To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, berrange@redhat.com Subject: Re: [PATCH v1 1/2] Implement -run-with exit-with-parent=on Message-ID: <20251003141217.GB5720@redhat.com> References: <20251003133158.3978333-1-rjones@redhat.com> <20251003133158.3978333-2-rjones@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251003133158.3978333-2-rjones@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass client-ip=170.10.133.124; envelope-from=rjones@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.467, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, Oct 03, 2025 at 02:24:37PM +0100, Richard W.M. Jones wrote: [...] > +int > +set_exit_with_parent(void) > +{ > + int r; > + QemuThread exit_with_parent_thread; > + > + /* > + * We have to block waiting for kevent, so that requires that we > + * start a background thread. > + */ > + qemu_thread_create(&exit_with_parent_thread, > + "exit-parent", > + exit_with_parent_loop, NULL, > + QEMU_THREAD_DETACHED); > + return 0; > +} 'r' is unused. Fixed in my local copy. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://people.redhat.com/~rjones/virt-top