From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E36F2C236B for ; Fri, 3 Oct 2025 16:42:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759509754; cv=none; b=hroGfmB6xFMONNpnBRGEh1xbOmRd9HCQCB4OgEzJVO7izqPCiCUVqxbnOXjmp1lTa2r9KPKyj/0Rj/Ffd6d41IxusLAHrxh/oSIvpSz91OEkJC4O8F5wM5H1ZlGHpDPVWqUjHdnLPSFEsC1pt/aKD648DmlQQNFzYJYZ0KtuDe8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759509754; c=relaxed/simple; bh=2vM9WbBxLoiNuv/ifCy0fu4bZYJPwZhrOYJXYV+rIOY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NP+jjmZ1O47qwJS63qfql6j6so5xsARoMNe+Oq/jPtRiC8Sat9kzAxss0yoZekrXSQ2qQtJ5qk646ZXSuCHLjdD2FYa1qenA9bOcCxtAKMes4iVbjOKs3TxRr04lNy8QWjmqqVwiHdIlzT7+ep2dWvXmYAAs2G9a7HZZ9qr759k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gVIn6FBV; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gVIn6FBV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3ACB6C4CEFF; Fri, 3 Oct 2025 16:42:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1759509751; bh=2vM9WbBxLoiNuv/ifCy0fu4bZYJPwZhrOYJXYV+rIOY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gVIn6FBVKBz4QYlzib5FZIUskpCeUR60qSL+NRIAHbT6RlQt3E0INPErmauR504q+ L3NeFivZaFMX3TwmCI3lwvQC+sH2900k2mlQnkwl8cQy1LZK5ar4AYct0Aj7z46m/O X8D1Jva2J6KrmD3XA5Gsmzz3V944UyqHzQvdz/4gEKLKQ4YMwtO0NrUbB4pG3/os5X yyorYwivaV1hORnhPBjwua3eWeHx4abtdRi05aIxAT+uzo43u2snqHRAklrd+s5Ydu dChvjFg7XG8D/PniCji1PTdTR5348ZLm1C6lZK+cDThyfCplKLeRgwdS9QcnJtbiZp xyO9+0BSmpzLQ== Date: Fri, 3 Oct 2025 09:42:27 -0700 From: Eric Biggers To: Jan Prusakowski Cc: Zorro Lang , Chao Yu , fstests@vger.kernel.org, jaegeuk@kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [PATCH v2 1/1] common/encrypt: Do not run _verify_ciphertext_for_encryption_policy on compressed FS Message-ID: <20251003164227.GA1649@quark> References: <20250915100451.810719-1-jprusakowski@google.com> <20250915100451.810719-2-jprusakowski@google.com> <20250915143951.GB1993@quark> Precedence: bulk X-Mailing-List: fstests@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Sep 16, 2025 at 02:13:39PM +0200, Jan Prusakowski wrote: > On Mon, Sep 15, 2025 at 4:40 PM Eric Biggers wrote: > > > > On Mon, Sep 15, 2025 at 12:04:51PM +0200, Jan Prusakowski wrote: > > > common/encrypt: Do not run _verify_ciphertext_for_encryption_policy on compressed FS > > > > A better title would be something like > > "common/encrypt: Explicitly set the test file to uncompressed". > > Agreed, will fix that in v3. > > > > @@ -790,6 +790,13 @@ _do_verify_ciphertext_for_encryption_policy() > > > _set_encpolicy $dir $keyspec $set_encpolicy_args -f $policy_flags > > > for src in $tmp.testfile_*; do > > > dst=$dir/${src##*.} > > > + # To make sure the test file is not compressed we create an empty one > > > + # and disable compression first (F2FS won't allow resetting the > > > + # compression flag if the file has data already in it). > > > + touch $dst > > > + if lsattr $dst | grep -qE ".+c.+ $dst" ; then > > > + chattr -c $dst > > > + fi > > > cp $src $dst > > > inode=$(stat -c %i $dst) > > > blocklist=$(_get_ciphertext_block_list $dst) > > > > Is adding 'm' (FS_NOCOMP_FL) needed too? If not, why does it exist? > > In my setup files created have FS_COMPR_FL set from the start. Just clearing > FS_COMPR_FL appears to help as now all the tests using > _verify_ciphertext_for_encryption_policy > pass when I run them on f2fs with "-o compress_extension=*". > > Do you think we should add 'm' (FS_NOCOMP_FL) as well just in case some other FS > behaves differently? Do you have any ideas on what other FS I should check? I think so. It doesn't look like f2fs does anything with FS_NOCOMP_FL, other than enforce that it's mutually exclusive with FS_COMPR_FL. But there could be filesystems where 0 gives the default behavior (which could be compress) and FS_NOCOMP_FL is needed to disable compression. btrfs might do that, actually. It doesn't support encryption yet, though, so these tests can't be run on btrfs. I would just add FS_NOCOMP_FL and make sure it still works on f2fs. - Eric From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 54771CAC5B0 for ; Fri, 3 Oct 2025 16:42:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:In-Reply-To:MIME-Version:References: Message-ID:To:Date:Sender:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=K3rIhWb95znz0mV6cq65N5V0i3pOrB+qul544grhNfk=; b=ffMjIhYKQWvRATYUAMolqS/bxH RGbKeES9Fky7TqkjHB+7zkyCRbXLXYBCms7ziJ6RCn5cMhM7z9LnlmmSKtcV5vZg3mLhmtFCT2sOj FglE0XkYK1VJTpbmUjwUGVe1UFPajYVKKvWzO5iv784hQOarodpekwYDG+Vz55bBLuV4=; Received: from [127.0.0.1] (helo=sfs-ml-3.v29.lw.sourceforge.com) by sfs-ml-3.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1v4irk-0005Hd-D7; Fri, 03 Oct 2025 16:42:44 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-3.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1v4irj-0005HW-5h for linux-f2fs-devel@lists.sourceforge.net; Fri, 03 Oct 2025 16:42:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Transfer-Encoding:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=kaGKa/GsHfvvz+I6tQ1XQm45DL6OZE5hJiJAwo8qivc=; b=awN1D9yPl1A7QFjVO2Inc6myl3 bQ6jv0E99ugnBHuZAq7O6rDkkdzgwQ1aFNo2qmvIkqLUaanBNQOYNfE7KK2jAYa5qDeVK1DyVUsHU yLUlMWORppqyiZMYbwjd3aczMuKjkbGWVSPhAfpwnQx4fHaa4Y+bhenFsfz3g9m4BkCM=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=kaGKa/GsHfvvz+I6tQ1XQm45DL6OZE5hJiJAwo8qivc=; b=iX4RlaCYwE3gY18qtUps8afmgr 5++XeuyHESp+OlclJZ3u+kVCnisYS/y1XoGAgbKHLUZoB97Ly+QfV9wmPx2yw8TVPlWpSZXXvRiKV 9zT5sk48jq49mTaDKAFyoT0I1hQu2nd9i0pI8hMzfGP80v7ZMwFtsp+RbTKP1lWSJLiM=; Received: from tor.source.kernel.org ([172.105.4.254]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1v4iri-0001AL-NK for linux-f2fs-devel@lists.sourceforge.net; Fri, 03 Oct 2025 16:42:43 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by tor.source.kernel.org (Postfix) with ESMTP id 1046363D84; Fri, 3 Oct 2025 16:42:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3ACB6C4CEFF; Fri, 3 Oct 2025 16:42:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1759509751; bh=2vM9WbBxLoiNuv/ifCy0fu4bZYJPwZhrOYJXYV+rIOY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gVIn6FBVKBz4QYlzib5FZIUskpCeUR60qSL+NRIAHbT6RlQt3E0INPErmauR504q+ L3NeFivZaFMX3TwmCI3lwvQC+sH2900k2mlQnkwl8cQy1LZK5ar4AYct0Aj7z46m/O X8D1Jva2J6KrmD3XA5Gsmzz3V944UyqHzQvdz/4gEKLKQ4YMwtO0NrUbB4pG3/os5X yyorYwivaV1hORnhPBjwua3eWeHx4abtdRi05aIxAT+uzo43u2snqHRAklrd+s5Ydu dChvjFg7XG8D/PniCji1PTdTR5348ZLm1C6lZK+cDThyfCplKLeRgwdS9QcnJtbiZp xyO9+0BSmpzLQ== Date: Fri, 3 Oct 2025 09:42:27 -0700 To: Jan Prusakowski Message-ID: <20251003164227.GA1649@quark> References: <20250915100451.810719-1-jprusakowski@google.com> <20250915100451.810719-2-jprusakowski@google.com> <20250915143951.GB1993@quark> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Headers-End: 1v4iri-0001AL-NK Subject: Re: [f2fs-dev] [PATCH v2 1/1] common/encrypt: Do not run _verify_ciphertext_for_encryption_policy on compressed FS X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eric Biggers via Linux-f2fs-devel Reply-To: Eric Biggers Cc: jaegeuk@kernel.org, Zorro Lang , fstests@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net T24gVHVlLCBTZXAgMTYsIDIwMjUgYXQgMDI6MTM6MzlQTSArMDIwMCwgSmFuIFBydXNha293c2tp IHdyb3RlOgo+IE9uIE1vbiwgU2VwIDE1LCAyMDI1IGF0IDQ6NDDigK9QTSBFcmljIEJpZ2dlcnMg PGViaWdnZXJzQGtlcm5lbC5vcmc+IHdyb3RlOgo+ID4KPiA+IE9uIE1vbiwgU2VwIDE1LCAyMDI1 IGF0IDEyOjA0OjUxUE0gKzAyMDAsIEphbiBQcnVzYWtvd3NraSB3cm90ZToKPiA+ID4gY29tbW9u L2VuY3J5cHQ6IERvIG5vdCBydW4gX3ZlcmlmeV9jaXBoZXJ0ZXh0X2Zvcl9lbmNyeXB0aW9uX3Bv bGljeSBvbiBjb21wcmVzc2VkIEZTCj4gPgo+ID4gQSBiZXR0ZXIgdGl0bGUgd291bGQgYmUgc29t ZXRoaW5nIGxpa2UKPiA+ICJjb21tb24vZW5jcnlwdDogRXhwbGljaXRseSBzZXQgdGhlIHRlc3Qg ZmlsZSB0byB1bmNvbXByZXNzZWQiLgo+IAo+IEFncmVlZCwgd2lsbCBmaXggdGhhdCBpbiB2My4K PiAKPiA+ID4gQEAgLTc5MCw2ICs3OTAsMTMgQEAgX2RvX3ZlcmlmeV9jaXBoZXJ0ZXh0X2Zvcl9l bmNyeXB0aW9uX3BvbGljeSgpCj4gPiA+ICAgICAgIF9zZXRfZW5jcG9saWN5ICRkaXIgJGtleXNw ZWMgJHNldF9lbmNwb2xpY3lfYXJncyAtZiAkcG9saWN5X2ZsYWdzCj4gPiA+ICAgICAgIGZvciBz cmMgaW4gJHRtcC50ZXN0ZmlsZV8qOyBkbwo+ID4gPiAgICAgICAgICAgICAgIGRzdD0kZGlyLyR7 c3JjIyMqLn0KPiA+ID4gKyAgICAgICAgICAgICAjIFRvIG1ha2Ugc3VyZSB0aGUgdGVzdCBmaWxl IGlzIG5vdCBjb21wcmVzc2VkIHdlIGNyZWF0ZSBhbiBlbXB0eSBvbmUKPiA+ID4gKyAgICAgICAg ICAgICAjIGFuZCBkaXNhYmxlIGNvbXByZXNzaW9uIGZpcnN0IChGMkZTIHdvbid0IGFsbG93IHJl c2V0dGluZyB0aGUKPiA+ID4gKyAgICAgICAgICAgICAjIGNvbXByZXNzaW9uIGZsYWcgaWYgdGhl IGZpbGUgaGFzIGRhdGEgYWxyZWFkeSBpbiBpdCkuCj4gPiA+ICsgICAgICAgICAgICAgdG91Y2gg JGRzdAo+ID4gPiArICAgICAgICAgICAgIGlmIGxzYXR0ciAkZHN0IHwgZ3JlcCAtcUUgIi4rYy4r ICRkc3QiIDsgdGhlbgo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgY2hhdHRyIC1jICRkc3QK PiA+ID4gKyAgICAgICAgICAgICBmaQo+ID4gPiAgICAgICAgICAgICAgIGNwICRzcmMgJGRzdAo+ ID4gPiAgICAgICAgICAgICAgIGlub2RlPSQoc3RhdCAtYyAlaSAkZHN0KQo+ID4gPiAgICAgICAg ICAgICAgIGJsb2NrbGlzdD0kKF9nZXRfY2lwaGVydGV4dF9ibG9ja19saXN0ICRkc3QpCj4gPgo+ ID4gSXMgYWRkaW5nICdtJyAoRlNfTk9DT01QX0ZMKSBuZWVkZWQgdG9vPyAgSWYgbm90LCB3aHkg ZG9lcyBpdCBleGlzdD8KPiAKPiBJbiBteSBzZXR1cCBmaWxlcyBjcmVhdGVkIGhhdmUgRlNfQ09N UFJfRkwgc2V0IGZyb20gdGhlIHN0YXJ0LiBKdXN0IGNsZWFyaW5nCj4gRlNfQ09NUFJfRkwgYXBw ZWFycyB0byBoZWxwIGFzIG5vdyBhbGwgdGhlIHRlc3RzIHVzaW5nCj4gX3ZlcmlmeV9jaXBoZXJ0 ZXh0X2Zvcl9lbmNyeXB0aW9uX3BvbGljeQo+IHBhc3Mgd2hlbiBJIHJ1biB0aGVtIG9uIGYyZnMg d2l0aCAiLW8gY29tcHJlc3NfZXh0ZW5zaW9uPSoiLgo+IAo+IERvIHlvdSB0aGluayB3ZSBzaG91 bGQgYWRkICdtJyAoRlNfTk9DT01QX0ZMKSBhcyB3ZWxsIGp1c3QgaW4gY2FzZSBzb21lIG90aGVy IEZTCj4gYmVoYXZlcyBkaWZmZXJlbnRseT8gRG8geW91IGhhdmUgYW55IGlkZWFzIG9uIHdoYXQg b3RoZXIgRlMgSSBzaG91bGQgY2hlY2s/CgpJIHRoaW5rIHNvLiAgSXQgZG9lc24ndCBsb29rIGxp a2UgZjJmcyBkb2VzIGFueXRoaW5nIHdpdGggRlNfTk9DT01QX0ZMLApvdGhlciB0aGFuIGVuZm9y Y2UgdGhhdCBpdCdzIG11dHVhbGx5IGV4Y2x1c2l2ZSB3aXRoIEZTX0NPTVBSX0ZMLiAgQnV0CnRo ZXJlIGNvdWxkIGJlIGZpbGVzeXN0ZW1zIHdoZXJlIDAgZ2l2ZXMgdGhlIGRlZmF1bHQgYmVoYXZp b3IgKHdoaWNoCmNvdWxkIGJlIGNvbXByZXNzKSBhbmQgRlNfTk9DT01QX0ZMIGlzIG5lZWRlZCB0 byBkaXNhYmxlIGNvbXByZXNzaW9uLgoKYnRyZnMgbWlnaHQgZG8gdGhhdCwgYWN0dWFsbHkuICBJ dCBkb2Vzbid0IHN1cHBvcnQgZW5jcnlwdGlvbiB5ZXQsCnRob3VnaCwgc28gdGhlc2UgdGVzdHMg Y2FuJ3QgYmUgcnVuIG9uIGJ0cmZzLgoKSSB3b3VsZCBqdXN0IGFkZCBGU19OT0NPTVBfRkwgYW5k IG1ha2Ugc3VyZSBpdCBzdGlsbCB3b3JrcyBvbiBmMmZzLgoKLSBFcmljCgoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgtZjJmcy1kZXZlbCBtYWls aW5nIGxpc3QKTGludXgtZjJmcy1kZXZlbEBsaXN0cy5zb3VyY2Vmb3JnZS5uZXQKaHR0cHM6Ly9s aXN0cy5zb3VyY2Vmb3JnZS5uZXQvbGlzdHMvbGlzdGluZm8vbGludXgtZjJmcy1kZXZlbAo=