diff for duplicates of <202510032329.NN83GCga-lkp@intel.com> diff --git a/a/1.txt b/N1/1.txt index 3f1bc2a..fd5f8d7 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,27 +1,53 @@ +BCC: lkp@intel.com +CC: oe-kbuild-all@lists.linux.dev +In-Reply-To: <20250929132805.220558-17-ematsumiya@suse.de> +References: <20250929132805.220558-17-ematsumiya@suse.de> +TO: Enzo Matsumiya <ematsumiya@suse.de> +TO: linux-cifs@vger.kernel.org +CC: smfrench@gmail.com +CC: pc@manguebit.com +CC: ronniesahlberg@gmail.com +CC: sprasad@microsoft.com +CC: tom@talpey.com +CC: bharathsm@microsoft.com +CC: henrique.carvalho@suse.com + Hi Enzo, kernel test robot noticed the following build warnings: +[auto build test WARNING on v6.17] +[also build test WARNING on linus/master] +[cannot apply to cifs/for-next next-20251003] +[If your patch is applied to the wrong git tree, kindly drop us a note. +And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Enzo-Matsumiya/smb-client-remove-cfids_invalidation_worker/20250929-213155 base: v6.17 patch link: https://lore.kernel.org/r/20250929132805.220558-17-ematsumiya%40suse.de patch subject: [PATCH 16/20] smb: client: add is_dir argument to query_path_info +:::::: branch date: 4 days ago +:::::: commit date: 4 days ago config: i386-randconfig-141-20251003 (https://download.01.org/0day-ci/archive/20251003/202510032329.NN83GCga-lkp@intel.com/config) compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> -| Reported-by: Dan Carpenter <dan.carpenter@linaro.org> +| Reported-by: Dan Carpenter <error27@gmail.com> | Closes: https://lore.kernel.org/r/202510032329.NN83GCga-lkp@intel.com/ New smatch warnings: fs/smb/client/inode.c:1313 cifs_get_fattr() error: we previously assumed 'inode' could be null (see line 1288) +Old smatch warnings: +fs/smb/client/inode.c:1708 cifs_root_iget() warn: passing zero to 'ERR_PTR' +fs/smb/client/inode.c:2334 cifs_mkdir() warn: passing zero to 'ERR_PTR' + vim +/inode +1313 fs/smb/client/inode.c +5f71ebc4129449 fs/smb/client/inode.c Paulo Alcantara 2023-08-17 1258 a18280e7fdea1f fs/smb/client/inode.c Paulo Alcantara 2023-08-17 1259 static int cifs_get_fattr(struct cifs_open_info_data *data, a18280e7fdea1f fs/smb/client/inode.c Paulo Alcantara 2023-08-17 1260 struct super_block *sb, int xid, a18280e7fdea1f fs/smb/client/inode.c Paulo Alcantara 2023-08-17 1261 const struct cifs_fid *fid, @@ -52,10 +78,6 @@ b8f7442bc46e48 fs/cifs/inode.c Aurelien Aptel 2019-11-1 65e58ef1dafb0c fs/smb/client/inode.c Enzo Matsumiya 2025-09-29 1286 bool is_dir = false; 65e58ef1dafb0c fs/smb/client/inode.c Enzo Matsumiya 2025-09-29 1287 65e58ef1dafb0c fs/smb/client/inode.c Enzo Matsumiya 2025-09-29 @1288 if (inode && *inode) - -The check implies that "inode" can be NULL. Pretty sure this -check can be removed unless something changed out of tree. - 65e58ef1dafb0c fs/smb/client/inode.c Enzo Matsumiya 2025-09-29 1289 is_dir = S_ISDIR((*inode)->i_mode); 65e58ef1dafb0c fs/smb/client/inode.c Enzo Matsumiya 2025-09-29 1290 8b4e285d8ce3c6 fs/smb/client/inode.c Paulo Alcantara 2023-08-17 1291 rc = server->ops->query_path_info(xid, tcon, cifs_sb, @@ -81,13 +103,6 @@ a18280e7fdea1f fs/smb/client/inode.c Paulo Alcantara 2023-08-1 a18280e7fdea1f fs/smb/client/inode.c Paulo Alcantara 2023-08-17 1311 cifs_open_info_to_fattr(fattr, data, sb); 76894f3e2f7117 fs/cifs/inode.c Paulo Alcantara 2022-10-03 1312 } ec4535b2a1d709 fs/smb/client/inode.c Paulo Alcantara 2024-04-08 @1313 if (!rc && *inode && - ^^^^^^ - -The rest of the function assumes inode is a valid pointer. - -regards, -dan carpenter - ec4535b2a1d709 fs/smb/client/inode.c Paulo Alcantara 2024-04-08 1314 (fattr->cf_flags & CIFS_FATTR_DELETE_PENDING)) fc20c523211a38 fs/smb/client/inode.c Meetakshi Setiya 2024-03-14 1315 cifs_mark_open_handles_for_deleted_file(*inode, full_path); b8f7442bc46e48 fs/cifs/inode.c Aurelien Aptel 2019-11-18 1316 break; @@ -202,6 +217,7 @@ b8f7442bc46e48 fs/cifs/inode.c Aurelien Aptel 2019-11-1 76894f3e2f7117 fs/cifs/inode.c Paulo Alcantara 2022-10-03 1425 cifs_free_open_info(&tmp_data); a18280e7fdea1f fs/smb/client/inode.c Paulo Alcantara 2023-08-17 1426 return rc; a18280e7fdea1f fs/smb/client/inode.c Paulo Alcantara 2023-08-17 1427 } +a18280e7fdea1f fs/smb/client/inode.c Paulo Alcantara 2023-08-17 1428 -- 0-DAY CI Kernel Test Service diff --git a/a/content_digest b/N1/content_digest index 6bdc6e9..74424f8 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,45 +1,61 @@ - "ref\020250929132805.220558-17-ematsumiya@suse.de\0" - "From\0Dan Carpenter <dan.carpenter@linaro.org>\0" + "From\0kernel test robot <lkp@intel.com>\0" "Subject\0Re: [PATCH 16/20] smb: client: add is_dir argument to query_path_info\0" - "Date\0Fri, 3 Oct 2025 20:20:50 +0300\0" - "To\0oe-kbuild@lists.linux.dev" - Enzo Matsumiya <ematsumiya@suse.de> - " linux-cifs@vger.kernel.org\0" + "Date\0Sat, 4 Oct 2025 01:04:03 +0800\0" + "To\0oe-kbuild@lists.linux.dev\0" "Cc\0lkp@intel.com" - oe-kbuild-all@lists.linux.dev - smfrench@gmail.com - pc@manguebit.com - ronniesahlberg@gmail.com - sprasad@microsoft.com - tom@talpey.com - bharathsm@microsoft.com - " henrique.carvalho@suse.com\0" + " Dan Carpenter <error27@gmail.com>\0" "\00:1\0" "b\0" + "BCC: lkp@intel.com\n" + "CC: oe-kbuild-all@lists.linux.dev\n" + "In-Reply-To: <20250929132805.220558-17-ematsumiya@suse.de>\n" + "References: <20250929132805.220558-17-ematsumiya@suse.de>\n" + "TO: Enzo Matsumiya <ematsumiya@suse.de>\n" + "TO: linux-cifs@vger.kernel.org\n" + "CC: smfrench@gmail.com\n" + "CC: pc@manguebit.com\n" + "CC: ronniesahlberg@gmail.com\n" + "CC: sprasad@microsoft.com\n" + "CC: tom@talpey.com\n" + "CC: bharathsm@microsoft.com\n" + "CC: henrique.carvalho@suse.com\n" + "\n" "Hi Enzo,\n" "\n" "kernel test robot noticed the following build warnings:\n" "\n" + "[auto build test WARNING on v6.17]\n" + "[also build test WARNING on linus/master]\n" + "[cannot apply to cifs/for-next next-20251003]\n" + "[If your patch is applied to the wrong git tree, kindly drop us a note.\n" + "And when submitting patch, we suggest to use '--base' as documented in\n" "https://git-scm.com/docs/git-format-patch#_base_tree_information]\n" "\n" "url: https://github.com/intel-lab-lkp/linux/commits/Enzo-Matsumiya/smb-client-remove-cfids_invalidation_worker/20250929-213155\n" "base: v6.17\n" "patch link: https://lore.kernel.org/r/20250929132805.220558-17-ematsumiya%40suse.de\n" "patch subject: [PATCH 16/20] smb: client: add is_dir argument to query_path_info\n" + ":::::: branch date: 4 days ago\n" + ":::::: commit date: 4 days ago\n" "config: i386-randconfig-141-20251003 (https://download.01.org/0day-ci/archive/20251003/202510032329.NN83GCga-lkp@intel.com/config)\n" "compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)\n" "\n" "If you fix the issue in a separate patch/commit (i.e. not just a new version of\n" "the same patch/commit), kindly add following tags\n" "| Reported-by: kernel test robot <lkp@intel.com>\n" - "| Reported-by: Dan Carpenter <dan.carpenter@linaro.org>\n" + "| Reported-by: Dan Carpenter <error27@gmail.com>\n" "| Closes: https://lore.kernel.org/r/202510032329.NN83GCga-lkp@intel.com/\n" "\n" "New smatch warnings:\n" "fs/smb/client/inode.c:1313 cifs_get_fattr() error: we previously assumed 'inode' could be null (see line 1288)\n" "\n" + "Old smatch warnings:\n" + "fs/smb/client/inode.c:1708 cifs_root_iget() warn: passing zero to 'ERR_PTR'\n" + "fs/smb/client/inode.c:2334 cifs_mkdir() warn: passing zero to 'ERR_PTR'\n" + "\n" "vim +/inode +1313 fs/smb/client/inode.c\n" "\n" + "5f71ebc4129449 fs/smb/client/inode.c Paulo Alcantara 2023-08-17 1258 \n" "a18280e7fdea1f fs/smb/client/inode.c Paulo Alcantara 2023-08-17 1259 static int cifs_get_fattr(struct cifs_open_info_data *data,\n" "a18280e7fdea1f fs/smb/client/inode.c Paulo Alcantara 2023-08-17 1260 \t\t\t struct super_block *sb, int xid,\n" "a18280e7fdea1f fs/smb/client/inode.c Paulo Alcantara 2023-08-17 1261 \t\t\t const struct cifs_fid *fid,\n" @@ -70,10 +86,6 @@ "65e58ef1dafb0c fs/smb/client/inode.c Enzo Matsumiya 2025-09-29 1286 \t\tbool is_dir = false;\n" "65e58ef1dafb0c fs/smb/client/inode.c Enzo Matsumiya 2025-09-29 1287 \n" "65e58ef1dafb0c fs/smb/client/inode.c Enzo Matsumiya 2025-09-29 @1288 \t\tif (inode && *inode)\n" - "\n" - "The check implies that \"inode\" can be NULL. Pretty sure this\n" - "check can be removed unless something changed out of tree.\n" - "\n" "65e58ef1dafb0c fs/smb/client/inode.c Enzo Matsumiya 2025-09-29 1289 \t\t\tis_dir = S_ISDIR((*inode)->i_mode);\n" "65e58ef1dafb0c fs/smb/client/inode.c Enzo Matsumiya 2025-09-29 1290 \n" "8b4e285d8ce3c6 fs/smb/client/inode.c Paulo Alcantara 2023-08-17 1291 \t\trc = server->ops->query_path_info(xid, tcon, cifs_sb,\n" @@ -99,13 +111,6 @@ "a18280e7fdea1f fs/smb/client/inode.c Paulo Alcantara 2023-08-17 1311 \t\t\tcifs_open_info_to_fattr(fattr, data, sb);\n" "76894f3e2f7117 fs/cifs/inode.c Paulo Alcantara 2022-10-03 1312 \t\t}\n" "ec4535b2a1d709 fs/smb/client/inode.c Paulo Alcantara 2024-04-08 @1313 \t\tif (!rc && *inode &&\n" - " ^^^^^^\n" - "\n" - "The rest of the function assumes inode is a valid pointer.\n" - "\n" - "regards,\n" - "dan carpenter\n" - "\n" "ec4535b2a1d709 fs/smb/client/inode.c Paulo Alcantara 2024-04-08 1314 \t\t (fattr->cf_flags & CIFS_FATTR_DELETE_PENDING))\n" "fc20c523211a38 fs/smb/client/inode.c Meetakshi Setiya 2024-03-14 1315 \t\t\tcifs_mark_open_handles_for_deleted_file(*inode, full_path);\n" "b8f7442bc46e48 fs/cifs/inode.c Aurelien Aptel 2019-11-18 1316 \t\tbreak;\n" @@ -220,9 +225,10 @@ "76894f3e2f7117 fs/cifs/inode.c Paulo Alcantara 2022-10-03 1425 \tcifs_free_open_info(&tmp_data);\n" "a18280e7fdea1f fs/smb/client/inode.c Paulo Alcantara 2023-08-17 1426 \treturn rc;\n" "a18280e7fdea1f fs/smb/client/inode.c Paulo Alcantara 2023-08-17 1427 }\n" + "a18280e7fdea1f fs/smb/client/inode.c Paulo Alcantara 2023-08-17 1428 \n" "\n" "-- \n" "0-DAY CI Kernel Test Service\n" https://github.com/intel/lkp-tests/wiki -893eafd8390012ecf79fe8af13b226606989afd6c5bb70bb5a60e2a62e0985dd +e97fc58dba8c2c736873e19f0410c298dc58bce10af75ab833876f566d956524
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.