From: Simon Horman <horms@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, andrew+netdev@lunn.ch, bpf@vger.kernel.org,
alexanderduyck@fb.com, sdf@fomichev.me, mohsin.bashr@gmail.com
Subject: Re: [PATCH net 3/9] eth: fbnic: fix saving stats from XDP_TX rings on close
Date: Sat, 4 Oct 2025 17:45:56 +0100 [thread overview]
Message-ID: <20251004164556.GH3060232@horms.kernel.org> (raw)
In-Reply-To: <20251003233025.1157158-4-kuba@kernel.org>
On Fri, Oct 03, 2025 at 04:30:19PM -0700, Jakub Kicinski wrote:
> When rings are freed - stats get added to the device level stat
> structs. Save the stats from the XDP_TX ring just as Tx stats.
> Previously they would be saved to Rx and Tx stats. So we'd not
> see XDP_TX packets as Rx during runtime but after an down/up cycle
> the packets would appear in stats.
>
> Correct the helper used by ethtool code which does a runtime
> config switch.
>
> Fixes: 5213ff086344 ("eth: fbnic: Collect packet statistics for XDP")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2025-10-04 16:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-03 23:30 [PATCH net 0/9] eth: fbnic: fix XDP_TX and XDP vs qstats Jakub Kicinski
2025-10-03 23:30 ` [PATCH net 1/9] eth: fbnic: fix missing programming of the default descriptor Jakub Kicinski
2025-10-04 16:44 ` Simon Horman
2025-10-03 23:30 ` [PATCH net 2/9] eth: fbnic: fix accounting of XDP packets Jakub Kicinski
2025-10-04 16:45 ` Simon Horman
2025-10-03 23:30 ` [PATCH net 3/9] eth: fbnic: fix saving stats from XDP_TX rings on close Jakub Kicinski
2025-10-04 16:45 ` Simon Horman [this message]
2025-10-03 23:30 ` [PATCH net 4/9] selftests: drv-net: xdp: rename netnl to ethnl Jakub Kicinski
2025-10-04 16:46 ` Simon Horman
2025-10-03 23:30 ` [PATCH net 5/9] selftests: drv-net: xdp: add test for interface level qstats Jakub Kicinski
2025-10-04 16:47 ` Simon Horman
2025-10-03 23:30 ` [PATCH net 6/9] eth: fbnic: fix reporting of alloc_failed qstats Jakub Kicinski
2025-10-04 16:48 ` Simon Horman
2025-10-03 23:30 ` [PATCH net 7/9] selftests: drv-net: fix linter warnings in pp_alloc_fail Jakub Kicinski
2025-10-04 16:48 ` Simon Horman
2025-10-03 23:30 ` [PATCH net 8/9] selftests: drv-net: pp_alloc_fail: lower traffic expectations Jakub Kicinski
2025-10-04 16:44 ` Simon Horman
2025-10-03 23:30 ` [PATCH net 9/9] selftests: drv-net: pp_alloc_fail: add necessary optoins to config Jakub Kicinski
2025-10-04 16:48 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251004164556.GH3060232@horms.kernel.org \
--to=horms@kernel.org \
--cc=alexanderduyck@fb.com \
--cc=andrew+netdev@lunn.ch \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=mohsin.bashr@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.