From: Jakub Kicinski <kuba@kernel.org>
To: Petr Machata <petrm@nvidia.com>
Cc: <davem@davemloft.net>, <netdev@vger.kernel.org>,
<edumazet@google.com>, <pabeni@redhat.com>,
<andrew+netdev@lunn.ch>, <horms@kernel.org>,
"Antonio Quartulli" <antonio@openvpn.net>,
"Matthieu Baerts (NGI0)" <matttbe@kernel.org>,
Allison Henderson <allison.henderson@oracle.com>,
<shuah@kernel.org>, <jv@jvosburgh.net>, <olteanv@gmail.com>,
<jiri@resnulli.us>, <mst@redhat.com>, <jasowang@redhat.com>,
<xuanzhuo@linux.alibaba.com>, <eperezma@redhat.com>,
<kuniyu@google.com>, <martineau@kernel.org>,
<pablo@netfilter.org>, <kadlec@netfilter.org>, <fw@strlen.de>,
<razor@blackwall.org>, <idosch@nvidia.com>,
<linux-kselftest@vger.kernel.org>, <mptcp@lists.linux.dev>,
<netfilter-devel@vger.kernel.org>, <coreteam@netfilter.org>
Subject: Re: [PATCH net v2] selftests: net: unify the Makefile formats
Date: Mon, 6 Oct 2025 10:30:12 -0700 [thread overview]
Message-ID: <20251006103012.0493a4b4@kernel.org> (raw)
In-Reply-To: <87o6qkcnol.fsf@nvidia.com>
On Mon, 6 Oct 2025 11:40:59 +0200 Petr Machata wrote:
> > We get a significant number of conflicts between net and net-next
> > because of selftests Makefile changes. People tend to append new
> > test cases at the end of the Makefile when there's no clear sort
> > order. Sort all networking selftests Makefiles, use the following
> > format:
>
> If we see weird errors in CI, it might be because tests now run in a
> different order and previously masked missed cleanups are now exposed.
Yes, sorry. I enabled the check before merging this so there's probably
some transient false positives. Which is fine, the pw checks are for
maintainers? :)
> > diff --git a/tools/testing/selftests/drivers/net/dsa/Makefile b/tools/testing/selftests/drivers/net/dsa/Makefile
> > index cd6817fe5be6..699e3565d735 100644
> > --- a/tools/testing/selftests/drivers/net/dsa/Makefile
> > +++ b/tools/testing/selftests/drivers/net/dsa/Makefile
> > @@ -9,11 +9,13 @@ TEST_PROGS = bridge_locked_port.sh \
>
> This should have the header converted as well:
>
> TEST_PROGS := \
> bridge_locked_port.sh \
Ack, let me fix when applying.
next prev parent reply other threads:[~2025-10-06 17:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-03 21:01 [PATCH net v2] selftests: net: unify the Makefile formats Jakub Kicinski
2025-10-06 9:40 ` Petr Machata
2025-10-06 17:30 ` Jakub Kicinski [this message]
2025-10-06 20:34 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251006103012.0493a4b4@kernel.org \
--to=kuba@kernel.org \
--cc=allison.henderson@oracle.com \
--cc=andrew+netdev@lunn.ch \
--cc=antonio@openvpn.net \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eperezma@redhat.com \
--cc=fw@strlen.de \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=jasowang@redhat.com \
--cc=jiri@resnulli.us \
--cc=jv@jvosburgh.net \
--cc=kadlec@netfilter.org \
--cc=kuniyu@google.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=martineau@kernel.org \
--cc=matttbe@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
--cc=petrm@nvidia.com \
--cc=razor@blackwall.org \
--cc=shuah@kernel.org \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.