Re: [PATCH] staging: iio: ad9832: move ad9832_platform_data into include/linux/lib

[Jonathan Cameron <jonathan.cameron@huawei.com>]

On Sun, 5 Oct 2025 16:00:33 +0200
Greg KH <gregkh@linuxfoundation.org> wrote:

> On Sun, Oct 05, 2025 at 05:18:29PM +0500, Taimoor Zaeem wrote:
> > Move struct ad9832_platform_data from
> > drivers/staging/iio/frequency/ad9832.h to
> > include/linux/iio/frequency/ad9832.h.
> > 
> > This clears a TODO item in the drivers.  
> 
> No, this should only happen when the whole driver moves out of
> drivers/staging/, staging drivers shoul dbe self-contained.
> 
> Also, why is a .h file needed for just one file anyway?  Shouldn't this
> be part of the .c file instead?

It's an old school board file / platform data definition.

So it would be fine to get rid of that entirely and move the
driver to appropriate modern firmware interfaces but if we keep the
struct definition it doesn't make sense to move it into the C file.

I'm edging closer to just posting a series to get rid of these
remaining IIO drivers in staging, but normally I've only done that
when the parts have gone out of production as until that point it
seems reasonable that they might eventually get cleaned up, ABI
fixed etc and the costs of keeping them around are low.

Nuno, can you see if you can get a view from ADI on whether there
will ever be any effort to sort these ancient drivers out?
I appreciate that may be challenging to answer though.

Jonathan

> 
> thanks,
> 
> greg k-h
>