From: Chuck Lever <cel@kernel.org>
To: NeilBrown <neil@brown.name>, Jeff Layton <jlayton@kernel.org>,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <dai.ngo@oracle.com>, Tom Talpey <tom@talpey.com>
Cc: <linux-nfs@vger.kernel.org>, Chuck Lever <chuck.lever@oracle.com>
Subject: [PATCH v2 0/4] Fix unwanted memory overwrites
Date: Tue, 7 Oct 2025 12:04:09 -0400 [thread overview]
Message-ID: <20251007160413.4953-1-cel@kernel.org> (raw)
From: Chuck Lever <chuck.lever@oracle.com>
<rtm@csail.mit.edu> reported some memory overwrites that can be
triggered by NFS client input. I was able to observe overwrites
by enabling KASAN and running his reproducer [1].
NFSD caches COMPOUNDs containing only a single SEQUENCE operation
whether the client requests it to or not, in order to work around a
deficiency in the NFSv4.1 protocol. However, the predicate that
identifies solo SEQUENCE operations was incorrect.
Changes since v1:
* Reordered patches
* Disable caching of solo SEQUENCE operations
* Additional clean up
Chuck Lever (4):
NFSD: Skip close replay processing if XDR encoding fails
NFSD: Fix the "is this a solo SEQUENCE" predicate
NFSD: Do not cache solo SEQUENCE operations
NFSD: Move nfsd4_cache_this()
fs/nfsd/nfs4state.c | 23 +++++++++++++++++++++++
fs/nfsd/nfs4xdr.c | 3 +--
fs/nfsd/xdr4.h | 21 ---------------------
3 files changed, 24 insertions(+), 23 deletions(-)
--
2.51.0
next reply other threads:[~2025-10-07 16:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-07 16:04 Chuck Lever [this message]
2025-10-07 16:04 ` [PATCH v2 1/4] NFSD: Skip close replay processing if XDR encoding fails Chuck Lever
2025-10-07 16:04 ` [PATCH v2 2/4] NFSD: Fix the "is this a solo SEQUENCE" predicate Chuck Lever
2025-10-07 17:18 ` Jeff Layton
2025-10-07 16:04 ` [PATCH v2 3/4] NFSD: Do not cache solo SEQUENCE operations Chuck Lever
2025-10-07 17:19 ` Jeff Layton
2025-10-07 20:05 ` Chuck Lever
2025-10-07 22:12 ` NeilBrown
2025-10-08 13:04 ` Chuck Lever
2025-10-08 22:03 ` NeilBrown
2025-10-09 12:56 ` Chuck Lever
2025-10-09 23:29 ` NeilBrown
2025-10-10 13:03 ` Chuck Lever
2025-10-11 0:55 ` NeilBrown
2025-10-11 15:30 ` Chuck Lever
2025-10-07 22:21 ` Calum Mackay
2025-10-07 16:04 ` [PATCH v2 4/4] NFSD: Move nfsd4_cache_this() Chuck Lever
2025-10-07 17:20 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251007160413.4953-1-cel@kernel.org \
--to=cel@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=dai.ngo@oracle.com \
--cc=jlayton@kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neil@brown.name \
--cc=okorniev@redhat.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.