All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@nvidia.com>
To: Pasha Tatashin <pasha.tatashin@soleen.com>
Cc: Jonathan Corbet <corbet@lwn.net>,
	iommu@lists.linux.dev, Joerg Roedel <joro@8bytes.org>,
	Justin Stitt <justinstitt@google.com>,
	Kevin Tian <kevin.tian@intel.com>,
	linux-doc@vger.kernel.org, linux-kselftest@vger.kernel.org,
	llvm@lists.linux.dev, Bill Wendling <morbo@google.com>,
	Nathan Chancellor <nathan@kernel.org>,
	Nick Desaulniers <nick.desaulniers+lkml@gmail.com>,
	Miguel Ojeda <ojeda@kernel.org>,
	Robin Murphy <robin.murphy@arm.com>,
	Shuah Khan <shuah@kernel.org>,
	Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
	Will Deacon <will@kernel.org>, Alexey Kardashevskiy <aik@amd.com>,
	Alejandro Jimenez <alejandro.j.jimenez@oracle.com>,
	James Gowans <jgowans@amazon.com>,
	Michael Roth <michael.roth@amd.com>,
	patches@lists.linux.dev
Subject: Re: [PATCH v6 00/15] Consolidate iommu page table implementations (AMD)
Date: Tue, 7 Oct 2025 14:54:07 -0300	[thread overview]
Message-ID: <20251007175407.GC3474167@nvidia.com> (raw)
In-Reply-To: <CA+CK2bBT80np3hZbSu=dRH8UOKT9RruHF3jtaXyTJUmNe8UfFQ@mail.gmail.com>

On Tue, Oct 07, 2025 at 01:44:54PM -0400, Pasha Tatashin wrote:
> I'm wondering if this work could be used in the future to expand
> page_table_check to support IOMMU page tables. For instance, every
> time a PTE is inserted or removed, an external state machine could
> check for false sharing or improper logic. This approach could
> significantly help with preventing and detecting memory corruption
> early.

Yeah, we could certainly add hooks for different checks

> The main requirement would be to define a common logic for all IOMMU
> page tables. For the existing page_table_check, we use double-mapping
> detection logic [1]. If we were to implement something similar for the
> IOMMU, what kind of logic could we apply?

Mostafa did this, which is pretty similar:

https://lore.kernel.org/linux-iommu/20251003173229.1533640-1-smostafa@google.com/

But he hooked up in the core map/unmap not directly in the page table code.

Jason

      reply	other threads:[~2025-10-07 17:54 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-07 16:11 [PATCH v6 00/15] Consolidate iommu page table implementations (AMD) Jason Gunthorpe
2025-10-07 16:11 ` [PATCH v6 01/15] genpt: Generic Page Table base API Jason Gunthorpe
2025-10-08 14:37   ` Jason Gunthorpe
2025-10-15  2:03   ` Tian, Kevin
2025-10-21 16:46     ` Jason Gunthorpe
2025-10-07 16:11 ` [PATCH v6 02/15] genpt: Add Documentation/ files Jason Gunthorpe
2025-10-07 16:11 ` [PATCH v6 03/15] iommupt: Add the basic structure of the iommu implementation Jason Gunthorpe
2025-10-15  7:25   ` Tian, Kevin
2025-10-21 14:07     ` Jason Gunthorpe
2025-10-07 16:11 ` [PATCH v6 04/15] iommupt: Add the AMD IOMMU v1 page table format Jason Gunthorpe
2025-10-07 16:11 ` [PATCH v6 05/15] iommupt: Add iova_to_phys op Jason Gunthorpe
2025-10-07 16:11 ` [PATCH v6 06/15] iommupt: Add unmap_pages op Jason Gunthorpe
2025-10-07 16:11 ` [PATCH v6 07/15] iommupt: Add map_pages op Jason Gunthorpe
2025-10-16  6:52   ` Tian, Kevin
2025-10-21 17:19     ` Jason Gunthorpe
2025-10-07 16:11 ` [PATCH v6 08/15] iommupt: Add read_and_clear_dirty op Jason Gunthorpe
2025-10-07 16:11 ` [PATCH v6 09/15] iommupt: Add a kunit test for Generic Page Table Jason Gunthorpe
2025-10-16  6:54   ` Tian, Kevin
2025-10-07 16:11 ` [PATCH v6 10/15] iommupt: Add a mock pagetable format for iommufd selftest to use Jason Gunthorpe
2025-10-07 16:11 ` [PATCH v6 11/15] iommufd: Change the selftest to use iommupt instead of xarray Jason Gunthorpe
2025-10-16  6:54   ` Tian, Kevin
2025-10-07 16:11 ` [PATCH v6 12/15] iommupt: Add the x86 64 bit page table format Jason Gunthorpe
2025-10-16  6:55   ` Tian, Kevin
2025-10-21 14:09     ` Jason Gunthorpe
2025-10-07 16:11 ` [PATCH v6 13/15] iommu/amd: Use the generic iommu page table Jason Gunthorpe
2025-10-07 16:11 ` [PATCH v6 14/15] iommu/amd: Remove AMD io_pgtable support Jason Gunthorpe
2025-10-07 16:12 ` [PATCH v6 15/15] iommupt: Add a kunit test for the IOMMU implementation Jason Gunthorpe
2025-10-16  6:55   ` Tian, Kevin
2025-10-07 17:44 ` [PATCH v6 00/15] Consolidate iommu page table implementations (AMD) Pasha Tatashin
2025-10-07 17:54   ` Jason Gunthorpe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251007175407.GC3474167@nvidia.com \
    --to=jgg@nvidia.com \
    --cc=aik@amd.com \
    --cc=alejandro.j.jimenez@oracle.com \
    --cc=corbet@lwn.net \
    --cc=iommu@lists.linux.dev \
    --cc=jgowans@amazon.com \
    --cc=joro@8bytes.org \
    --cc=justinstitt@google.com \
    --cc=kevin.tian@intel.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=michael.roth@amd.com \
    --cc=morbo@google.com \
    --cc=nathan@kernel.org \
    --cc=nick.desaulniers+lkml@gmail.com \
    --cc=ojeda@kernel.org \
    --cc=pasha.tatashin@soleen.com \
    --cc=patches@lists.linux.dev \
    --cc=robin.murphy@arm.com \
    --cc=shuah@kernel.org \
    --cc=suravee.suthikulpanit@amd.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.