From: Kees Cook <kees@kernel.org>
To: Qing Zhao <qing.zhao@oracle.com>
Cc: Claudiu Zissulescu <claziss@gmail.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
"linux-hardening@vger.kernel.org"
<linux-hardening@vger.kernel.org>
Subject: Re: [PATCH] arc: Add const attribute support for mathematical ARC builtins
Date: Tue, 7 Oct 2025 20:29:01 -0700 [thread overview]
Message-ID: <202510072026.568651EE@keescook> (raw)
In-Reply-To: <1B081822-82F3-43A1-B3C3-B0B377F50CE6@oracle.com>
On Tue, Oct 07, 2025 at 09:02:21PM +0000, Qing Zhao wrote:
> Hi, Kees,
>
> I took a look at the patch today.
> Overall, I think the patch is good and should work well.
Thanks!
> My major questions are:
>
> 1. Are the five functions in the current list the only functions in __builtin_arc_*** that
> have const attribute?
They are the only ones I can safely assert are const attribute without
doing additional work. I'm sure there are more, but I didn't feel
comfortable marking others.
> 2. In addition to “const” attribute, are there any other important attributes should be added for
> the arc builtins to enable more optimizations?
Again, I'm not sure. But my goal here is to make it possible to add
these going forward if people find stuff to add. Before this patch it
wasn't possible at all -- the infrastructure to do so was missing, so
that's what I wanted to add: the infrastructure and the first user. :)
--
Kees Cook
next prev parent reply other threads:[~2025-10-08 3:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-26 4:22 [PATCH] arc: Add const attribute support for mathematical ARC builtins Kees Cook
2025-09-30 17:09 ` Kees Cook
2025-10-07 21:02 ` Qing Zhao
2025-10-08 3:29 ` Kees Cook [this message]
2025-10-08 14:09 ` Qing Zhao
2025-10-14 20:16 ` Qing Zhao
2025-10-14 20:15 ` Qing Zhao
2025-10-14 20:15 ` Qing Zhao
2025-10-14 20:14 ` Qing Zhao
2025-10-15 8:34 ` Claudiu Zissulescu
2025-10-15 18:09 ` Qing Zhao
2025-10-15 21:20 ` Kees Cook
2025-10-15 21:28 ` Claudiu Zissulescu
2025-10-15 21:21 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202510072026.568651EE@keescook \
--to=kees@kernel.org \
--cc=claziss@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=linux-hardening@vger.kernel.org \
--cc=qing.zhao@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.