All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chuck Lever <cel@kernel.org>
To: Calum Mackay <calum.mackay@oracle.com>
Cc: <linux-nfs@vger.kernel.org>, Chuck Lever <chuck.lever@oracle.com>
Subject: [PATCH] SEQ_FALSE_RETRY is allowed for a solo SEQUENCE replay
Date: Tue,  7 Oct 2025 16:48:06 -0400	[thread overview]
Message-ID: <20251007204806.15560-1-cel@kernel.org> (raw)

From: Chuck Lever <chuck.lever@oracle.com>

RFC 8881 Section 2.10.6.1.3 appears to permit servers to reply
with NFS4ERR_SEQ_FALSE_RETRY for a replayed solo SEQUENCE. Update
the test to allow it to pass in that case.

See also commit d4604ee1fdf1 ("SEQ9f: make sure replied SEQUENCE is
really the same").

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
 nfs4.1/server41tests/st_sequence.py | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/nfs4.1/server41tests/st_sequence.py b/nfs4.1/server41tests/st_sequence.py
index 9be1096b9e8e..759fcd2b8d78 100644
--- a/nfs4.1/server41tests/st_sequence.py
+++ b/nfs4.1/server41tests/st_sequence.py
@@ -209,10 +209,11 @@ def testReplayCache006(t, env):
     res1 = sess.compound([], cache_this=True)
     check(res1)
     res2 = sess.compound([], cache_this=True, seq_delta=0)
-    check(res2)
+    check(res2, [NFS4_OK, NFS4ERR_SEQ_FALSE_RETRY])
     res1.tag = res2.tag = b""
-    if not nfs4lib.test_equal(res1, res2):
-        fail("Replay results not equal")
+    if res2.status == NFS4_OK:
+        if not nfs4lib.test_equal(res1, res2):
+            fail("Replay results not equal")
 
 def testReplayCache007(t, env):
     """Send two successful non-idempotent compounds with same seqid and False cache_this
-- 
2.51.0


                 reply	other threads:[~2025-10-07 20:48 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251007204806.15560-1-cel@kernel.org \
    --to=cel@kernel.org \
    --cc=calum.mackay@oracle.com \
    --cc=chuck.lever@oracle.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.