From: Roman Kisel <romank@linux.microsoft.com>
To: arnd@arndb.de, bp@alien8.de, bagasdotme@gmail.com,
corbet@lwn.net, dave.hansen@linux.intel.com, decui@microsoft.com,
haiyangz@microsoft.com, hpa@zytor.com, kys@microsoft.com,
mikelley@microsoft.com, mingo@redhat.com, tglx@linutronix.de,
Tianyu.Lan@microsoft.com, wei.liu@kernel.org, x86@kernel.org,
linux-hyperv@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Cc: benhill@microsoft.com, bperkins@microsoft.com, sunilmut@microsoft.com
Subject: [PATCH hyperv-next v7 10/17] Drivers: hv: Check message and event pages for non-NULL before iounmap()
Date: Wed, 8 Oct 2025 16:34:12 -0700 [thread overview]
Message-ID: <20251008233419.20372-11-romank@linux.microsoft.com> (raw)
In-Reply-To: <20251008233419.20372-1-romank@linux.microsoft.com>
It might happen that some hyp SynIC pages aren't allocated.
Check for that and only then call iounmap().
Signed-off-by: Roman Kisel <romank@linux.microsoft.com>
Reviewed-by: Tianyu Lan <tiala@microsoft.com>
Reviewed-by: Michael Kelley <mhklinux@outlook.com>
---
drivers/hv/hv.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c
index 95631c08a71f..8e102bcc0be8 100644
--- a/drivers/hv/hv.c
+++ b/drivers/hv/hv.c
@@ -369,8 +369,10 @@ void hv_synic_disable_regs(unsigned int cpu)
*/
simp.simp_enabled = 0;
if (ms_hyperv.paravisor_present || hv_root_partition()) {
- iounmap(hv_cpu->hyp_synic_message_page);
- hv_cpu->hyp_synic_message_page = NULL;
+ if (hv_cpu->hyp_synic_message_page) {
+ iounmap(hv_cpu->hyp_synic_message_page);
+ hv_cpu->hyp_synic_message_page = NULL;
+ }
} else {
simp.base_simp_gpa = 0;
}
@@ -381,8 +383,10 @@ void hv_synic_disable_regs(unsigned int cpu)
siefp.siefp_enabled = 0;
if (ms_hyperv.paravisor_present || hv_root_partition()) {
- iounmap(hv_cpu->hyp_synic_event_page);
- hv_cpu->hyp_synic_event_page = NULL;
+ if (hv_cpu->hyp_synic_event_page) {
+ iounmap(hv_cpu->hyp_synic_event_page);
+ hv_cpu->hyp_synic_event_page = NULL;
+ }
} else {
siefp.base_siefp_gpa = 0;
}
--
2.43.0
next prev parent reply other threads:[~2025-10-08 23:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-08 23:34 [PATCH hyperv-next v7 00/17] Confidential VMBus Roman Kisel
2025-10-08 23:34 ` [PATCH hyperv-next v7 01/17] Documentation: hyperv: " Roman Kisel
2025-10-08 23:34 ` [PATCH hyperv-next v7 02/17] Drivers: hv: VMBus protocol version 6.0 Roman Kisel
2025-10-08 23:34 ` [PATCH hyperv-next v7 03/17] arch/x86: mshyperv: Discover Confidential VMBus availability Roman Kisel
2025-10-08 23:34 ` [PATCH hyperv-next v7 04/17] arch: hyperv: Get/set SynIC synth.registers via paravisor Roman Kisel
2025-10-08 23:34 ` [PATCH hyperv-next v7 05/17] arch/x86: mshyperv: Trap on access for some synthetic MSRs Roman Kisel
2025-10-08 23:34 ` [PATCH hyperv-next v7 06/17] Drivers: hv: Rename fields for SynIC message and event pages Roman Kisel
2025-10-08 23:34 ` [PATCH hyperv-next v7 07/17] Drivers: hv: Allocate the paravisor SynIC pages when required Roman Kisel
2025-10-08 23:34 ` [PATCH hyperv-next v7 08/17] Drivers: hv: Post messages through the confidential VMBus if available Roman Kisel
2025-10-08 23:34 ` [PATCH hyperv-next v7 09/17] Drivers: hv: remove stale comment Roman Kisel
2025-10-08 23:34 ` Roman Kisel [this message]
2025-10-08 23:34 ` [PATCH hyperv-next v7 11/17] Drivers: hv: Rename the SynIC enable and disable routines Roman Kisel
2025-10-08 23:34 ` [PATCH hyperv-next v7 12/17] Drivers: hv: Functions for setting up and tearing down the paravisor SynIC Roman Kisel
2025-10-08 23:34 ` [PATCH hyperv-next v7 13/17] Drivers: hv: Allocate encrypted buffers when requested Roman Kisel
2025-10-08 23:34 ` [PATCH hyperv-next v7 14/17] Drivers: hv: Free msginfo when the buffer fails to decrypt Roman Kisel
2025-10-08 23:34 ` [PATCH hyperv-next v7 15/17] Drivers: hv: Support confidential VMBus channels Roman Kisel
2025-10-08 23:34 ` [PATCH hyperv-next v7 16/17] Drivers: hv: Set the default VMBus version to 6.0 Roman Kisel
2025-10-08 23:34 ` [PATCH hyperv-next v7 17/17] Drivers: hv: Support establishing the confidential VMBus connection Roman Kisel
2025-10-13 19:01 ` [PATCH hyperv-next v7 00/17] Confidential VMBus Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251008233419.20372-11-romank@linux.microsoft.com \
--to=romank@linux.microsoft.com \
--cc=Tianyu.Lan@microsoft.com \
--cc=arnd@arndb.de \
--cc=bagasdotme@gmail.com \
--cc=benhill@microsoft.com \
--cc=bp@alien8.de \
--cc=bperkins@microsoft.com \
--cc=corbet@lwn.net \
--cc=dave.hansen@linux.intel.com \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=hpa@zytor.com \
--cc=kys@microsoft.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=mingo@redhat.com \
--cc=sunilmut@microsoft.com \
--cc=tglx@linutronix.de \
--cc=wei.liu@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.