Re: [PATCH v1] Fix build break when LTO is enabled

["Richard W.M. Jones" <rjones@redhat.com>]

On Thu, Oct 09, 2025 at 02:32:00PM +0100, Peter Maydell wrote:
> On Thu, 9 Oct 2025 at 14:15, Chenxi Mao <maochenxi@bosc.ac.cn> wrote:
> >
> > QEMU build fails when LTO is enabled:
> > ../configure --target-list=riscv64-softmmu --enable-lto
> > make
...
> Hi; there's already a patch on list for this:
> 
> https://patchew.org/QEMU/20251001124055.2743244-1-rjones@redhat.com/

And it's nothing to do with LTO.  This is caused by an update in curl
which fixed some (already crazy) compiler macros to detect this stuff:

https://github.com/curl/curl/commit/79b4e56b3f30dc1ac28a81128a07d27338e5219e

> Looks like that missed the elf2dmp usage though:

I'll post an update with Chenxi Mao's S-O-B attached, in a minute.

Rich.

> > diff --git a/contrib/elf2dmp/download.c b/contrib/elf2dmp/download.c
> > index 21306b3fd4..fa8da0f9a2 100644
> > --- a/contrib/elf2dmp/download.c
> > +++ b/contrib/elf2dmp/download.c
> > @@ -27,8 +27,8 @@ bool download_url(const char *name, const char *url)
> >      if (curl_easy_setopt(curl, CURLOPT_URL, url) != CURLE_OK
> >              || curl_easy_setopt(curl, CURLOPT_WRITEFUNCTION, NULL) != CURLE_OK
> >              || curl_easy_setopt(curl, CURLOPT_WRITEDATA, file) != CURLE_OK
> > -            || curl_easy_setopt(curl, CURLOPT_FOLLOWLOCATION, 1) != CURLE_OK
> > -            || curl_easy_setopt(curl, CURLOPT_NOPROGRESS, 0) != CURLE_OK
> > +            || curl_easy_setopt(curl, CURLOPT_FOLLOWLOCATION, 1L) != CURLE_OK
> > +            || curl_easy_setopt(curl, CURLOPT_NOPROGRESS, 0L) != CURLE_OK
> >              || curl_easy_perform(curl) != CURLE_OK) {
> >          unlink(name);
> >          fclose(file);
> 
> 
> thanks
> -- PMM

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v