From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Baojun Xu <baojun.xu@ti.com>,
broonie@kernel.org, tiwai@suse.de,
andriy.shevchenko@linux.intel.com, 13916275206@139.com,
shenghao-ding@ti.com, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org, lgirdwood@gmail.com,
krzk+dt@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, k-yi@ti.com, henry.lo@ti.com,
robinchen@ti.com, jesse-ji@ti.com, will-wang@ti.com,
jim.shil@goertek.com, toastcheng@google.com,
chinkaiting@google.com
Subject: Re: [PATCH v6 1/2] ASoC: tas2781: Support more newly-released amplifiers tas5802, tas5815, and tas5828 in the driver
Date: Fri, 10 Oct 2025 13:56:24 -0500 [thread overview]
Message-ID: <20251010185624.GA713043-robh@kernel.org> (raw)
In-Reply-To: <46346003-603a-48a8-8359-eaca77c8cd63@kernel.org>
On Fri, Oct 10, 2025 at 04:33:47AM +0200, Krzysztof Kozlowski wrote:
> On 10/10/2025 04:29, Baojun Xu wrote:
> > TAS5802/TAS5815/TAS5828 has on-chip DSP without current/voltage feedback.
> >
> > Signed-off-by: Baojun Xu <baojun.xu@ti.com>
>
> You clearly do not want to follow what we ask... subject is still wrong,
> but in different way. I do not understand why simple comment from Rob in
> v4 has to be done in three versions.
>
> Your subject is too long, contains redundant data and references driver
> which is for sure wrong. See writing bindings.
>
> Please read again Rob's comment.
You are looking at the wrong patch. Not that the driver patch subject
couldn't use some improvement too.
Rob
prev parent reply other threads:[~2025-10-10 18:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-10 2:29 [PATCH v6 1/2] ASoC: tas2781: Support more newly-released amplifiers tas5802, tas5815, and tas5828 in the driver Baojun Xu
2025-10-10 2:29 ` [PATCH v6 2/2] ASoC: dt-bindings: ti,tas2781: Add support for TAS5802, TAS5815, and TAS5828 Baojun Xu
2025-10-10 18:56 ` Rob Herring (Arm)
2025-10-10 2:33 ` [PATCH v6 1/2] ASoC: tas2781: Support more newly-released amplifiers tas5802, tas5815, and tas5828 in the driver Krzysztof Kozlowski
2025-10-10 18:56 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251010185624.GA713043-robh@kernel.org \
--to=robh@kernel.org \
--cc=13916275206@139.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=baojun.xu@ti.com \
--cc=broonie@kernel.org \
--cc=chinkaiting@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=henry.lo@ti.com \
--cc=jesse-ji@ti.com \
--cc=jim.shil@goertek.com \
--cc=k-yi@ti.com \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=robinchen@ti.com \
--cc=shenghao-ding@ti.com \
--cc=tiwai@suse.de \
--cc=toastcheng@google.com \
--cc=will-wang@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.