From: "Theodore Ts'o" <tytso@mit.edu>
To: Ojaswin Mujoo <ojaswin@linux.ibm.com>
Cc: Zorro Lang <zlang@redhat.com>,
fstests@vger.kernel.org, srivathsa.d.dara@oracle.com,
linux-kernel@vger.kernel.org, Disha Goel <disgoel@linux.ibm.com>
Subject: Re: [PATCH] ext4/060: Skip for dax devices on non-4k page sizes
Date: Sun, 12 Oct 2025 15:57:31 -0400 [thread overview]
Message-ID: <20251012195731.GG354523@mit.edu> (raw)
In-Reply-To: <20251011134708.2426769-1-ojaswin@linux.ibm.com>
On Sat, Oct 11, 2025 at 07:17:08PM +0530, Ojaswin Mujoo wrote:
> This test tries to trigger an ext4 corruption by resizing past the
> meta_bg size (8GB on 4k blocksize) in ext4. Since the test is sensistive
> to the size and FS layout it hardcodes the 4kb blocksize ignoring user's
> $MKFS_OPTIONS. While this is okay for most cases it fails for dax based
> filesystems where system pagesize is non-4k.
>
> One way to work past this is to make the test blocksize agnostic, but
> since we still need the disk to be as big as the meta_bg size, this
> means for blocksize=64kb filesystems we need a scratch disk of ~4TB
> which is not feasible.
>
> Hence, just skip the test if fsdax is used in a non-4k page size system.
>
> Reported-by: Disha Goel <disgoel@linux.ibm.com>
> Signed-off-by: Ojaswin Mujoo <ojaswin@linux.ibm.com>
Makes sense to me.
Reviewed-by: Theodore Ts'o <tytso@mit.edu>
prev parent reply other threads:[~2025-10-12 19:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-11 13:47 [PATCH] ext4/060: Skip for dax devices on non-4k page sizes Ojaswin Mujoo
2025-10-12 19:57 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251012195731.GG354523@mit.edu \
--to=tytso@mit.edu \
--cc=disgoel@linux.ibm.com \
--cc=fstests@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ojaswin@linux.ibm.com \
--cc=srivathsa.d.dara@oracle.com \
--cc=zlang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.