From: "Michael S. Tsirkin" <mst@redhat.com>
To: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Cc: netdev@vger.kernel.org, "Jason Wang" <jasowang@redhat.com>,
"Eugenio Pérez" <eperezma@redhat.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Willem de Bruijn" <willemb@google.com>,
"Jiri Pirko" <jiri@resnulli.us>,
"Alvaro Karsz" <alvaro.karsz@solid-run.com>,
"Heng Qi" <hengqi@linux.alibaba.com>,
virtualization@lists.linux.dev
Subject: Re: [PATCH net v2 0/3] fixes two virtio-net related bugs.
Date: Mon, 13 Oct 2025 03:56:35 -0400 [thread overview]
Message-ID: <20251013035059-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20251013020629.73902-1-xuanzhuo@linux.alibaba.com>
On Mon, Oct 13, 2025 at 10:06:26AM +0800, Xuan Zhuo wrote:
> As discussed in http://lore.kernel.org/all/20250919013450.111424-1-xuanzhuo@linux.alibaba.com
> Commit #1 Move the flags into the existing if condition; the issue is that it introduces a
> small amount of code duplication.
How were commits 1 and 2 tested?
> Commit #3 is new to fix the hdr len in tunnel gso feature.
>
> Hi @Paolo Abenchi,
> Could you please test commit #3? I don't have a suitable test environment, as
> QEMU doesn't currently support the tunnel GSO feature.
>
> Thanks.
AFAIK host_tunnel and guest_tunnel flags enable exactly that.
> Xuan Zhuo (3):
> virtio-net: fix incorrect flags recording in big mode
> virtio-net: correct hdr_len handling for VIRTIO_NET_F_GUEST_HDRLEN
> virtio-net: correct hdr_len handling for tunnel gso
>
> drivers/net/virtio_net.c | 16 ++++++++-----
> include/linux/virtio_net.h | 46 ++++++++++++++++++++++++++++++++------
> 2 files changed, 50 insertions(+), 12 deletions(-)
>
> --
> 2.32.0.3.g01195cf9f
next prev parent reply other threads:[~2025-10-13 7:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-13 2:06 [PATCH net v2 0/3] fixes two virtio-net related bugs Xuan Zhuo
2025-10-13 2:06 ` [PATCH net v2 1/3] virtio-net: fix incorrect flags recording in big mode Xuan Zhuo
2025-10-13 2:06 ` [PATCH net v2 2/3] virtio-net: correct hdr_len handling for VIRTIO_NET_F_GUEST_HDRLEN Xuan Zhuo
2025-10-13 2:06 ` [PATCH net v2 3/3] virtio-net: correct hdr_len handling for tunnel gso Xuan Zhuo
2025-10-13 8:11 ` Paolo Abeni
2025-10-14 2:58 ` Xuan Zhuo
2025-10-13 5:56 ` [PATCH net v2 0/3] fixes two virtio-net related bugs Jason Wang
2025-10-14 2:56 ` Xuan Zhuo
2025-10-13 7:56 ` Michael S. Tsirkin [this message]
2025-10-14 2:55 ` Xuan Zhuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251013035059-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=alvaro.karsz@solid-run.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eperezma@redhat.com \
--cc=hengqi@linux.alibaba.com \
--cc=jasowang@redhat.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=willemb@google.com \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.