All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Florian Fainelli <florian.fainelli@broadcom.com>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Claudiu Beznea <claudiu.beznea@tuxon.dev>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Kevin Hilman <khilman@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	Changhuang Liang <changhuang.liang@starfivetech.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Magnus Damm <magnus.damm@gmail.com>,
	linux-kernel@vger.kernel.org, Johan Hovold <johan@kernel.org>,
	Florian Fainelli <f.fainelli@gmail.com>
Subject: [PATCH 05/11] irqchip/irq-brcmstb-l2: Fix section mismatch
Date: Mon, 13 Oct 2025 11:46:05 +0200	[thread overview]
Message-ID: <20251013094611.11745-6-johan@kernel.org> (raw)
In-Reply-To: <20251013094611.11745-1-johan@kernel.org>

Platform drivers can be probed after their init sections have been
discarded so the irqchip init callbacks must not live in init.

Fixes: 51d9db5c8fbb ("irqchip/irq-brcmstb-l2: Switch to IRQCHIP_PLATFORM_DRIVER")
Cc: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
---
 drivers/irqchip/irq-brcmstb-l2.c | 12 ++++--------
 1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/drivers/irqchip/irq-brcmstb-l2.c b/drivers/irqchip/irq-brcmstb-l2.c
index 1bec5b2cd3f0..53e67c6c01f7 100644
--- a/drivers/irqchip/irq-brcmstb-l2.c
+++ b/drivers/irqchip/irq-brcmstb-l2.c
@@ -138,10 +138,8 @@ static void brcmstb_l2_intc_resume(struct irq_data *d)
 	irq_reg_writel(gc, ~b->saved_mask, ct->regs.enable);
 }
 
-static int __init brcmstb_l2_intc_of_init(struct device_node *np,
-					  struct device_node *parent,
-					  const struct brcmstb_intc_init_params
-					  *init_params)
+static int brcmstb_l2_intc_of_init(struct device_node *np, struct device_node *parent,
+				   const struct brcmstb_intc_init_params *init_params)
 {
 	unsigned int clr = IRQ_NOREQUEST | IRQ_NOPROBE | IRQ_NOAUTOEN;
 	unsigned int set = 0;
@@ -257,14 +255,12 @@ static int __init brcmstb_l2_intc_of_init(struct device_node *np,
 	return ret;
 }
 
-static int __init brcmstb_l2_edge_intc_of_init(struct device_node *np,
-	struct device_node *parent)
+static int brcmstb_l2_edge_intc_of_init(struct device_node *np, struct device_node *parent)
 {
 	return brcmstb_l2_intc_of_init(np, parent, &l2_edge_intc_init);
 }
 
-static int __init brcmstb_l2_lvl_intc_of_init(struct device_node *np,
-	struct device_node *parent)
+static int brcmstb_l2_lvl_intc_of_init(struct device_node *np, struct device_node *parent)
 {
 	return brcmstb_l2_intc_of_init(np, parent, &l2_lvl_intc_init);
 }
-- 
2.49.1


  parent reply	other threads:[~2025-10-13  9:48 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-13  9:46 [PATCH 00/11] irqchip: Pass platform device to platform drivers Johan Hovold
2025-10-13  9:46 ` [PATCH 01/11] irqchip/bcm2712-mip: Fix OF node reference imbalance Johan Hovold
2025-10-13 15:56   ` Florian Fainelli
2025-10-16  9:51   ` [tip: irq/drivers] " tip-bot2 for Johan Hovold
2025-10-13  9:46 ` [PATCH 02/11] irqchip/bcm2712-mip: Fix section mismatch Johan Hovold
2025-10-13 15:56   ` Florian Fainelli
2025-10-16  9:51   ` [tip: irq/drivers] " tip-bot2 for Johan Hovold
2025-10-13  9:46 ` [PATCH 03/11] irqchip/irq-bcm7038-l1: " Johan Hovold
2025-10-13 15:56   ` Florian Fainelli
2025-10-16  9:51   ` [tip: irq/drivers] " tip-bot2 for Johan Hovold
2025-10-13  9:46 ` [PATCH 04/11] irqchip/irq-bcm7120-l2: " Johan Hovold
2025-10-13 15:57   ` Florian Fainelli
2025-10-16  9:51   ` [tip: irq/drivers] " tip-bot2 for Johan Hovold
2025-10-13  9:46 ` Johan Hovold [this message]
2025-10-13 15:57   ` [PATCH 05/11] irqchip/irq-brcmstb-l2: " Florian Fainelli
2025-10-16  9:51   ` [tip: irq/drivers] " tip-bot2 for Johan Hovold
2025-10-13  9:46 ` [PATCH 06/11] irqchip/imx-mu-msi: " Johan Hovold
2025-10-16  9:51   ` [tip: irq/drivers] " tip-bot2 for Johan Hovold
2025-10-13  9:46 ` [PATCH 07/11] irqchip/renesas-rzg2l: " Johan Hovold
2025-10-13 13:19   ` Geert Uytterhoeven
2025-10-13 13:27     ` Johan Hovold
2025-10-16  9:51   ` [tip: irq/drivers] " tip-bot2 for Johan Hovold
2025-10-13  9:46 ` [PATCH 08/11] irqchip/starfive-jh8100: " Johan Hovold
2025-10-14  1:05   ` 回复: " Changhuang Liang
2025-10-16  9:51   ` [tip: irq/drivers] " tip-bot2 for Johan Hovold
2025-10-13  9:46 ` [PATCH 09/11] irqchip/qcom-irq-combiner: " Johan Hovold
2025-10-16  9:51   ` [tip: irq/drivers] " tip-bot2 for Johan Hovold
2025-10-13  9:46 ` [PATCH 10/11] irqchip: Drop leftover brackets Johan Hovold
2025-10-13 13:20   ` Geert Uytterhoeven
2025-10-16  9:51   ` [tip: irq/drivers] " tip-bot2 for Johan Hovold
2025-10-13  9:46 ` [PATCH 11/11] irqchip: Pass platform device to platform drivers Johan Hovold
2025-10-13 17:24   ` Florian Fainelli
2025-10-14  1:11   ` 回复: " Changhuang Liang
2025-10-14  8:52   ` Stanimir Varbanov
2025-10-14  9:04     ` Johan Hovold
2025-10-16  9:51   ` [tip: irq/drivers] " tip-bot2 for Johan Hovold
2025-10-16 15:46   ` tip-bot2 for Johan Hovold
2025-10-16 15:56     ` Johan Hovold
2025-10-16 16:19       ` Thomas Gleixner
2025-10-16 19:01   ` tip-bot2 for Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251013094611.11745-6-johan@kernel.org \
    --to=johan@kernel.org \
    --cc=changhuang.liang@starfivetech.com \
    --cc=claudiu.beznea@tuxon.dev \
    --cc=f.fainelli@gmail.com \
    --cc=festevam@gmail.com \
    --cc=florian.fainelli@broadcom.com \
    --cc=geert+renesas@glider.be \
    --cc=jbrunet@baylibre.com \
    --cc=khilman@baylibre.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=neil.armstrong@linaro.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.