From: Antheas Kapenekakis <lkml@antheas.dev>
To: platform-driver-x86@vger.kernel.org, linux-input@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, "Jiri Kosina" <jikos@kernel.org>,
"Benjamin Tissoires" <bentiss@kernel.org>,
"Corentin Chary" <corentin.chary@gmail.com>,
"Luke D . Jones" <luke@ljones.dev>,
"Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Denis Benato" <benato.denis96@gmail.com>,
"Antheas Kapenekakis" <lkml@antheas.dev>
Subject: [PATCH v6 7/7] HID: asus: add support for the asus-wmi brightness handler
Date: Mon, 13 Oct 2025 22:15:35 +0200 [thread overview]
Message-ID: <20251013201535.6737-8-lkml@antheas.dev> (raw)
In-Reply-To: <20251013201535.6737-1-lkml@antheas.dev>
If the asus-wmi brightness handler is available, send the
keyboard brightness events to it instead of passing them
to userspace. If it is not, fall back to sending them to it.
Reviewed-by: Luke D. Jones <luke@ljones.dev>
Tested-by: Luke D. Jones <luke@ljones.dev>
Signed-off-by: Antheas Kapenekakis <lkml@antheas.dev>
---
drivers/hid/hid-asus.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c
index 0af19c8ef035..1f904bb66396 100644
--- a/drivers/hid/hid-asus.c
+++ b/drivers/hid/hid-asus.c
@@ -324,6 +324,17 @@ static int asus_event(struct hid_device *hdev, struct hid_field *field,
usage->hid & HID_USAGE);
}
+ if (usage->type == EV_KEY && value) {
+ switch (usage->code) {
+ case KEY_KBDILLUMUP:
+ return !asus_hid_event(ASUS_EV_BRTUP);
+ case KEY_KBDILLUMDOWN:
+ return !asus_hid_event(ASUS_EV_BRTDOWN);
+ case KEY_KBDILLUMTOGGLE:
+ return !asus_hid_event(ASUS_EV_BRTTOGGLE);
+ }
+ }
+
return 0;
}
--
2.51.0
next prev parent reply other threads:[~2025-10-13 20:17 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-13 20:15 [PATCH v6 0/7] HID: asus: Fix ASUS ROG Laptop's Keyboard backlight handling Antheas Kapenekakis
2025-10-13 20:15 ` [PATCH v6 1/7] HID: asus: refactor init sequence per spec Antheas Kapenekakis
2025-10-15 10:53 ` Ilpo Järvinen
2025-10-15 11:18 ` Antheas Kapenekakis
2025-10-15 11:30 ` Ilpo Järvinen
2025-10-13 20:15 ` [PATCH v6 2/7] HID: asus: prevent binding to all HID devices on ROG Antheas Kapenekakis
2025-10-15 10:59 ` Ilpo Järvinen
2025-10-13 20:15 ` [PATCH v6 3/7] platform/x86: asus-wmi: Add support for multiple kbd RGB handlers Antheas Kapenekakis
2025-10-15 11:59 ` Ilpo Järvinen
2025-10-15 15:45 ` Antheas Kapenekakis
2025-10-16 10:18 ` Ilpo Järvinen
2025-10-16 10:23 ` Antheas Kapenekakis
2025-10-16 10:38 ` Ilpo Järvinen
2025-10-13 20:15 ` [PATCH v6 4/7] HID: asus: listen to the asus-wmi brightness device instead of creating one Antheas Kapenekakis
2025-10-13 21:44 ` Denis Benato
2025-10-13 21:57 ` Antheas Kapenekakis
2025-10-13 22:06 ` Denis Benato
2025-10-13 22:18 ` Antheas Kapenekakis
2025-10-13 22:50 ` Denis Benato
2025-10-13 20:15 ` [PATCH v6 5/7] platform/x86: asus-wmi: remove unused keyboard backlight quirk Antheas Kapenekakis
2025-10-13 20:15 ` [PATCH v6 6/7] platform/x86: asus-wmi: add keyboard brightness event handler Antheas Kapenekakis
2025-10-15 12:18 ` Ilpo Järvinen
2025-10-15 15:38 ` Antheas Kapenekakis
2025-10-13 20:15 ` Antheas Kapenekakis [this message]
2025-10-13 21:37 ` [PATCH v6 7/7] HID: asus: add support for the asus-wmi brightness handler Denis Benato
2025-10-13 21:36 ` [PATCH v6 0/7] HID: asus: Fix ASUS ROG Laptop's Keyboard backlight handling Denis Benato
2025-10-13 21:45 ` Antheas Kapenekakis
2025-10-16 11:57 ` Denis Benato
2025-10-16 12:14 ` Antheas Kapenekakis
2025-10-16 12:19 ` Denis Benato
2025-10-16 12:28 ` Antheas Kapenekakis
2025-10-16 12:46 ` Denis Benato
2025-10-16 12:51 ` Antheas Kapenekakis
2025-10-16 14:32 ` Denis Benato
2025-10-16 14:44 ` Antheas Kapenekakis
2025-10-16 14:44 ` Antheas Kapenekakis
2025-10-16 15:16 ` Denis Benato
2025-10-16 15:08 ` Ilpo Järvinen
2025-10-16 16:16 ` Antheas Kapenekakis
2025-10-17 7:54 ` Antheas Kapenekakis
2025-10-17 11:00 ` Denis Benato
2025-10-17 11:21 ` Antheas Kapenekakis
2025-10-20 17:13 ` Ilpo Järvinen
2025-10-20 18:54 ` Antheas Kapenekakis
2025-10-17 10:36 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251013201535.6737-8-lkml@antheas.dev \
--to=lkml@antheas.dev \
--cc=benato.denis96@gmail.com \
--cc=bentiss@kernel.org \
--cc=corentin.chary@gmail.com \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luke@ljones.dev \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.