From: Bjorn Helgaas <helgaas@kernel.org>
To: Eric Biggers <ebiggers@kernel.org>
Cc: "Mario Limonciello (AMD)" <superm1@kernel.org>,
"David Airlie" <airlied@gmail.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
"open list" <linux-kernel@vger.kernel.org>,
"open list:PCI SUBSYSTEM" <linux-pci@vger.kernel.org>,
"Daniel Dadap" <ddadap@nvidia.com>,
regressions@lists.linux.dev
Subject: Re: [PATCH v10 2/4] PCI/VGA: Replace vga_is_firmware_default() with a screen info check
Date: Mon, 13 Oct 2025 15:55:31 -0500 [thread overview]
Message-ID: <20251013205531.GA863704@bhelgaas> (raw)
In-Reply-To: <20251012182302.GA3412@sol>
[+cc regressions]
On Sun, Oct 12, 2025 at 11:23:02AM -0700, Eric Biggers wrote:
> On Mon, Aug 11, 2025 at 11:26:04AM -0500, Mario Limonciello (AMD) wrote:
> > vga_is_firmware_default() checks firmware resources to find the owner
> > framebuffer resources to find the firmware PCI device. This is an
> > open coded implementation of screen_info_pci_dev(). Switch to using
> > screen_info_pci_dev() instead.
> >
> > Acked-by: Bjorn Helgaas <bhelgaas@google.com>
> > Suggested-by: Thomas Zimmermann <tzimmermann@suse.de>
> > Signed-off-by: Mario Limonciello (AMD) <superm1@kernel.org>
>
> I'm getting a black screen on boot on mainline, and it bisected to this
> commit. Reverting this commit fixed it.
#regzbot introduced: 337bf13aa9dd ("PCI/VGA: Replace vga_is_firmware_default() with a screen info check")
#regzbot link: https://lore.kernel.org/r/20251013154441.1000875-1-superm1@kernel.org
next prev parent reply other threads:[~2025-10-13 20:55 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-11 16:26 [PATCH v10 0/4] Adjust fbcon console device detection Mario Limonciello (AMD)
2025-08-11 16:26 ` [PATCH v10 1/4] Fix access to video_is_primary_device() when compiled without CONFIG_VIDEO Mario Limonciello (AMD)
2025-08-11 16:26 ` [PATCH v10 2/4] PCI/VGA: Replace vga_is_firmware_default() with a screen info check Mario Limonciello (AMD)
2025-09-10 14:33 ` Thomas Zimmermann
2025-10-12 18:23 ` Eric Biggers
2025-10-12 18:37 ` Mario Limonciello
2025-10-12 18:47 ` Eric Biggers
2025-10-12 19:06 ` Mario Limonciello
2025-10-13 7:04 ` Thomas Zimmermann
2025-10-13 20:55 ` Bjorn Helgaas [this message]
2025-10-28 22:50 ` Bjorn Helgaas
2025-08-11 16:26 ` [PATCH v10 3/4] fbcon: Use screen info to find primary device Mario Limonciello (AMD)
2025-09-04 20:42 ` Bjorn Helgaas
2025-10-28 10:16 ` Aaron Erhardt
2025-10-28 13:15 ` Mario Limonciello
2025-10-28 16:50 ` Thomas Zimmermann
2025-10-28 21:25 ` Mario Limonciello
2025-08-11 16:26 ` [PATCH v10 4/4] DRM: Add a new 'boot_display' attribute Mario Limonciello (AMD)
2025-09-10 14:28 ` Thomas Zimmermann
2025-09-03 4:42 ` [PATCH v10 0/4] Adjust fbcon console device detection Mario Limonciello
2025-09-04 22:36 ` Mario Limonciello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251013205531.GA863704@bhelgaas \
--to=helgaas@kernel.org \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=bhelgaas@google.com \
--cc=christian.koenig@amd.com \
--cc=ddadap@nvidia.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=ebiggers@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=regressions@lists.linux.dev \
--cc=simona@ffwll.ch \
--cc=superm1@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.