All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it, automated-testing@lists.yoctoproject.org
Subject: Re: [LTP] [RFC PATCH 1/1] fs: Remove acl/tacl_xattr.sh
Date: Tue, 14 Oct 2025 17:24:46 +0200	[thread overview]
Message-ID: <20251014152446.GA181869@pevik> (raw)
In-Reply-To: <aOY8SAGEklIur9eW@yuki.lan>

> Hi!
> > Old script which is not using LTP API, not in any runtest file.

> > It tests acl (getfacl, setfacl) and attr (getfattr, setfattr) tools, but
> > both project have their own tests [1] [2]. LTP concentrates on kernel
> > part of testing nowadays, therefore remove it.  Script is very simple
> > that it does not have any benefit for upstream.

> > [1] https://cgit.git.savannah.gnu.org/cgit/acl.git/tree/test
> > [2] https://cgit.git.savannah.gnu.org/cgit/attr.git/tree/test

> While I agree that this is testing an userspace tools we do not have
> much acl coverate in LTP, there seems to be some network nfsv4 tests but
> that seems to be all. I guess that we should at least create an github
> issue that we should write a few tests for that. I guess that writing a
> simple test that sets up right extended attributes and expecte a file to
> be accessible or not shouldn't be that hard.

Add test for filesystem extended attributes
https://github.com/linux-test-project/ltp/issues/1265

Please have a look to the ticket and improve it if needed.

I'm ok to keep this until we have a proper ACL test.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

      reply	other threads:[~2025-10-14 15:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-07 16:05 [LTP] [RFC PATCH 1/1] fs: Remove acl/tacl_xattr.sh Petr Vorel
2025-10-08  9:29 ` Andrea Cervesato via ltp
2025-10-08 10:26 ` Cyril Hrubis
2025-10-14 15:24   ` Petr Vorel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251014152446.GA181869@pevik \
    --to=pvorel@suse.cz \
    --cc=automated-testing@lists.yoctoproject.org \
    --cc=chrubis@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.