All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Stone <daniels@collabora.com>
To: dri-devel@lists.freedesktop.org
Cc: andy.yan@rock-chips.com, hjc@rock-chips.com, heiko@sntech.de,
	cristian.ciocaltea@collabora.com, kernel@collabora.com
Subject: [PATCH 01/13] drm/rockchip: Demote normal drm_err to debug
Date: Wed, 15 Oct 2025 12:00:30 +0100	[thread overview]
Message-ID: <20251015110042.41273-2-daniels@collabora.com> (raw)
In-Reply-To: <20251015110042.41273-1-daniels@collabora.com>

A plane check failing is a normal and expected condition, as userspace
isn't aware of the specific constraints and will try any and every
combination until one succeeds. Push this down to a debug message, so
users can see it if they want to, but make sure we don't spam the log
during normal operation.

Fixes: 604be85547ce4 ("drm/rockchip: Add VOP2 driver")
Signed-off-by: Daniel Stone <daniels@collabora.com>
---
 drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
index 4556cf7a3364..4ba5444fde4f 100644
--- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
+++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
@@ -1032,20 +1032,20 @@ static int vop2_plane_atomic_check(struct drm_plane *plane,
 
 	if (drm_rect_width(src) >> 16 < 4 || drm_rect_height(src) >> 16 < 4 ||
 	    drm_rect_width(dest) < 4 || drm_rect_width(dest) < 4) {
-		drm_err(vop2->drm, "Invalid size: %dx%d->%dx%d, min size is 4x4\n",
-			drm_rect_width(src) >> 16, drm_rect_height(src) >> 16,
-			drm_rect_width(dest), drm_rect_height(dest));
+		drm_dbg_kms(vop2->drm, "Invalid size: %dx%d->%dx%d, min size is 4x4\n",
+			    drm_rect_width(src) >> 16, drm_rect_height(src) >> 16,
+			    drm_rect_width(dest), drm_rect_height(dest));
 		pstate->visible = false;
 		return 0;
 	}
 
 	if (drm_rect_width(src) >> 16 > vop2_data->max_input.width ||
 	    drm_rect_height(src) >> 16 > vop2_data->max_input.height) {
-		drm_err(vop2->drm, "Invalid source: %dx%d. max input: %dx%d\n",
-			drm_rect_width(src) >> 16,
-			drm_rect_height(src) >> 16,
-			vop2_data->max_input.width,
-			vop2_data->max_input.height);
+		drm_dbg_kms(vop2->drm, "Invalid source: %dx%d. max input: %dx%d\n",
+			    drm_rect_width(src) >> 16,
+			    drm_rect_height(src) >> 16,
+			    vop2_data->max_input.width,
+			    vop2_data->max_input.height);
 		return -EINVAL;
 	}
 
@@ -1054,7 +1054,7 @@ static int vop2_plane_atomic_check(struct drm_plane *plane,
 	 * need align with 2 pixel.
 	 */
 	if (fb->format->is_yuv && ((pstate->src.x1 >> 16) % 2)) {
-		drm_err(vop2->drm, "Invalid Source: Yuv format not support odd xpos\n");
+		drm_dbg_kms(vop2->drm, "Invalid Source: Yuv format not support odd xpos\n");
 		return -EINVAL;
 	}
 
-- 
2.51.0


  reply	other threads:[~2025-10-15 11:00 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-15 11:00 [PATCH 00/13] drm/rockchip: No more post-atomic_check fixups Daniel Stone
2025-10-15 11:00 ` Daniel Stone [this message]
2025-10-15 11:00 ` [PATCH 02/13] drm/rockchip: Declare framebuffer width/height bounds Daniel Stone
2025-10-15 11:00 ` [PATCH 03/13] drm/rockchip: Return error code for errors Daniel Stone
2025-10-15 11:00 ` [PATCH 04/13] drm/rockchip: Rename variables for clarity Daniel Stone
2025-10-15 11:00 ` [PATCH 05/13] drm/rockchip: Use temporary variables Daniel Stone
2025-10-15 11:00 ` [PATCH 06/13] drm/rockchip: Switch impossible format conditional to WARN_ON Daniel Stone
2025-10-20 13:10   ` Heiko Stuebner
2025-10-20 13:25     ` Heiko Stuebner
2025-10-20 13:47       ` Daniel Stone
2025-10-20 14:00         ` Heiko Stuebner
2025-10-15 11:00 ` [PATCH 07/13] drm/rockchip: Switch impossible pos " Daniel Stone
2025-10-15 11:00 ` [PATCH 08/13] drm/rockchip: Fix eSmart test condition Daniel Stone
2025-11-12  8:16   ` Andy Yan
2025-10-15 11:00 ` [PATCH 09/13] drm/rockchip: Enforce scaling workaround in plane_check Daniel Stone
2025-11-12  8:13   ` Andy Yan
2025-10-15 11:00 ` [PATCH 10/13] drm/rockchip: Enforce AFBC source alignment " Daniel Stone
2025-11-12  8:21   ` Andy Yan
2025-11-12  8:34     ` Andy Yan
2025-11-12  9:42       ` Andy Yan
2025-10-15 11:00 ` [PATCH 11/13] drm/rockchip: Enforce AFBC transform stride align " Daniel Stone
2025-10-15 11:00 ` [PATCH 12/13] drm/rockchip: Use drm_is_afbc helper function Daniel Stone
2025-10-15 11:00 ` [PATCH 13/13] drm/rockchip: Simplify format_mod_supported Daniel Stone
2025-10-20 14:00 ` (subset) [PATCH 00/13] drm/rockchip: No more post-atomic_check fixups Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251015110042.41273-2-daniels@collabora.com \
    --to=daniels@collabora.com \
    --cc=andy.yan@rock-chips.com \
    --cc=cristian.ciocaltea@collabora.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=heiko@sntech.de \
    --cc=hjc@rock-chips.com \
    --cc=kernel@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.