From: Jakub Kicinski <kuba@kernel.org>
To: Pavel Zhigulin <Pavel.Zhigulin@kaspersky.com>
Cc: Paolo Abeni <pabeni@redhat.com>,
Zhu Yanjun <yanjun.zhu@linux.dev>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Leon Romanovsky <leon@kernel.org>,
Steffen Klassert <steffen.klassert@secunet.com>,
Cosmin Ratiu <cratiu@nvidia.com>,
Ayush Sawal <ayush.sawal@chelsio.com>,
Harsh Jain <harsh@chelsio.com>,
Atul Gupta <atul.gupta@chelsio.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Ganesh Goudar <ganeshgr@chelsio.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <lvc-project@linuxtesting.org>
Subject: Re: [PATCH net v3] net: cxgb4/ch_ipsec: fix potential use-after-free in ch_ipsec_xfrm_add_state() callback
Date: Wed, 15 Oct 2025 17:26:49 -0700 [thread overview]
Message-ID: <20251015172649.279cf382@kernel.org> (raw)
In-Reply-To: <20251013095809.2414748-1-Pavel.Zhigulin@kaspersky.com>
On Mon, 13 Oct 2025 12:58:08 +0300 Pavel Zhigulin wrote:
> + if (unlikely(!try_module_get(THIS_MODULE))) {
> + NL_SET_ERR_MSG_MOD(extack, "Failed to acquire module reference");
> + return -ENODEV;
> + }
> +
> sa_entry = kzalloc(sizeof(*sa_entry), GFP_KERNEL);
> if (!sa_entry) {
> res = -ENOMEM;
I think now you're missing a module put if something fails later.
--
pw-bot: cr
prev parent reply other threads:[~2025-10-16 0:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-13 9:58 [PATCH net v3] net: cxgb4/ch_ipsec: fix potential use-after-free in ch_ipsec_xfrm_add_state() callback Pavel Zhigulin
2025-10-15 18:07 ` Jacob Keller
2025-10-16 0:26 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251015172649.279cf382@kernel.org \
--to=kuba@kernel.org \
--cc=Pavel.Zhigulin@kaspersky.com \
--cc=andrew+netdev@lunn.ch \
--cc=atul.gupta@chelsio.com \
--cc=ayush.sawal@chelsio.com \
--cc=cratiu@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ganeshgr@chelsio.com \
--cc=harsh@chelsio.com \
--cc=herbert@gondor.apana.org.au \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=steffen.klassert@secunet.com \
--cc=yanjun.zhu@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.