From: Bjorn Helgaas <helgaas@kernel.org>
To: Danilo Krummrich <dakr@kernel.org>
Cc: bhelgaas@google.com, kwilczynski@kernel.org, ojeda@kernel.org,
alex.gaynor@gmail.com, boqun.feng@gmail.com, gary@garyguo.net,
bjorn3_gh@protonmail.com, lossin@kernel.org,
a.hindborg@kernel.org, aliceryhl@google.com, tmgross@umich.edu,
rust-for-linux@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] rust: pci: move IRQ infrastructure to separate file
Date: Wed, 15 Oct 2025 18:02:09 -0500 [thread overview]
Message-ID: <20251015230209.GA960343@bhelgaas> (raw)
In-Reply-To: <20251015182118.106604-4-dakr@kernel.org>
On Wed, Oct 15, 2025 at 08:14:31PM +0200, Danilo Krummrich wrote:
> Move the PCI interrupt infrastructure to a separate sub-module in order
> to keep things organized.
> +++ b/rust/kernel/pci/irq.rs
> +pub enum IrqType {
> + /// INTx interrupts.
> + Intx,
> + /// Message Signaled Interrupts (MSI).
> + Msi,
> + /// Extended Message Signaled Interrupts (MSI-X).
> + MsiX,
> +}
> +impl IrqTypes {
> + /// Create a set containing all IRQ types (MSI-X, MSI, and Legacy).
> ...
> + /// // Create a set with only MSI and MSI-X (no legacy interrupts).
> ...
> + /// The allocation will use MSI-X, MSI, or legacy interrupts based on the `irq_types`
> + /// parameter and hardware capabilities. When multiple types are specified, the kernel
> + /// will try them in order of preference: MSI-X first, then MSI, then legacy interrupts.
> ...
> + /// // Allocate MSI or MSI-X only (no legacy interrupts).
Again, just a move, but could s/Legacy/INTx/ to make them all match.
next prev parent reply other threads:[~2025-10-15 23:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-15 18:14 [PATCH 0/3] Rust PCI housekeeping Danilo Krummrich
2025-10-15 18:14 ` [PATCH 1/3] rust: pci: implement TryInto<IrqRequest<'a>> for IrqVector<'a> Danilo Krummrich
2025-10-16 15:01 ` Alice Ryhl
2025-10-16 17:04 ` Danilo Krummrich
2025-10-16 22:24 ` Joel Fernandes
2025-10-16 22:57 ` Danilo Krummrich
2025-10-16 23:02 ` Joel Fernandes
2025-10-15 18:14 ` [PATCH 2/3] rust: pci: move I/O infrastructure to separate file Danilo Krummrich
2025-10-15 22:58 ` Bjorn Helgaas
2025-10-16 12:34 ` Danilo Krummrich
2025-10-16 15:52 ` Bjorn Helgaas
2025-10-16 18:54 ` Miguel Ojeda
2025-10-15 18:14 ` [PATCH 3/3] rust: pci: move IRQ " Danilo Krummrich
2025-10-15 23:02 ` Bjorn Helgaas [this message]
2025-10-20 11:39 ` [PATCH 0/3] Rust PCI housekeeping Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251015230209.GA960343@bhelgaas \
--to=helgaas@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bhelgaas@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.