From: Petr Vorel <pvorel@suse.cz>
To: Wei Gao <wegao@suse.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v2] mremap07.c: New case check mremap with MREMAP_DONTUNMAP
Date: Thu, 16 Oct 2025 15:32:03 +0200 [thread overview]
Message-ID: <20251016133203.GA284465@pevik> (raw)
In-Reply-To: <20251015031540.2120-1-wegao@suse.com>
Hi Wei,
...
> +static void run(void)
> +{
> + pthread_t handler_thread;
> +
> + SAFE_PTHREAD_CREATE(&handler_thread, NULL,
> + (void * (*)(void *))fault_handler_thread, NULL);
> +
> +#if HAVE_DECL_MREMAP_DONTUNMAP
This is a compile check, whole test should be wrapped with #ifdef and fallback
using TST_TEST_TCONF() macro.
#include "config.h"
#include "tst_test.h"
...
#ifdef HAVE_DECL_MREMAP_DONTUNMAP
// other includes
#else
TST_TEST_TCONF("Missing MREMAP_DONTUNMAP in <linux/mman.h>");
#endif
This quits tests early.
And please use #ifdef.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2025-10-16 13:32 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-27 23:02 [LTP] [PATCH v1] mremap07.c: New case check mremap with MREMAP_DONTUNMAP Wei Gao via ltp
2025-10-15 3:15 ` [LTP] [PATCH v2] " Wei Gao via ltp
2025-10-16 13:32 ` Petr Vorel [this message]
2025-10-17 7:51 ` Wei Gao via ltp
2025-10-30 19:39 ` Petr Vorel
2025-11-01 8:47 ` Wei Gao via ltp
2025-10-30 5:40 ` [LTP] [PATCH v3] " Wei Gao via ltp
2025-10-30 20:07 ` Petr Vorel
2026-02-25 9:05 ` [LTP] [PATCH v4] " Wei Gao via ltp
2026-03-23 7:03 ` Andrea Cervesato via ltp
2026-03-25 1:15 ` [LTP] [PATCH v5] " Wei Gao via ltp
2026-03-26 10:01 ` Andrea Cervesato via ltp
2026-04-10 2:31 ` [LTP] [PATCH v6] " Wei Gao via ltp
2026-04-17 6:53 ` [LTP] [PATCH v7] mremap07.c: New test for mremap() " Wei Gao via ltp
2026-04-17 7:55 ` [LTP] " linuxtestproject.agent
2026-04-17 8:00 ` Andrea Cervesato via ltp
2026-04-17 12:27 ` [LTP] [PATCH v8] " Wei Gao via ltp
2026-04-17 13:26 ` [LTP] " linuxtestproject.agent
2026-04-19 1:22 ` Wei Gao via ltp
2026-04-20 10:12 ` [LTP] [PATCH v8] " Li Wang
2026-04-21 8:20 ` Wei Gao via ltp
2026-04-21 9:11 ` Li Wang
2026-04-22 2:30 ` [LTP] [PATCH v9] " Wei Gao via ltp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251016133203.GA284465@pevik \
--to=pvorel@suse.cz \
--cc=ltp@lists.linux.it \
--cc=wegao@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.