From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2E851A00F0; Sun, 19 Oct 2025 16:25:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760891120; cv=none; b=XHqLF6dvRtksg/rpYaCpQd0wvqWfyKJgzRoZOqo5spJ4Cn/TkCZgTu6JzpGpBu0J1SKlNei0ueCrHDOMqGwoUKzWBCBz3S9ZE0auTv0slrLqXDj6EYOZyyn3TRcK+xmuf68aD9XzkJ/k2fOaQu7wV9hIHvFwVkoglY1/dUjCpeE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760891120; c=relaxed/simple; bh=AqeDRU1eKSmQXUiCZ7pwi0Bd8BGGXBM48O4Ou5Xs+sw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ny8OD4gi8nAij93+qSPZ92ytYCmvNp2te+9feN52PBmDlCrgJ1LDdj5X2hGC62awAnItnCA0/a6WPJfjeS0Obn/cuF4G9jS+9seTkI2xHvvDm9V2UN3sxVdmY/T5nBWmWwbDG3Y/jYnCrBraz4hwbcw1tiUMrGiFXEDLdfNHHNQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=F2EokHRL; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="F2EokHRL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D7610C4CEE7; Sun, 19 Oct 2025 16:25:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1760891119; bh=AqeDRU1eKSmQXUiCZ7pwi0Bd8BGGXBM48O4Ou5Xs+sw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=F2EokHRLd68kZBeDRRdhxJ1rDW2elFlh8EnkyaTJnHSCfqkoujh7BohpZc68H407D 6bUXmBrNoq7Ww0jTMF1QQwGeMEpfXz0BrGd0k+T8PJbgWDRrKfDcnhwumf2RRZV3Tp M1nqa0cZRI89OYqyvuvRWeFwctcqJgDf9nK43gHk2G3mRl3usq7ey6ziFEp5oxVwef 8ha/lyEniLuE2fegL9ApZJO+lst38G6OUrwAE6O/NFZ/Mz1YaBFZd+ociss1pkQv9d 0MzWPAoBwoLUZ5+ACw5ohULeXVrjB6+3sdA7UiNPKC79wDn4zGf7+6LA7UKkZ5vUk5 GbYsQCDUj5ADg== Date: Sun, 19 Oct 2025 09:23:46 -0700 From: Eric Biggers To: Askar Safin Cc: ardb@kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, sparclinux@vger.kernel.org, x86@kernel.org, Greg Kroah-Hartman , stable@vger.kernel.org Subject: Re: [PATCH v4 15/19] lib/crc32: make crc32c() go directly to lib Message-ID: <20251019162346.GB1604@sol> References: <20241202010844.144356-16-ebiggers@kernel.org> <20251019060845.553414-1-safinaskar@gmail.com> Precedence: bulk X-Mailing-List: linux-arch@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Sun, Oct 19, 2025 at 11:10:25AM +0300, Askar Safin wrote: > On Sun, Oct 19, 2025 at 9:09 AM Askar Safin wrote: > > > > Eric Biggers : > > > Now that the lower level __crc32c_le() library function is optimized for > > > > This patch (i. e. 38a9a5121c3b ("lib/crc32: make crc32c() go directly to lib")) > > solves actual bug I found in practice. So, please, backport it > > to stable kernels. > > Oops. I just noticed that this patch removes module "libcrc32c". > And this breaks build for Debian kernel v6.12.48. > Previously I tested minimal build using "make localmodconfig". > Now I tried full build of Debian kernel using "dpkg-buildpackage". > And it failed, because some of Debian files reference "libcrc32c", > which is not available. > > So, please, don't backport this patch to stable kernels. > I'm sorry. Right, this commit simplified the CRC library design by removing the libcrc32c module. initramfs build scripts that hard-coded the addition of libcrc32c.ko into the ramdisk (which I don't think was ever necessary in the first place, though it did used to be useful to hard-code some of the *other* CRC modules like crc32c-intel) had to be updated to remove it. It looks like Debian did indeed do that, and they updated it in https://salsa.debian.org/kernel-team/linux/-/commit/6c242c647f84bfdbdc22a6a758fa59da4e941a10#1251f9400a85485d275e1709758350aa098709a8 As for your original problem, I'd glad to see that the simplified design is preventing problems. There's an issue with backporting this commit alone, though. This was patch 15 of a 19-patch series for a good reason: the CRC-32C implementation in lib/ wasn't architecture-optimized until after patches 1-14 of this series. Backporting this commit alone would make crc32c() no longer utilize architecture-optimized code. Now, it already didn't do so reliably (and this patch series fixed that). However, backporting this commit alone would make it never do so. So it would regress performance in some cases. Since the errors you're actually getting are: [ 19.619731] Invalid ELF header magic: != ELF modprobe: can't load module libcrc32c (kernel/lib/libcrc32c.ko.xz): unknown symbol in module, or unknown parameter I do have to wonder if this is actually a busybox bug or misconfiguration, where it's passing a compressed module to the kernel without decompressing it? And removing the module just hid the problem. - Eric From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1191FCCD1A5 for ; Sun, 19 Oct 2025 16:26:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: Reply-To:From:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Subject:In-Reply-To:MIME-Version:References: Message-ID:To:Date:Sender:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FVOguDYUUTT+7B4+BqDwmKmErffXTD+xhb6jjYjc+d8=; b=QzFMDVC7eHhjnpuZd/0r3qnRQo O+16i8TnQHCTKl+5RSL8NPEZ4lGuHbYNFRqhDjDLgbWmgcTtmMZrM5Cs7mdwpRev4iCbMh+C7ZPgt gypYQXyOe3du5WAQgNo+UyalETECaCelWXEodwlxOoRhkxcM9vFTF83wxRWN1hUpdC8E=; Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1vAWEX-0000jl-3H; Sun, 19 Oct 2025 16:26:13 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1vAWDp-0000gU-PB for linux-f2fs-devel@lists.sourceforge.net; Sun, 19 Oct 2025 16:25:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Transfer-Encoding:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Karn116GYjTx2H81CntcrkAvTygSq7TejQKGOkTyXIM=; b=M+05Ti9w1eogdSfCoZBES1/9MG vbsdU7tlTBjuKbfHoqpZ7hXog6WBiYUbal9ynhRiFneCZhcL5JzgsOIpcMedSKd5rdWLK1pyn4I5b PY//A6DWWtSJcqO8oEsg1KGb1zoxXfaNv16DEP+hpSgDUO3/Iqllr8QOxbNsf9SDWI0c=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Karn116GYjTx2H81CntcrkAvTygSq7TejQKGOkTyXIM=; b=fmL5BFd39/7ZGRxbUDWsy9Mcyr Mn6/nM4MZ8qKK0/4LBtE0f2opnnFz/JJRj1cmCCVnnSKesBoGQeHsj4lRG+i6rXh3NVgGxYt8pTW0 +KVbmkUaL9QmCc/HliJcc+LR11f2C2Ds6zCg2opOnSYMmm8smDoR7tYsn53lU51yjP1I=; Received: from sea.source.kernel.org ([172.234.252.31]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1vAWDq-00045a-0v for linux-f2fs-devel@lists.sourceforge.net; Sun, 19 Oct 2025 16:25:30 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 8C9C944476; Sun, 19 Oct 2025 16:25:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D7610C4CEE7; Sun, 19 Oct 2025 16:25:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1760891119; bh=AqeDRU1eKSmQXUiCZ7pwi0Bd8BGGXBM48O4Ou5Xs+sw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=F2EokHRLd68kZBeDRRdhxJ1rDW2elFlh8EnkyaTJnHSCfqkoujh7BohpZc68H407D 6bUXmBrNoq7Ww0jTMF1QQwGeMEpfXz0BrGd0k+T8PJbgWDRrKfDcnhwumf2RRZV3Tp M1nqa0cZRI89OYqyvuvRWeFwctcqJgDf9nK43gHk2G3mRl3usq7ey6ziFEp5oxVwef 8ha/lyEniLuE2fegL9ApZJO+lst38G6OUrwAE6O/NFZ/Mz1YaBFZd+ociss1pkQv9d 0MzWPAoBwoLUZ5+ACw5ohULeXVrjB6+3sdA7UiNPKC79wDn4zGf7+6LA7UKkZ5vUk5 GbYsQCDUj5ADg== Date: Sun, 19 Oct 2025 09:23:46 -0700 To: Askar Safin Message-ID: <20251019162346.GB1604@sol> References: <20241202010844.144356-16-ebiggers@kernel.org> <20251019060845.553414-1-safinaskar@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Headers-End: 1vAWDq-00045a-0v Subject: Re: [f2fs-dev] [PATCH v4 15/19] lib/crc32: make crc32c() go directly to lib X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Eric Biggers via Linux-f2fs-devel Reply-To: Eric Biggers Cc: linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-mips@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-crypto@vger.kernel.org, loongarch@lists.linux.dev, Greg Kroah-Hartman , sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, linux-ext4@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, ardb@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net T24gU3VuLCBPY3QgMTksIDIwMjUgYXQgMTE6MTA6MjVBTSArMDMwMCwgQXNrYXIgU2FmaW4gd3Jv dGU6Cj4gT24gU3VuLCBPY3QgMTksIDIwMjUgYXQgOTowOeKAr0FNIEFza2FyIFNhZmluIDxzYWZp bmFza2FyQGdtYWlsLmNvbT4gd3JvdGU6Cj4gPgo+ID4gRXJpYyBCaWdnZXJzIDxlYmlnZ2Vyc0Br ZXJuZWwub3JnPjoKPiA+ID4gTm93IHRoYXQgdGhlIGxvd2VyIGxldmVsIF9fY3JjMzJjX2xlKCkg bGlicmFyeSBmdW5jdGlvbiBpcyBvcHRpbWl6ZWQgZm9yCj4gPgo+ID4gVGhpcyBwYXRjaCAoaS4g ZS4gMzhhOWE1MTIxYzNiICgibGliL2NyYzMyOiBtYWtlIGNyYzMyYygpIGdvIGRpcmVjdGx5IHRv IGxpYiIpKQo+ID4gc29sdmVzIGFjdHVhbCBidWcgSSBmb3VuZCBpbiBwcmFjdGljZS4gU28sIHBs ZWFzZSwgYmFja3BvcnQgaXQKPiA+IHRvIHN0YWJsZSBrZXJuZWxzLgo+IAo+IE9vcHMuIEkganVz dCBub3RpY2VkIHRoYXQgdGhpcyBwYXRjaCByZW1vdmVzIG1vZHVsZSAibGliY3JjMzJjIi4KPiBB bmQgdGhpcyBicmVha3MgYnVpbGQgZm9yIERlYmlhbiBrZXJuZWwgdjYuMTIuNDguCj4gUHJldmlv dXNseSBJIHRlc3RlZCBtaW5pbWFsIGJ1aWxkIHVzaW5nICJtYWtlIGxvY2FsbW9kY29uZmlnIi4K PiBOb3cgSSB0cmllZCBmdWxsIGJ1aWxkIG9mIERlYmlhbiBrZXJuZWwgdXNpbmcgImRwa2ctYnVp bGRwYWNrYWdlIi4KPiBBbmQgaXQgZmFpbGVkLCBiZWNhdXNlIHNvbWUgb2YgRGViaWFuIGZpbGVz IHJlZmVyZW5jZSAibGliY3JjMzJjIiwKPiB3aGljaCBpcyBub3QgYXZhaWxhYmxlLgo+IAo+IFNv LCBwbGVhc2UsIGRvbid0IGJhY2twb3J0IHRoaXMgcGF0Y2ggdG8gc3RhYmxlIGtlcm5lbHMuCj4g SSdtIHNvcnJ5LgoKUmlnaHQsIHRoaXMgY29tbWl0IHNpbXBsaWZpZWQgdGhlIENSQyBsaWJyYXJ5 IGRlc2lnbiBieSByZW1vdmluZyB0aGUKbGliY3JjMzJjIG1vZHVsZS4gIGluaXRyYW1mcyBidWls ZCBzY3JpcHRzIHRoYXQgaGFyZC1jb2RlZCB0aGUgYWRkaXRpb24Kb2YgbGliY3JjMzJjLmtvIGlu dG8gdGhlIHJhbWRpc2sgKHdoaWNoIEkgZG9uJ3QgdGhpbmsgd2FzIGV2ZXIgbmVjZXNzYXJ5Cmlu IHRoZSBmaXJzdCBwbGFjZSwgdGhvdWdoIGl0IGRpZCB1c2VkIHRvIGJlIHVzZWZ1bCB0byBoYXJk LWNvZGUgc29tZSBvZgp0aGUgKm90aGVyKiBDUkMgbW9kdWxlcyBsaWtlIGNyYzMyYy1pbnRlbCkg aGFkIHRvIGJlIHVwZGF0ZWQgdG8gcmVtb3ZlCml0LiAgSXQgbG9va3MgbGlrZSBEZWJpYW4gZGlk IGluZGVlZCBkbyB0aGF0LCBhbmQgdGhleSB1cGRhdGVkIGl0IGluCmh0dHBzOi8vc2Fsc2EuZGVi aWFuLm9yZy9rZXJuZWwtdGVhbS9saW51eC8tL2NvbW1pdC82YzI0MmM2NDdmODRiZmRiZGMyMmE2 YTc1OGZhNTlkYTRlOTQxYTEwIzEyNTFmOTQwMGE4NTQ4NWQyNzVlMTcwOTc1ODM1MGFhMDk4NzA5 YTgKCkFzIGZvciB5b3VyIG9yaWdpbmFsIHByb2JsZW0sIEknZCBnbGFkIHRvIHNlZSB0aGF0IHRo ZSBzaW1wbGlmaWVkIGRlc2lnbgppcyBwcmV2ZW50aW5nIHByb2JsZW1zLiAgVGhlcmUncyBhbiBp c3N1ZSB3aXRoIGJhY2twb3J0aW5nIHRoaXMgY29tbWl0CmFsb25lLCB0aG91Z2guICBUaGlzIHdh cyBwYXRjaCAxNSBvZiBhIDE5LXBhdGNoIHNlcmllcyBmb3IgYSBnb29kCnJlYXNvbjogdGhlIENS Qy0zMkMgaW1wbGVtZW50YXRpb24gaW4gbGliLyB3YXNuJ3QgYXJjaGl0ZWN0dXJlLW9wdGltaXpl ZAp1bnRpbCBhZnRlciBwYXRjaGVzIDEtMTQgb2YgdGhpcyBzZXJpZXMuICBCYWNrcG9ydGluZyB0 aGlzIGNvbW1pdCBhbG9uZQp3b3VsZCBtYWtlIGNyYzMyYygpIG5vIGxvbmdlciB1dGlsaXplIGFy Y2hpdGVjdHVyZS1vcHRpbWl6ZWQgY29kZS4KCk5vdywgaXQgYWxyZWFkeSBkaWRuJ3QgZG8gc28g cmVsaWFibHkgKGFuZCB0aGlzIHBhdGNoIHNlcmllcyBmaXhlZAp0aGF0KS4gIEhvd2V2ZXIsIGJh Y2twb3J0aW5nIHRoaXMgY29tbWl0IGFsb25lIHdvdWxkIG1ha2UgaXQgbmV2ZXIgZG8Kc28uICBT byBpdCB3b3VsZCByZWdyZXNzIHBlcmZvcm1hbmNlIGluIHNvbWUgY2FzZXMuCgpTaW5jZSB0aGUg ZXJyb3JzIHlvdSdyZSBhY3R1YWxseSBnZXR0aW5nIGFyZToKCiAgICBbICAgMTkuNjE5NzMxXSBJ bnZhbGlkIEVMRiBoZWFkZXIgbWFnaWM6ICE9IEVMRgogICAgbW9kcHJvYmU6IGNhbid0IGxvYWQg bW9kdWxlIGxpYmNyYzMyYyAoa2VybmVsL2xpYi9saWJjcmMzMmMua28ueHopOiB1bmtub3duIHN5 bWJvbCBpbiBtb2R1bGUsIG9yIHVua25vd24gcGFyYW1ldGVyCgpJIGRvIGhhdmUgdG8gd29uZGVy IGlmIHRoaXMgaXMgYWN0dWFsbHkgYSBidXN5Ym94IGJ1ZyBvcgptaXNjb25maWd1cmF0aW9uLCB3 aGVyZSBpdCdzIHBhc3NpbmcgYSBjb21wcmVzc2VkIG1vZHVsZSB0byB0aGUga2VybmVsCndpdGhv dXQgZGVjb21wcmVzc2luZyBpdD8gIEFuZCByZW1vdmluZyB0aGUgbW9kdWxlIGp1c3QgaGlkIHRo ZSBwcm9ibGVtLgoKLSBFcmljCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KTGludXgtZjJmcy1kZXZlbCBtYWlsaW5nIGxpc3QKTGludXgtZjJmcy1kZXZl bEBsaXN0cy5zb3VyY2Vmb3JnZS5uZXQKaHR0cHM6Ly9saXN0cy5zb3VyY2Vmb3JnZS5uZXQvbGlz dHMvbGlzdGluZm8vbGludXgtZjJmcy1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 79320CCD195 for ; Sun, 19 Oct 2025 16:26:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DG8Rv2AkhjE0yj0wUjBGxmKsOVWjSpIzrJguuHzzV8w=; b=D1dFOOqJYnOitq n2wDLhZDoNYW8cmqoB+1VCUoatrG3T2NtK2tWgrCi0Ted9vSZmeFr4lQoe675T/+TJJObLmVnAwyr kHOyxApGZPl+wLVPuZYHOF5Rp44U/Fdoj3KmWdA/FvBgPRishaDn3ekosOhWd9vLni7c/zI9nomeJ DBPFi2uu8ourF2OJqOYc1aT5139aDF3xpNhlQvnLLuOEzdbgjxeqzZ4DP9SGRZE43sspm/X+HJ84U xrDQXXZINvk6d3lJ5wuQ+r4As8TOG4mBWLFioIpWu13KPnI0CutlunX4B/Ggcd/qfLO7KYftaVMrt NuKWcoFHs5hlff8go3fA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vAWDk-0000000BCEE-0Q8e; Sun, 19 Oct 2025 16:25:24 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vAWDg-0000000BCDU-3FdU; Sun, 19 Oct 2025 16:25:22 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 8C9C944476; Sun, 19 Oct 2025 16:25:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D7610C4CEE7; Sun, 19 Oct 2025 16:25:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1760891119; bh=AqeDRU1eKSmQXUiCZ7pwi0Bd8BGGXBM48O4Ou5Xs+sw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=F2EokHRLd68kZBeDRRdhxJ1rDW2elFlh8EnkyaTJnHSCfqkoujh7BohpZc68H407D 6bUXmBrNoq7Ww0jTMF1QQwGeMEpfXz0BrGd0k+T8PJbgWDRrKfDcnhwumf2RRZV3Tp M1nqa0cZRI89OYqyvuvRWeFwctcqJgDf9nK43gHk2G3mRl3usq7ey6ziFEp5oxVwef 8ha/lyEniLuE2fegL9ApZJO+lst38G6OUrwAE6O/NFZ/Mz1YaBFZd+ociss1pkQv9d 0MzWPAoBwoLUZ5+ACw5ohULeXVrjB6+3sdA7UiNPKC79wDn4zGf7+6LA7UKkZ5vUk5 GbYsQCDUj5ADg== Date: Sun, 19 Oct 2025 09:23:46 -0700 From: Eric Biggers To: Askar Safin Cc: ardb@kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-crypto@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, sparclinux@vger.kernel.org, x86@kernel.org, Greg Kroah-Hartman , stable@vger.kernel.org Subject: Re: [PATCH v4 15/19] lib/crc32: make crc32c() go directly to lib Message-ID: <20251019162346.GB1604@sol> References: <20241202010844.144356-16-ebiggers@kernel.org> <20251019060845.553414-1-safinaskar@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20251019_092520_876965_13F3EC67 X-CRM114-Status: GOOD ( 22.04 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gU3VuLCBPY3QgMTksIDIwMjUgYXQgMTE6MTA6MjVBTSArMDMwMCwgQXNrYXIgU2FmaW4gd3Jv dGU6Cj4gT24gU3VuLCBPY3QgMTksIDIwMjUgYXQgOTowOeKAr0FNIEFza2FyIFNhZmluIDxzYWZp bmFza2FyQGdtYWlsLmNvbT4gd3JvdGU6Cj4gPgo+ID4gRXJpYyBCaWdnZXJzIDxlYmlnZ2Vyc0Br ZXJuZWwub3JnPjoKPiA+ID4gTm93IHRoYXQgdGhlIGxvd2VyIGxldmVsIF9fY3JjMzJjX2xlKCkg bGlicmFyeSBmdW5jdGlvbiBpcyBvcHRpbWl6ZWQgZm9yCj4gPgo+ID4gVGhpcyBwYXRjaCAoaS4g ZS4gMzhhOWE1MTIxYzNiICgibGliL2NyYzMyOiBtYWtlIGNyYzMyYygpIGdvIGRpcmVjdGx5IHRv IGxpYiIpKQo+ID4gc29sdmVzIGFjdHVhbCBidWcgSSBmb3VuZCBpbiBwcmFjdGljZS4gU28sIHBs ZWFzZSwgYmFja3BvcnQgaXQKPiA+IHRvIHN0YWJsZSBrZXJuZWxzLgo+IAo+IE9vcHMuIEkganVz dCBub3RpY2VkIHRoYXQgdGhpcyBwYXRjaCByZW1vdmVzIG1vZHVsZSAibGliY3JjMzJjIi4KPiBB bmQgdGhpcyBicmVha3MgYnVpbGQgZm9yIERlYmlhbiBrZXJuZWwgdjYuMTIuNDguCj4gUHJldmlv dXNseSBJIHRlc3RlZCBtaW5pbWFsIGJ1aWxkIHVzaW5nICJtYWtlIGxvY2FsbW9kY29uZmlnIi4K PiBOb3cgSSB0cmllZCBmdWxsIGJ1aWxkIG9mIERlYmlhbiBrZXJuZWwgdXNpbmcgImRwa2ctYnVp bGRwYWNrYWdlIi4KPiBBbmQgaXQgZmFpbGVkLCBiZWNhdXNlIHNvbWUgb2YgRGViaWFuIGZpbGVz IHJlZmVyZW5jZSAibGliY3JjMzJjIiwKPiB3aGljaCBpcyBub3QgYXZhaWxhYmxlLgo+IAo+IFNv LCBwbGVhc2UsIGRvbid0IGJhY2twb3J0IHRoaXMgcGF0Y2ggdG8gc3RhYmxlIGtlcm5lbHMuCj4g SSdtIHNvcnJ5LgoKUmlnaHQsIHRoaXMgY29tbWl0IHNpbXBsaWZpZWQgdGhlIENSQyBsaWJyYXJ5 IGRlc2lnbiBieSByZW1vdmluZyB0aGUKbGliY3JjMzJjIG1vZHVsZS4gIGluaXRyYW1mcyBidWls ZCBzY3JpcHRzIHRoYXQgaGFyZC1jb2RlZCB0aGUgYWRkaXRpb24Kb2YgbGliY3JjMzJjLmtvIGlu dG8gdGhlIHJhbWRpc2sgKHdoaWNoIEkgZG9uJ3QgdGhpbmsgd2FzIGV2ZXIgbmVjZXNzYXJ5Cmlu IHRoZSBmaXJzdCBwbGFjZSwgdGhvdWdoIGl0IGRpZCB1c2VkIHRvIGJlIHVzZWZ1bCB0byBoYXJk LWNvZGUgc29tZSBvZgp0aGUgKm90aGVyKiBDUkMgbW9kdWxlcyBsaWtlIGNyYzMyYy1pbnRlbCkg aGFkIHRvIGJlIHVwZGF0ZWQgdG8gcmVtb3ZlCml0LiAgSXQgbG9va3MgbGlrZSBEZWJpYW4gZGlk IGluZGVlZCBkbyB0aGF0LCBhbmQgdGhleSB1cGRhdGVkIGl0IGluCmh0dHBzOi8vc2Fsc2EuZGVi aWFuLm9yZy9rZXJuZWwtdGVhbS9saW51eC8tL2NvbW1pdC82YzI0MmM2NDdmODRiZmRiZGMyMmE2 YTc1OGZhNTlkYTRlOTQxYTEwIzEyNTFmOTQwMGE4NTQ4NWQyNzVlMTcwOTc1ODM1MGFhMDk4NzA5 YTgKCkFzIGZvciB5b3VyIG9yaWdpbmFsIHByb2JsZW0sIEknZCBnbGFkIHRvIHNlZSB0aGF0IHRo ZSBzaW1wbGlmaWVkIGRlc2lnbgppcyBwcmV2ZW50aW5nIHByb2JsZW1zLiAgVGhlcmUncyBhbiBp c3N1ZSB3aXRoIGJhY2twb3J0aW5nIHRoaXMgY29tbWl0CmFsb25lLCB0aG91Z2guICBUaGlzIHdh cyBwYXRjaCAxNSBvZiBhIDE5LXBhdGNoIHNlcmllcyBmb3IgYSBnb29kCnJlYXNvbjogdGhlIENS Qy0zMkMgaW1wbGVtZW50YXRpb24gaW4gbGliLyB3YXNuJ3QgYXJjaGl0ZWN0dXJlLW9wdGltaXpl ZAp1bnRpbCBhZnRlciBwYXRjaGVzIDEtMTQgb2YgdGhpcyBzZXJpZXMuICBCYWNrcG9ydGluZyB0 aGlzIGNvbW1pdCBhbG9uZQp3b3VsZCBtYWtlIGNyYzMyYygpIG5vIGxvbmdlciB1dGlsaXplIGFy Y2hpdGVjdHVyZS1vcHRpbWl6ZWQgY29kZS4KCk5vdywgaXQgYWxyZWFkeSBkaWRuJ3QgZG8gc28g cmVsaWFibHkgKGFuZCB0aGlzIHBhdGNoIHNlcmllcyBmaXhlZAp0aGF0KS4gIEhvd2V2ZXIsIGJh Y2twb3J0aW5nIHRoaXMgY29tbWl0IGFsb25lIHdvdWxkIG1ha2UgaXQgbmV2ZXIgZG8Kc28uICBT byBpdCB3b3VsZCByZWdyZXNzIHBlcmZvcm1hbmNlIGluIHNvbWUgY2FzZXMuCgpTaW5jZSB0aGUg ZXJyb3JzIHlvdSdyZSBhY3R1YWxseSBnZXR0aW5nIGFyZToKCiAgICBbICAgMTkuNjE5NzMxXSBJ bnZhbGlkIEVMRiBoZWFkZXIgbWFnaWM6ICE9IEVMRgogICAgbW9kcHJvYmU6IGNhbid0IGxvYWQg bW9kdWxlIGxpYmNyYzMyYyAoa2VybmVsL2xpYi9saWJjcmMzMmMua28ueHopOiB1bmtub3duIHN5 bWJvbCBpbiBtb2R1bGUsIG9yIHVua25vd24gcGFyYW1ldGVyCgpJIGRvIGhhdmUgdG8gd29uZGVy IGlmIHRoaXMgaXMgYWN0dWFsbHkgYSBidXN5Ym94IGJ1ZyBvcgptaXNjb25maWd1cmF0aW9uLCB3 aGVyZSBpdCdzIHBhc3NpbmcgYSBjb21wcmVzc2VkIG1vZHVsZSB0byB0aGUga2VybmVsCndpdGhv dXQgZGVjb21wcmVzc2luZyBpdD8gIEFuZCByZW1vdmluZyB0aGUgbW9kdWxlIGp1c3QgaGlkIHRo ZSBwcm9ibGVtLgoKLSBFcmljCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpsaW51eC1yaXNjdiBtYWlsaW5nIGxpc3QKbGludXgtcmlzY3ZAbGlzdHMuaW5m cmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LXJpc2N2Cg==