From: Jakub Kicinski <kuba@kernel.org>
To: Daniel Jurgens <danielj@nvidia.com>
Cc: <netdev@vger.kernel.org>, <mst@redhat.com>, <jasowang@redhat.com>,
<alex.williamson@redhat.com>, <pabeni@redhat.com>,
<virtualization@lists.linux.dev>, <parav@nvidia.com>,
<shshitrit@nvidia.com>, <yohadt@nvidia.com>,
<xuanzhuo@linux.alibaba.com>, <eperezma@redhat.com>,
<shameerali.kolothum.thodi@huawei.com>, <jgg@ziepe.ca>,
<kevin.tian@intel.com>, <andrew+netdev@lunn.ch>,
<edumazet@google.com>
Subject: Re: [PATCH net-next v5 05/12] virtio_net: Query and set flow filter caps
Date: Mon, 20 Oct 2025 16:59:57 -0700 [thread overview]
Message-ID: <20251020165957.62a127eb@kernel.org> (raw)
In-Reply-To: <20251016050055.2301-6-danielj@nvidia.com>
On Thu, 16 Oct 2025 00:00:48 -0500 Daniel Jurgens wrote:
> +struct virtio_net_ff_selector {
> + __u8 type;
> + __u8 flags;
> + __u8 reserved[2];
> + __u8 length;
> + __u8 reserved1[3];
> + __u8 mask[];
> +};
> +/**
> + * struct virtio_net_ff_cap_mask_data - Supported selector mask formats
> + * @count: number of entries in @selectors
> + * @reserved: must be set to 0 by the driver and ignored by the device
> + * @selectors: array of supported selector descriptors
> + */
> +struct virtio_net_ff_cap_mask_data {
> + __u8 count;
> + __u8 reserved[7];
> + struct virtio_net_ff_selector selectors[];
> +};
sparse complains:
include/uapi/linux/virtio_net_ff.h:73:48: warning: array of flexible structures
which seems legit. Since only element 0 can reasonably be accessed
perhaps make selectors
__u8 selectors[]; /* struct virtio_net_ff_selector */
?
--
pw-bot: cr
next prev parent reply other threads:[~2025-10-20 23:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-16 5:00 [PATCH net-next v5 00/12] virtio_net: Add ethtool flow rules support Daniel Jurgens
2025-10-16 5:00 ` [PATCH net-next v5 01/12] virtio_pci: Remove supported_cap size build assert Daniel Jurgens
2025-10-16 5:00 ` [PATCH net-next v5 02/12] virtio: Add config_op for admin commands Daniel Jurgens
2025-10-16 5:00 ` [PATCH net-next v5 03/12] virtio: Expose generic device capability operations Daniel Jurgens
2025-10-16 5:00 ` [PATCH net-next v5 04/12] virtio: Expose object create and destroy API Daniel Jurgens
2025-10-16 5:00 ` [PATCH net-next v5 05/12] virtio_net: Query and set flow filter caps Daniel Jurgens
2025-10-20 23:59 ` Jakub Kicinski [this message]
2025-10-21 13:26 ` Dan Jurgens
2025-10-21 13:18 ` Michael S. Tsirkin
2025-10-21 13:38 ` Dan Jurgens
2025-10-16 5:00 ` [PATCH net-next v5 06/12] virtio_net: Create a FF group for ethtool steering Daniel Jurgens
2025-10-16 5:00 ` [PATCH net-next v5 07/12] virtio_net: Implement layer 2 ethtool flow rules Daniel Jurgens
2025-10-16 5:00 ` [PATCH net-next v5 08/12] virtio_net: Use existing classifier if possible Daniel Jurgens
2025-10-16 5:00 ` [PATCH net-next v5 09/12] virtio_net: Implement IPv4 ethtool flow rules Daniel Jurgens
2025-10-16 5:00 ` [PATCH net-next v5 10/12] virtio_net: Add support for IPv6 ethtool steering Daniel Jurgens
2025-10-16 5:00 ` [PATCH net-next v5 11/12] virtio_net: Add support for TCP and UDP ethtool rules Daniel Jurgens
2025-10-16 5:00 ` [PATCH net-next v5 12/12] virtio_net: Add get ethtool flow rules ops Daniel Jurgens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251020165957.62a127eb@kernel.org \
--to=kuba@kernel.org \
--cc=alex.williamson@redhat.com \
--cc=andrew+netdev@lunn.ch \
--cc=danielj@nvidia.com \
--cc=edumazet@google.com \
--cc=eperezma@redhat.com \
--cc=jasowang@redhat.com \
--cc=jgg@ziepe.ca \
--cc=kevin.tian@intel.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=parav@nvidia.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=shshitrit@nvidia.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
--cc=yohadt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.