Re: [PATCH 2/2] iio: adc: adding support for PAC1711

[kernel test robot <lkp@intel.com>]

:::::: 
:::::: Manual check reason: "low confidence static check warning: drivers/iio/adc/pac1711.c:1079:27: sparse: sparse: unsigned value that used to be signed checked against zero?"
:::::: 

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20251015-pac1711-v1-2-976949e36367@microchip.com>
References: <20251015-pac1711-v1-2-976949e36367@microchip.com>
TO: Ariana Lazar <ariana.lazar@microchip.com>
TO: Jonathan Cameron <jic23@kernel.org>
TO: David Lechner <dlechner@baylibre.com>
TO: "Nuno Sá" <nuno.sa@analog.com>
TO: Andy Shevchenko <andy@kernel.org>
TO: Rob Herring <robh@kernel.org>
TO: Krzysztof Kozlowski <krzk@kernel.org>
TO: Conor Dooley <conor+dt@kernel.org>
CC: linux-iio@vger.kernel.org
CC: devicetree@vger.kernel.org
CC: linux-kernel@vger.kernel.org
CC: Ariana Lazar <ariana.lazar@microchip.com>

Hi Ariana,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 19272b37aa4f83ca52bdf9c16d5d81bdd1354494]

url:    https://github.com/intel-lab-lkp/linux/commits/Ariana-Lazar/dt-bindings-iio-adc-adding-support-for-PAC1711/20251016-002337
base:   19272b37aa4f83ca52bdf9c16d5d81bdd1354494
patch link:    https://lore.kernel.org/r/20251015-pac1711-v1-2-976949e36367%40microchip.com
patch subject: [PATCH 2/2] iio: adc: adding support for PAC1711
:::::: branch date: 5 days ago
:::::: commit date: 5 days ago
config: csky-randconfig-r112-20251021 (https://download.01.org/0day-ci/archive/20251021/202510210413.JRfDM9jF-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 13.4.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251021/202510210413.JRfDM9jF-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/r/202510210413.JRfDM9jF-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> drivers/iio/adc/pac1711.c:1079:27: sparse: sparse: unsigned value that used to be signed checked against zero?
>> drivers/iio/adc/pac1711.c:1078:42: sparse: signed value source
   drivers/iio/adc/pac1711.c:1102:27: sparse: sparse: unsigned value that used to be signed checked against zero?
   drivers/iio/adc/pac1711.c:1101:42: sparse: signed value source

vim +1079 drivers/iio/adc/pac1711.c

de2a3cdfd6e76b Ariana Lazar 2025-10-15  1065  
de2a3cdfd6e76b Ariana Lazar 2025-10-15  1066  static int pac1711_setup_vbus_range(struct pac1711_chip_info *info)
de2a3cdfd6e76b Ariana Lazar 2025-10-15  1067  {
de2a3cdfd6e76b Ariana Lazar 2025-10-15  1068  	const char *prop_name = "microchip,vbus-input-range-microvolt";
de2a3cdfd6e76b Ariana Lazar 2025-10-15  1069  	struct i2c_client *client = info->client;
de2a3cdfd6e76b Ariana Lazar 2025-10-15  1070  	struct device *dev = &client->dev;
de2a3cdfd6e76b Ariana Lazar 2025-10-15  1071  	unsigned int tbl_len, ret;
de2a3cdfd6e76b Ariana Lazar 2025-10-15  1072  	s32 vals[2];
de2a3cdfd6e76b Ariana Lazar 2025-10-15  1073  
de2a3cdfd6e76b Ariana Lazar 2025-10-15  1074  	/* default value is unipolar and Full Scale Range */
de2a3cdfd6e76b Ariana Lazar 2025-10-15  1075  	ret = device_property_read_u32_array(dev, prop_name, vals, 2);
de2a3cdfd6e76b Ariana Lazar 2025-10-15  1076  	if (!ret) {
de2a3cdfd6e76b Ariana Lazar 2025-10-15  1077  		tbl_len = ARRAY_SIZE(pac1711_vbus_range_tbl);
de2a3cdfd6e76b Ariana Lazar 2025-10-15 @1078  		ret = pac1711_check_range(vals, pac1711_vbus_range_tbl, tbl_len);
de2a3cdfd6e76b Ariana Lazar 2025-10-15 @1079  		if (ret < 0)
de2a3cdfd6e76b Ariana Lazar 2025-10-15  1080  			return dev_err_probe(dev, -EINVAL, "Invalid value %d, %d for prop %s\n",
de2a3cdfd6e76b Ariana Lazar 2025-10-15  1081  					     vals[0], vals[1], prop_name);
de2a3cdfd6e76b Ariana Lazar 2025-10-15  1082  
de2a3cdfd6e76b Ariana Lazar 2025-10-15  1083  		info->vbus_mode = ret;
de2a3cdfd6e76b Ariana Lazar 2025-10-15  1084  	}
de2a3cdfd6e76b Ariana Lazar 2025-10-15  1085  
de2a3cdfd6e76b Ariana Lazar 2025-10-15  1086  	return 0;
de2a3cdfd6e76b Ariana Lazar 2025-10-15  1087  }
de2a3cdfd6e76b Ariana Lazar 2025-10-15  1088  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki