From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jack Wang <jinpu.wang@ionos.com>
Cc: qemu-devel@nongnu.org, yu.zhang@ionos.com
Subject: Re: [PATCH] qmp: Fix a typo for a USO feature
Date: Tue, 21 Oct 2025 08:59:08 -0400 [thread overview]
Message-ID: <20251021085833-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20251021053309.208957-1-jinpu.wang@ionos.com>
On Tue, Oct 21, 2025 at 07:33:09AM +0200, Jack Wang wrote:
> There is a copy & paste error, USO6 should be there.
>
> Fixes: 58f81689789f ("qmp: update virtio feature maps, vhost-user-gpio introspection")
> Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
Can the FEATURE_ENTRY macro be updated to include the
string in there automatically, please?
It's really pointless to repeat it.
> ---
> hw/virtio/virtio-qmp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/virtio/virtio-qmp.c b/hw/virtio/virtio-qmp.c
> index b338344c6cca..968299fda0c9 100644
> --- a/hw/virtio/virtio-qmp.c
> +++ b/hw/virtio/virtio-qmp.c
> @@ -299,7 +299,7 @@ static const qmp_virtio_feature_map_t virtio_net_feature_map[] = {
> FEATURE_ENTRY(VIRTIO_NET_F_GUEST_USO4, \
> "VIRTIO_NET_F_GUEST_USO4: Driver can receive USOv4"),
> FEATURE_ENTRY(VIRTIO_NET_F_GUEST_USO6, \
> - "VIRTIO_NET_F_GUEST_USO4: Driver can receive USOv6"),
> + "VIRTIO_NET_F_GUEST_USO6: Driver can receive USOv6"),
> FEATURE_ENTRY(VIRTIO_NET_F_HOST_USO, \
> "VIRTIO_NET_F_HOST_USO: Device can receive USO"),
> FEATURE_ENTRY(VIRTIO_NET_F_HASH_REPORT, \
> --
> 2.43.0
next prev parent reply other threads:[~2025-10-21 13:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-21 5:33 [PATCH] qmp: Fix a typo for a USO feature Jack Wang
2025-10-21 12:59 ` Michael S. Tsirkin [this message]
2025-11-17 8:38 ` Michael Tokarev
2025-11-17 8:42 ` Jinpu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251021085833-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=jinpu.wang@ionos.com \
--cc=qemu-devel@nongnu.org \
--cc=yu.zhang@ionos.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.