From: Lee Jones <lee@kernel.org>
To: Christian Hitz <christian@klarinett.li>
Cc: Pavel Machek <pavel@kernel.org>,
Christian Hitz <christian.hitz@bbv.ch>,
stable@vger.kernel.org, linux-leds@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] leds: leds-lp50xx: LP5009 supports 3 modules for a total of 9 LEDs
Date: Tue, 21 Oct 2025 16:06:42 +0100 [thread overview]
Message-ID: <20251021150642.GJ475031@google.com> (raw)
In-Reply-To: <20251008125031.1174886-1-christian@klarinett.li>
On Wed, 08 Oct 2025, Christian Hitz wrote:
> From: Christian Hitz <christian.hitz@bbv.ch>
You need forthcoming and insightful commit message.
> Signed-off-by: Christian Hitz <christian.hitz@bbv.ch>
> Cc: stable@vger.kernel.org
Fine, but place this above your SoB.
> ---
> drivers/leds/leds-lp50xx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/leds/leds-lp50xx.c b/drivers/leds/leds-lp50xx.c
> index 94f8ef6b482c..05229e2f2e7e 100644
> --- a/drivers/leds/leds-lp50xx.c
> +++ b/drivers/leds/leds-lp50xx.c
> @@ -54,7 +54,7 @@
> /* There are 3 LED outputs per bank */
> #define LP50XX_LEDS_PER_MODULE 3
>
> -#define LP5009_MAX_LED_MODULES 2
> +#define LP5009_MAX_LED_MODULES 3
> #define LP5012_MAX_LED_MODULES 4
> #define LP5018_MAX_LED_MODULES 6
> #define LP5024_MAX_LED_MODULES 8
> --
> 2.51.0
>
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2025-10-21 15:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-08 12:50 [PATCH] leds: leds-lp50xx: LP5009 supports 3 modules for a total of 9 LEDs Christian Hitz
2025-10-21 15:06 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251021150642.GJ475031@google.com \
--to=lee@kernel.org \
--cc=christian.hitz@bbv.ch \
--cc=christian@klarinett.li \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.