From: Jakub Kicinski <kuba@kernel.org>
To: Gerhard Engleder <gerhard@engleder-embedded.com>
Cc: Horatiu Vultur <horatiu.vultur@microchip.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
richardcochran@gmail.com
Subject: Re: [PATCH net-next] net: phy: micrel: Add support for non PTP SKUs for lan8814
Date: Tue, 21 Oct 2025 16:14:47 -0700 [thread overview]
Message-ID: <20251021161447.311a3e0f@kernel.org> (raw)
In-Reply-To: <e0a8830e-6267-4b2a-b1fa-f3cbe34bd3ba@engleder-embedded.com>
On Mon, 20 Oct 2025 20:11:13 +0200 Gerhard Engleder wrote:
> >> Hasn't net also switched to the common kernel multiline comment style
> >> starting with an empty line?
> >
> > I am not sure because I can see some previous commits where people used
> > the same comment style:
> > e82c64be9b45 ("net: stmmac: avoid PHY speed change when configuring MTU")
> > 100dfa74cad9 ("net: dev_queue_xmit() llist adoption")
>
> The special coding style for multi line comments for net and drivers/net
> has been removed with
> 82b8000c28 ("net: drop special comment style")
>
> But I checked a few mails on the list and also found the old style in
> new patches.
We removed the check that _suggests_ the use of the superior style.
Aesthetic taste is not evenly distributed within the population.
But we still prefer the old style in netdev.
That said I don't think nit picking on comment style is productive,
in either direction.
next prev parent reply other threads:[~2025-10-21 23:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-17 7:47 [PATCH net-next] net: phy: micrel: Add support for non PTP SKUs for lan8814 Horatiu Vultur
2025-10-17 21:15 ` Gerhard Engleder
2025-10-20 6:39 ` Horatiu Vultur
2025-10-20 18:11 ` Gerhard Engleder
2025-10-21 6:51 ` Horatiu Vultur
2025-10-21 9:03 ` Russell King (Oracle)
2025-10-21 23:14 ` Jakub Kicinski [this message]
2025-10-22 4:12 ` Gerhard Engleder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251021161447.311a3e0f@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gerhard@engleder-embedded.com \
--cc=hkallweit1@gmail.com \
--cc=horatiu.vultur@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.