From: Jakub Kicinski <kuba@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>
Cc: andrew@lunn.ch, Horatiu Vultur <horatiu.vultur@microchip.com>,
hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
edumazet@google.com, richardcochran@gmail.com,
vladimir.oltean@nxp.com, vadim.fedorenko@linux.dev,
rmk+kernel@armlinux.org.uk, christophe.jaillet@wanadoo.fr,
rosenp@gmail.com, steen.hegelund@microchip.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v4 2/2] phy: mscc: Fix PTP for VSC8574 and VSC8572
Date: Tue, 21 Oct 2025 16:52:30 -0700 [thread overview]
Message-ID: <20251021165230.1a702ffd@kernel.org> (raw)
In-Reply-To: <09b90c94-4b55-4b9f-a23b-e2bd920545bf@redhat.com>
On Tue, 21 Oct 2025 11:07:20 +0200 Paolo Abeni wrote:
> On 10/21/25 1:53 AM, Jakub Kicinski wrote:
> > On Fri, 17 Oct 2025 08:48:19 +0200 Horatiu Vultur wrote:
> >> For VSC8574 and VSC8572, the PTP initialization is incomplete. It is
> >> missing the first part but it makes the second part. Meaning that the
> >> ptp_clock_register() is never called.
> >>
> >> There is no crash without the first part when enabling PTP but this is
> >> unexpected because some PHys have PTP functionality exposed by the
> >> driver and some don't even though they share the same PTP clock PTP.
> >
> > I'm tempted to queue this to net-next, sounds like a "never worked
> > in an obvious way" case. I'd appreciate a second opinion.. Andrew?
>
> FTR, I agree with the above, as (out of sheer ignorance) I think/fear
> the first patch can potentially cause regressions.
Thanks, let's rephrase the commits message on patch 1 (per Russell's
comments) and get this reposted for net-next (without the Fixes tag).
prev parent reply other threads:[~2025-10-21 23:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-17 6:48 [PATCH net v4 0/2] phy: mscc: Fix PTP for VSC8574 and VSC8572 Horatiu Vultur
2025-10-17 6:48 ` [PATCH net v4 1/2] phy: mscc: Use PHY_ID_MATCH_MODEL for VSC8584, VSC8582, VSC8575, VSC856X Horatiu Vultur
2025-10-17 7:42 ` Maxime Chevallier
2025-10-21 9:09 ` Russell King (Oracle)
2025-10-22 7:56 ` Horatiu Vultur
2025-10-21 23:51 ` Jakub Kicinski
2025-10-17 6:48 ` [PATCH net v4 2/2] phy: mscc: Fix PTP for VSC8574 and VSC8572 Horatiu Vultur
2025-10-17 7:41 ` Maxime Chevallier
2025-10-20 23:53 ` Jakub Kicinski
2025-10-21 9:07 ` Paolo Abeni
2025-10-21 23:52 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251021165230.1a702ffd@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=christophe.jaillet@wanadoo.fr \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=horatiu.vultur@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=rosenp@gmail.com \
--cc=steen.hegelund@microchip.com \
--cc=vadim.fedorenko@linux.dev \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.