From: Rob Herring <robh@kernel.org>
To: Wei Fang <wei.fang@nxp.com>
Cc: krzk+dt@kernel.org, conor+dt@kernel.org, claudiu.manoil@nxp.com,
vladimir.oltean@nxp.com, xiaoning.wang@nxp.com, Frank.Li@nxp.com,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, richardcochran@gmail.com,
imx@lists.linux.dev, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH net-next 3/8] dt-bindings: net: ethernet-controller: remove the enum values of speed
Date: Tue, 21 Oct 2025 15:50:44 -0500 [thread overview]
Message-ID: <20251021205044.GA776699-robh@kernel.org> (raw)
In-Reply-To: <20251016102020.3218579-4-wei.fang@nxp.com>
On Thu, Oct 16, 2025 at 06:20:14PM +0800, Wei Fang wrote:
> Some fixed-link devices have uncommon link speeds. For example, the CPU
> port of NXP NETC switch is connected to an ENETC (Ethernet Controller),
> they are fully integrated into the NETC IP and connected through the
> 'pseudo link'. The link speed varies depending on the NETC version. For
> example, the speed of NETC v4.3 is 2680 Mbps, other versions may be 8
> Gbps or 12.5 Gbps or other speeds. There is no need and pointless to add
> these values to ethernet-controller.yaml. Therefore, remove these enum
> values so that when performing dtbs_check, no warnings are reported for
> the uncommon values.
Every binding that used this was relying on these constraints. So you've
got to move them into the individual bindings. I'd leave a minimum and
maximum here.
>
> Signed-off-by: Wei Fang <wei.fang@nxp.com>
> ---
> Documentation/devicetree/bindings/net/ethernet-controller.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/net/ethernet-controller.yaml b/Documentation/devicetree/bindings/net/ethernet-controller.yaml
> index 1bafd687dcb1..7fa02d58c208 100644
> --- a/Documentation/devicetree/bindings/net/ethernet-controller.yaml
> +++ b/Documentation/devicetree/bindings/net/ethernet-controller.yaml
> @@ -177,7 +177,6 @@ properties:
> description:
> Link speed.
> $ref: /schemas/types.yaml#/definitions/uint32
> - enum: [10, 100, 1000, 2500, 5000, 10000]
>
> full-duplex:
> $ref: /schemas/types.yaml#/definitions/flag
> --
> 2.34.1
>
next prev parent reply other threads:[~2025-10-21 20:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-16 10:20 [PATCH net-next 0/8] net: enetc: Add i.MX94 ENETC support Wei Fang
2025-10-16 10:20 ` [PATCH net-next 1/8] dt-bindings: net: netc-blk-ctrl: add compatible string for i.MX94 platforms Wei Fang
2025-10-21 20:38 ` Rob Herring (Arm)
2025-10-16 10:20 ` [PATCH net-next 2/8] dt-bindings: net: enetc: add compatible string for ENETC with pseduo MAC Wei Fang
2025-10-21 20:38 ` Rob Herring (Arm)
2025-10-16 10:20 ` [PATCH net-next 3/8] dt-bindings: net: ethernet-controller: remove the enum values of speed Wei Fang
2025-10-21 20:50 ` Rob Herring [this message]
2025-10-22 1:51 ` Wei Fang
2025-10-16 10:20 ` [PATCH net-next 4/8] net: enetc: add preliminary i.MX94 NETC blocks control support Wei Fang
2025-10-16 10:20 ` [PATCH net-next 5/8] net: enetc: add ptp timer binding support for i.MX94 Wei Fang
2025-10-21 7:21 ` Paolo Abeni
2025-10-16 10:20 ` [PATCH net-next 6/8] net: enetc: add basic support for the ENETC with pseudo MAC " Wei Fang
2025-10-21 7:26 ` Paolo Abeni
2025-10-22 1:44 ` Wei Fang
2025-10-16 10:20 ` [PATCH net-next 7/8] net: enetc: add standalone ENETC support " Wei Fang
2025-10-16 10:20 ` [PATCH 8/8] arm64: dts: imx94: add basic NETC nodes and properties Wei Fang
2025-10-16 12:11 ` [PATCH net-next 0/8] net: enetc: Add i.MX94 ENETC support Rob Herring (Arm)
2025-10-21 7:14 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251021205044.GA776699-robh@kernel.org \
--to=robh@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=andrew+netdev@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=imx@lists.linux.dev \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=vladimir.oltean@nxp.com \
--cc=wei.fang@nxp.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.