From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AEA00CCD1BC for ; Tue, 21 Oct 2025 21:40:01 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3426510E357; Tue, 21 Oct 2025 21:40:00 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="EaAhNjSD"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8756910E34D; Tue, 21 Oct 2025 21:39:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1761082796; x=1792618796; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=iW/BcUJLCLLlHu2nMhEhUz1mgvhc+oR29dpeVfRwugQ=; b=EaAhNjSDFmoffM7rVvnJDzTH9C9vKEncap4jUwHMO24jbLJAp3vrJ8NC Apm/lup9d0uHkSXewbyrUrMN8O6g+uKnoSfsWDiu/H4dqd8Q6ibS+7kWu H3xLP/ipLLHeO5pkX1IsYm6lk0Xdhdpbki3I1cXnGb9T/+Lwos1CQQEhI fHC9Srety5g2iagICnm1JnbYsr6M4vnGtnPQwoe5ngb1wnGV0U//Gwbx2 B1avF4V7pBAI2rl8PbqEoRKn+Xceiqpzr8cln/EAjTEYJffOAbOKSgrRC 8IKbHmW0JHYsebFyRo1tDi45eGMpoimGi1w07s2y/0+B+hPFQj0cD3jx/ A==; X-CSE-ConnectionGUID: 0HS/brJNScOm9KGmzdhCsg== X-CSE-MsgGUID: SVC84D/SQh6ISPfW9K71+Q== X-IronPort-AV: E=McAfee;i="6800,10657,11586"; a="63131557" X-IronPort-AV: E=Sophos;i="6.19,245,1754982000"; d="scan'208";a="63131557" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Oct 2025 14:39:56 -0700 X-CSE-ConnectionGUID: 5kZ3gezoRQ2L5SMtTVCJOg== X-CSE-MsgGUID: 7LQ0VDHOTzmkZBnZ5Rs0Vw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.19,245,1754982000"; d="scan'208";a="184099255" Received: from lstrano-desk.jf.intel.com ([10.54.39.91]) by fmviesa008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Oct 2025 14:39:56 -0700 From: Matthew Brost To: intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: jiangshanlai@gmail.com, tj@kernel.org, simona.vetter@ffwll.ch, christian.koenig@amd.com, pstanner@redhat.com, dakr@kernel.org Subject: [RFC PATCH 2/3] drm/sched: Taint workqueues with reclaim Date: Tue, 21 Oct 2025 14:39:51 -0700 Message-Id: <20251021213952.746900-3-matthew.brost@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20251021213952.746900-1-matthew.brost@intel.com> References: <20251021213952.746900-1-matthew.brost@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" Multiple drivers seemingly do not understand the role of DMA fences in the reclaim path. As a result, DRM scheduler workqueues, which are part of the fence signaling path, must not allocate memory. This patch teaches lockdep to recognize these rules in order to catch driver-side bugs. Cc: Christian König Cc: Danilo Krummrich Cc: Matthew Brost Cc: Philipp Stanner Cc: dri-devel@lists.freedesktop.org Signed-off-by: Matthew Brost --- drivers/gpu/drm/scheduler/sched_main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c index c39f0245e3a9..676484dd3ea3 100644 --- a/drivers/gpu/drm/scheduler/sched_main.c +++ b/drivers/gpu/drm/scheduler/sched_main.c @@ -1368,6 +1368,9 @@ int drm_sched_init(struct drm_gpu_scheduler *sched, const struct drm_sched_init_ atomic64_set(&sched->job_id_count, 0); sched->pause_submit = false; + taint_reclaim_workqueue(sched->submit_wq, GFP_KERNEL); + taint_reclaim_workqueue(sched->timeout_wq, GFP_KERNEL); + sched->ready = true; return 0; Out_unroll: -- 2.34.1