All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Subject: Re: [PATCH 3/3] drm/i915/dmc: Set DMC_EVT_CTL_ENABLE for disabled event handlers as well
Date: Wed, 22 Oct 2025 16:57:52 +0200	[thread overview]
Message-ID: <20251022145752.GB493682@pevik> (raw)
In-Reply-To: <20251022100718.24803-4-ville.syrjala@linux.intel.com>

Hi Ville, all,

> DMC_EVT_CTL_ENABLE cannot be cleared once set. So currently
> any event we never enable will have DMC_EVT_CTL_ENABLE cleared,
> whereas any event which has been enabled even once will have
> DMC_EVT_CTL_ENABLE set. For that reason assert_dmc_loaded() has
> a special case to ignore any mismatches in DMC_EVT_CTL_ENABLE.

> Eliminate the special case by always configuring DMC_EVT_CTL_ENABLE
> based on the original firmware event definition. Now all
> event handlers will have DMC_EVT_CTL_ENABLE set, whether or
> not the event has been enabled in the past.

> All disabled event handlers will still have the event type set
> to DMC_EVENT_FALSE so they will not actually trigger despite
> DMC_EVT_CTL_ENABLE being set.

LGTM.

Reviewed-by: Petr Vorel <pvorel@suse.cz>

Kind regards,
Petr

  reply	other threads:[~2025-10-22 14:58 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-22 10:07 [PATCH 0/3] drm/i915/dmc: Event handler fixes Ville Syrjala
2025-10-22 10:07 ` [PATCH 1/3] drm/i915/dmc: Clear HRR EVT_CTL/HTP to zero on ADL-S Ville Syrjala
2025-10-22 11:21   ` Petr Vorel
2025-10-22 10:07 ` [PATCH 2/3] drm/i915/dmc: Fixup TGL/ADL-S HRR event handler type Ville Syrjala
2025-10-22 15:11   ` Petr Vorel
2025-10-22 10:07 ` [PATCH 3/3] drm/i915/dmc: Set DMC_EVT_CTL_ENABLE for disabled event handlers as well Ville Syrjala
2025-10-22 14:57   ` Petr Vorel [this message]
2025-10-22 11:55 ` ✓ i915.CI.BAT: success for drm/i915/dmc: Event handler fixes Patchwork
2025-10-22 14:57 ` ✓ i915.CI.Full: " Patchwork
2025-10-22 15:18 ` ✗ CI.checkpatch: warning " Patchwork
2025-10-22 15:20 ` ✓ CI.KUnit: success " Patchwork
2025-10-22 16:00 ` ✓ Xe.CI.BAT: " Patchwork
2025-10-22 17:25 ` [PATCH 0/3] " Imre Deak
2025-10-22 18:25 ` ✗ Xe.CI.Full: failure for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251022145752.GB493682@pevik \
    --to=pvorel@suse.cz \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.