From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E53033FE02 for ; Wed, 22 Oct 2025 12:08:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761134899; cv=none; b=NMvff0blhmTreA2glP4ccoqPRf8swRKXEyLj0FQhu6mLyUJ+oPZwNRvP1wi42BizzJcM1KL5OIe/QT1CqlI8AIRtX+Wj2eIy5tiuKVjVLTmtlAG25I/NnxnZvwDan+7Fq5UDgZRWgvjT+HAWH66hfy9zLQvWwaMLpSAUMxjb9kE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761134899; c=relaxed/simple; bh=tZhHNi5tiOiq5ZyFScnnqPfCNqj/bQHHe9aIYrpZW4I=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=iO7g0fFRhJX71vgZKduVpRTBkBWelLnwdTnxLJbRGvfac3veRXLLSkMlwGM65NwARbJqtHLSgXLRywKkSvVghHdva+rGR3ol1TymWIy0vEn4NqzlHnVbPQNWhNkkMkLGXcHakXzdOgb3f4H5GBGiSXiQVc0R7Qql/UshrO9kMp0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=mAb/BAuD; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="mAb/BAuD" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-4283be7df63so2124056f8f.1 for ; Wed, 22 Oct 2025 05:08:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1761134895; x=1761739695; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=DvbnSMIYk5HD128ctAAfLOD94aj1lQC5qodcVPOSef8=; b=mAb/BAuDoSfCWnlXuhzOZxDIIkeYs1WisznnsMqjrFqo98GMGDq/bZOuWeKp1aQcry +Jph9qfwTrxt2IK4e2YaizdedWsKnmnifSTkoGjx6hcYuBAAY6VX2aWvOPgGeb5V0w5B 4+JG9QD0Uu7qFWT4z+rxiz8j/1GbyP5c9vT1t1rKF8W+aMHAAVP3KybcO3YsUV272ZNt 2r3xdqKtV8BYIsIMPBcDHssOEvAi+T5YAH2LTMAomGrKvg/1Szbo72ZQw52kxqxviGEu AFn6qjKTqw9ecfjgxFsUbG5m0BL32XQyQLtDf64P/syrq8I97t7Lto6oPC4s3PH7HEM/ QgVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761134895; x=1761739695; h=in-reply-to:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DvbnSMIYk5HD128ctAAfLOD94aj1lQC5qodcVPOSef8=; b=Y0EUl0XGJUhaQtFoLIMWlydRxILMFK41fYeaKiT58M7m/XSW+xjYXuurBFLtx+sUBd fc5ACq5wdW1Xr9SBAdWlWAJhL2hUhZCjfbacTl6piKh5rW88Z7n3jVMa+/x/vYRaXd/7 d++IwCS7oKDsmTyUBXl7vzslw4CVIOgYBL2q1S8P40Byo9uQY0x2VBYEvpMPnwopPHfL MietPfFea1XkXQiobC/W/E2ISkqxsBj6E1bme9pvDFjExxHBTPwNxTZvCz5RIBEtUZ7f Pwmc+/v+DvKt/oIPx9JLsq8nT0/ViG3P2PC1S0XMgGF4zgvoRls4fIv8oEU4JLc/sCZx SDvg== X-Forwarded-Encrypted: i=1; AJvYcCXjXSizYgBAMKOzGObzTbmSOVmLteTdgxapIdo5k2+FmE4E/gzzWrAmbl94U/mzZU4R8DL1dBBGews=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1Co0Q4fW69Q2MrPoAAGcZdfPqBEdccdb5VY95HJLuISdHX4NA SdHVPM80v1nrW+JCS1KILtB1y2D7w4Z9mSrn2V/lJItFRVUlHe6hNu7108Z0Qji0h1k= X-Gm-Gg: ASbGncsLux8zzRgfoNiacY2PL1wmqM+dWPTswFB5prAQjq4v41aXvb7Pzrq9oZ0vFZ7 HtHmciVEKW7pSvzdFFrvM/h1LcWzUyK/lvWLcIpDpFzurFPNEP87kMlIkeO4diCnzLAie0i30VH 3Q1VZ1gvfNZC8paMvlOcKroclDRYf2NtFj+qV6xhscgWPPP73xYXKBSgyj6iLthUkBvcRVWFGP8 ruu53cazNA3avVk+umbxd7X6Yr7owbLybeV/UrEN/Y3Hz5guLp+cZJREzQ7WnLjUDnGdxzYWVs/ 7TfEY8oASZEJgOgxyk6rwlDlTl/LZgmZqJvikJsScuro1XywD9eBtES5OGmT5PbeOdR13K+oXOQ aqI4sJ8+lamIOg2435ejySAzNRCt+DPIjAb540v1POOJK260DSczwWbdBTujdR6VovMlh/sYICx 2npDLUt75wJIr0iS7I X-Google-Smtp-Source: AGHT+IFtLElvxR81Tckw5mAAABXqwaPNv/lBu1tgkcuWlvZJfGpip3RMbzFOLoUXkftAvfjFkop/kg== X-Received: by 2002:a5d:5f82:0:b0:3fa:5925:4b07 with SMTP id ffacd0b85a97d-42704d74f9fmr12489147f8f.18.1761134895206; Wed, 22 Oct 2025 05:08:15 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-47496cf3b51sm35168225e9.9.2025.10.22.05.08.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Oct 2025 05:08:14 -0700 (PDT) Date: Wed, 22 Oct 2025 15:08:10 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Artem Shimko , Eugeniy Paltsev , Vinod Koul , Philipp Zabel Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, Artem Shimko , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/2] dmaengine: dw-axi-dmac: add reset control support Message-ID: <202510221508.PY6fB9CB-lkp@intel.com> Precedence: bulk X-Mailing-List: dmaengine@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251017102950.206443-3-a.shimko.dev@gmail.com> Hi Artem, kernel test robot noticed the following build warnings: https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Artem-Shimko/dmaengine-dw-axi-dmac-simplify-PM-functions-and-use-modern-macros/20251017-183103 base: https://git.kernel.org/pub/scm/linux/kernel/git/vkoul/dmaengine.git next patch link: https://lore.kernel.org/r/20251017102950.206443-3-a.shimko.dev%40gmail.com patch subject: [PATCH v4 2/2] dmaengine: dw-axi-dmac: add reset control support config: loongarch-randconfig-r072-20251019 (https://download.01.org/0day-ci/archive/20251022/202510221508.PY6fB9CB-lkp@intel.com/config) compiler: loongarch64-linux-gcc (GCC) 15.1.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202510221508.PY6fB9CB-lkp@intel.com/ New smatch warnings: drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c:1355 axi_dma_resume() warn: 'chip->core_clk' from clk_prepare_enable() not released on lines: 1350. Old smatch warnings: drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c:1237 dma_chan_pause() warn: inconsistent indenting drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c:1284 axi_chan_resume() warn: inconsistent indenting drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c:1355 axi_dma_resume() warn: 'chip->cfgr_clk' from clk_prepare_enable() not released on lines: 1346,1350. vim +1355 drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c 45fdf99125b2bf7 Artem Shimko 2025-10-17 1335 static int axi_dma_resume(struct device *dev) I guess kbuild bot thinks these are new warnings because the function was renamed. In the past we've just ignored clk_prepare_enable() warnings. Perhaps that's the correct thing to do in a resume function. The indenting in dma_chan_pause() and axi_chan_resume() could be cleaned up. 1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1336 { 1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1337 int ret; 45fdf99125b2bf7 Artem Shimko 2025-10-17 1338 struct axi_dma_chip *chip = dev_get_drvdata(dev); 1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1339 1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1340 ret = clk_prepare_enable(chip->cfgr_clk); 1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1341 if (ret < 0) 1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1342 return ret; 1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1343 1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1344 ret = clk_prepare_enable(chip->core_clk); 1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1345 if (ret < 0) 1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1346 return ret; 1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1347 9c360f02c387f93 Artem Shimko 2025-10-17 1348 ret = reset_control_deassert(chip->resets); 9c360f02c387f93 Artem Shimko 2025-10-17 1349 if (ret) 9c360f02c387f93 Artem Shimko 2025-10-17 1350 return ret; 9c360f02c387f93 Artem Shimko 2025-10-17 1351 1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1352 axi_dma_enable(chip); 1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1353 axi_dma_irq_enable(chip); 1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1354 1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 @1355 return 0; 1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1356 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2EBBF2F99AA for ; Wed, 22 Oct 2025 09:19:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761124787; cv=none; b=KmZ+ip3n8tMmMxqS+GeGeMIviklrlmI05uhT2DIYkyFHDFSdNtQO3dNJeWEE0SaEMMsVkSSgcnoNG0ums/LYuFwxuzeOeSoXaeq/F33iuxdXiZx/EedB9LPKmMphIZQ008mXuLDN9RnSS8xzcUgPcCgnyBKUECqbWlRjlZ8v+6M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761124787; c=relaxed/simple; bh=9b66tYU8wTlqJf2R7fMUCWYo9ZNSvBDdx74HadFw810=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=GaPULcu6pQU12rVH8Zy5uzTGJb15O0nx4W5VoMIecaqXqy0qk74iV9VI7QWFrIxM0drTcOcuLHgOokSsE+4/zwXWhZjyMiyMepkQs38CF0ZMnBMzbPZwDOWWVXRQ3S+fXTuyGiE9Gk90vmCOuszsuP5oqPxFa8YqEiBrpcu0Paw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=gzHnoNPb; arc=none smtp.client-ip=198.175.65.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="gzHnoNPb" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1761124786; x=1792660786; h=date:from:to:cc:subject:message-id:mime-version; bh=9b66tYU8wTlqJf2R7fMUCWYo9ZNSvBDdx74HadFw810=; b=gzHnoNPbKdROMkDoGbGzPp3C92vG9DMGmh6D5lOUEai79ZXP6RFgHDN1 gT6y7jbcnsQEuys9x2mJfoUN6yAHuUGpO9Pdb7+p94bxr6kNs1V+qxwlA mmO+sTZQ6tp3DlRRLytzPi2NBBYhM1tPuy+/vl80Txusv7YjF+GMXJCih eILtFtGi/YDOZx5ij+GFfPeVnZO2bq/TBU0Q9l/q8yxBKYzBmYcsS9+FL qNDM+QhdyR0rwt7Ze1UdMUVTFf9nLo2fZdw+n9ERN2uOkcLjWdnzxjHyx RnRfhQmaeUtJrPNP8B9TwYVn823IqeT1Kss9LUXjlz/Tn5siXxBo1BtIg w==; X-CSE-ConnectionGUID: SWWcQJ9JSumykdj7ZosfZg== X-CSE-MsgGUID: /SooSukhTGylCxgkFM80mQ== X-IronPort-AV: E=McAfee;i="6800,10657,11586"; a="63306886" X-IronPort-AV: E=Sophos;i="6.19,246,1754982000"; d="scan'208";a="63306886" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Oct 2025 02:19:45 -0700 X-CSE-ConnectionGUID: RliZWbwtTPSJOA/OYLbeRw== X-CSE-MsgGUID: nlDUuxK9QOSK5Jh4MooZag== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.19,246,1754982000"; d="scan'208";a="188231184" Received: from lkp-server02.sh.intel.com (HELO 66d7546c76b2) ([10.239.97.151]) by fmviesa005.fm.intel.com with ESMTP; 22 Oct 2025 02:19:44 -0700 Received: from kbuild by 66d7546c76b2 with local (Exim 4.96) (envelope-from ) id 1vBV0P-000CBh-28; Wed, 22 Oct 2025 09:19:41 +0000 Date: Wed, 22 Oct 2025 17:18:52 +0800 From: kernel test robot To: oe-kbuild@lists.linux.dev Cc: lkp@intel.com, Dan Carpenter Subject: Re: [PATCH v4 2/2] dmaengine: dw-axi-dmac: add reset control support Message-ID: <202510221508.PY6fB9CB-lkp@intel.com> Precedence: bulk X-Mailing-List: oe-kbuild@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline BCC: lkp@intel.com CC: oe-kbuild-all@lists.linux.dev In-Reply-To: <20251017102950.206443-3-a.shimko.dev@gmail.com> References: <20251017102950.206443-3-a.shimko.dev@gmail.com> TO: Artem Shimko TO: Eugeniy Paltsev TO: Vinod Koul TO: Philipp Zabel CC: Artem Shimko CC: dmaengine@vger.kernel.org CC: linux-kernel@vger.kernel.org Hi Artem, kernel test robot noticed the following build warnings: [auto build test WARNING on vkoul-dmaengine/next] [also build test WARNING on pza/reset/next linus/master v6.18-rc2 next-20251021] [cannot apply to pza/imx-drm/next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Artem-Shimko/dmaengine-dw-axi-dmac-simplify-PM-functions-and-use-modern-macros/20251017-183103 base: https://git.kernel.org/pub/scm/linux/kernel/git/vkoul/dmaengine.git next patch link: https://lore.kernel.org/r/20251017102950.206443-3-a.shimko.dev%40gmail.com patch subject: [PATCH v4 2/2] dmaengine: dw-axi-dmac: add reset control support :::::: branch date: 5 days ago :::::: commit date: 5 days ago config: loongarch-randconfig-r072-20251019 (https://download.01.org/0day-ci/archive/20251022/202510221508.PY6fB9CB-lkp@intel.com/config) compiler: loongarch64-linux-gcc (GCC) 15.1.0 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202510221508.PY6fB9CB-lkp@intel.com/ New smatch warnings: drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c:1355 axi_dma_resume() warn: 'chip->core_clk' from clk_prepare_enable() not released on lines: 1350. Old smatch warnings: drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c:1237 dma_chan_pause() warn: inconsistent indenting drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c:1284 axi_chan_resume() warn: inconsistent indenting drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c:1355 axi_dma_resume() warn: 'chip->cfgr_clk' from clk_prepare_enable() not released on lines: 1346,1350. vim +1355 drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c 1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1334 45fdf99125b2bf7 Artem Shimko 2025-10-17 1335 static int axi_dma_resume(struct device *dev) 1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1336 { 1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1337 int ret; 45fdf99125b2bf7 Artem Shimko 2025-10-17 1338 struct axi_dma_chip *chip = dev_get_drvdata(dev); 1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1339 1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1340 ret = clk_prepare_enable(chip->cfgr_clk); 1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1341 if (ret < 0) 1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1342 return ret; 1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1343 1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1344 ret = clk_prepare_enable(chip->core_clk); 1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1345 if (ret < 0) 1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1346 return ret; 1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1347 9c360f02c387f93 Artem Shimko 2025-10-17 1348 ret = reset_control_deassert(chip->resets); 9c360f02c387f93 Artem Shimko 2025-10-17 1349 if (ret) 9c360f02c387f93 Artem Shimko 2025-10-17 1350 return ret; 9c360f02c387f93 Artem Shimko 2025-10-17 1351 1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1352 axi_dma_enable(chip); 1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1353 axi_dma_irq_enable(chip); 1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1354 1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 @1355 return 0; 1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1356 } 1fe20f1b84548bb Eugeniy Paltsev 2018-03-06 1357 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki