All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Biancaa Ramesh <biancaa2210329@ssn.edu.in>, linux-media@vger.kernel.org
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
	awalls@md.metrocast.net, mchehab@kernel.org,
	linux-kernel@vger.kernel.org,
	Biancaa Ramesh <biancaa2210329@ssn.edu.in>
Subject: Re: [PATCH] pcmcia/parport_cs: Refactor probe function and improve error logging
Date: Thu, 23 Oct 2025 04:24:01 +0800	[thread overview]
Message-ID: <202510230450.v2a33A8Z-lkp@intel.com> (raw)
In-Reply-To: <20251021190021.173748-1-biancaa2210329@ssn.edu.in>

Hi Biancaa,

kernel test robot noticed the following build errors:

[auto build test ERROR on sailus-media-tree/master]
[also build test ERROR on linus/master sailus-media-tree/streams v6.18-rc2 next-20251022]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Biancaa-Ramesh/pcmcia-parport_cs-Refactor-probe-function-and-improve-error-logging/20251022-030324
base:   git://linuxtv.org/sailus/media_tree.git master
patch link:    https://lore.kernel.org/r/20251021190021.173748-1-biancaa2210329%40ssn.edu.in
patch subject: [PATCH] pcmcia/parport_cs: Refactor probe function and improve error logging
config: x86_64-buildonly-randconfig-001-20251022 (https://download.01.org/0day-ci/archive/20251023/202510230450.v2a33A8Z-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251023/202510230450.v2a33A8Z-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202510230450.v2a33A8Z-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/parport/parport_cs.c:137:21: warning: unused variable 'info' [-Wunused-variable]
     137 |     parport_info_t *info = link->priv;
         |                     ^~~~
>> drivers/parport/parport_cs.c:148:11: error: use of undeclared label 'failed'
     148 |             goto failed;
         |                  ^
>> drivers/parport/parport_cs.c:169:5: error: unknown type name 'p'
     169 |     p->modes |= PARPORT_MODE_PCSPP;
         |     ^
>> drivers/parport/parport_cs.c:169:6: error: expected identifier or '('
     169 |     p->modes |= PARPORT_MODE_PCSPP;
         |      ^
   drivers/parport/parport_cs.c:170:5: error: expected identifier or '('
     170 |     if (epp_mode)
         |     ^
>> drivers/parport/parport_cs.c:172:5: error: unknown type name 'info'
     172 |     info->ndev = 1;
         |     ^
   drivers/parport/parport_cs.c:172:9: error: expected identifier or '('
     172 |     info->ndev = 1;
         |         ^
   drivers/parport/parport_cs.c:173:5: error: unknown type name 'info'
     173 |     info->port = p;
         |     ^
   drivers/parport/parport_cs.c:173:9: error: expected identifier or '('
     173 |     info->port = p;
         |         ^
   drivers/parport/parport_cs.c:175:5: error: expected identifier or '('
     175 |     return 0;
         |     ^
>> drivers/parport/parport_cs.c:177:1: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
     177 | failed:
         | ^
         | int
>> drivers/parport/parport_cs.c:177:7: error: expected ';' after top level declarator
     177 | failed:
         |       ^
         |       ;
   drivers/parport/parport_cs.c:178:2: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
     178 |         parport_cs_release(link);
         |         ^
         |         int
>> drivers/parport/parport_cs.c:178:21: error: a parameter list without types is only allowed in a function definition
     178 |         parport_cs_release(link);
         |                            ^
>> drivers/parport/parport_cs.c:179:8: error: unknown type name 'link'
     179 |         kfree(link->priv);
         |               ^
>> drivers/parport/parport_cs.c:179:12: error: expected ')'
     179 |         kfree(link->priv);
         |                   ^
   drivers/parport/parport_cs.c:179:7: note: to match this '('
     179 |         kfree(link->priv);
         |              ^
   drivers/parport/parport_cs.c:179:2: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
     179 |         kfree(link->priv);
         |         ^
         |         int
   drivers/parport/parport_cs.c:180:5: error: unknown type name 'link'
     180 |     link->priv = NULL;
         |     ^
   drivers/parport/parport_cs.c:180:9: error: expected identifier or '('
     180 |     link->priv = NULL;
         |         ^
   drivers/parport/parport_cs.c:181:2: error: expected identifier or '('
     181 |         return -ENODEV;
         |         ^
   fatal error: too many errors emitted, stopping now [-ferror-limit=]
   1 warning and 20 errors generated.


vim +/failed +148 drivers/parport/parport_cs.c

84e2d34004dcd0 Dominik Brodowski 2008-07-29  134  
15b99ac1729503 Dominik Brodowski 2006-03-31  135  static int parport_config(struct pcmcia_device *link)
^1da177e4c3f41 Linus Torvalds    2005-04-16  136  {
^1da177e4c3f41 Linus Torvalds    2005-04-16  137      parport_info_t *info = link->priv;
^1da177e4c3f41 Linus Torvalds    2005-04-16  138      struct parport *p;
9b44de2015ff4a Dominik Brodowski 2009-10-24  139      int ret;
^1da177e4c3f41 Linus Torvalds    2005-04-16  140  
9b44de2015ff4a Dominik Brodowski 2009-10-24  141      dev_dbg(&link->dev, "parport_config\n");
^1da177e4c3f41 Linus Torvalds    2005-04-16  142  
00990e7ce0b0e5 Dominik Brodowski 2010-07-30  143      if (epp_mode)
00990e7ce0b0e5 Dominik Brodowski 2010-07-30  144  	    link->config_index |= FORCE_EPP_MODE;
00990e7ce0b0e5 Dominik Brodowski 2010-07-30  145  
9b44de2015ff4a Dominik Brodowski 2009-10-24  146      ret = pcmcia_loop_config(link, parport_config_check, NULL);
9b44de2015ff4a Dominik Brodowski 2009-10-24  147      if (ret)
84e2d34004dcd0 Dominik Brodowski 2008-07-29 @148  	    goto failed;
^1da177e4c3f41 Linus Torvalds    2005-04-16  149  
eb14120f743d29 Dominik Brodowski 2010-03-07  150      if (!link->irq)
9b44de2015ff4a Dominik Brodowski 2009-10-24  151  	    goto failed;
1ac71e5a35eebe Dominik Brodowski 2010-07-29  152      ret = pcmcia_enable_device(link);
9b44de2015ff4a Dominik Brodowski 2009-10-24  153      if (ret)
9b44de2015ff4a Dominik Brodowski 2009-10-24  154  	    goto failed;
^1da177e4c3f41 Linus Torvalds    2005-04-16  155  
9a017a910346af Dominik Brodowski 2010-07-24  156      p = parport_pc_probe_port(link->resource[0]->start,
9a017a910346af Dominik Brodowski 2010-07-24  157  			      link->resource[1]->start,
eb14120f743d29 Dominik Brodowski 2010-03-07  158  			      link->irq, PARPORT_DMA_NONE,
51dcdfec6a274a Alan Cox          2009-04-07  159  			      &link->dev, IRQF_SHARED);
fac3d7d7b11c82 Biancaa Ramesh    2025-10-22  160      if (!p) {
fac3d7d7b11c82 Biancaa Ramesh    2025-10-22  161          dev_err(&link->dev,
fac3d7d7b11c82 Biancaa Ramesh    2025-10-22  162              "parport_pc_probe_port() failed at 0x%03x, irq %u\n",
decf26f6ec25da Joe Perches       2020-04-03  163              (unsigned int)link->resource[0]->start, link->irq);
^1da177e4c3f41 Linus Torvalds    2005-04-16  164          goto failed;
^1da177e4c3f41 Linus Torvalds    2005-04-16  165      }   
^1da177e4c3f41 Linus Torvalds    2005-04-16  166  
fac3d7d7b11c82 Biancaa Ramesh    2025-10-22  167      }
fac3d7d7b11c82 Biancaa Ramesh    2025-10-22  168  
^1da177e4c3f41 Linus Torvalds    2005-04-16 @169      p->modes |= PARPORT_MODE_PCSPP;
^1da177e4c3f41 Linus Torvalds    2005-04-16  170      if (epp_mode)
^1da177e4c3f41 Linus Torvalds    2005-04-16  171  	p->modes |= PARPORT_MODE_TRISTATE | PARPORT_MODE_EPP;
^1da177e4c3f41 Linus Torvalds    2005-04-16 @172      info->ndev = 1;
^1da177e4c3f41 Linus Torvalds    2005-04-16  173      info->port = p;
^1da177e4c3f41 Linus Torvalds    2005-04-16  174  
15b99ac1729503 Dominik Brodowski 2006-03-31  175      return 0;
^1da177e4c3f41 Linus Torvalds    2005-04-16  176  
^1da177e4c3f41 Linus Torvalds    2005-04-16 @177  failed:
^1da177e4c3f41 Linus Torvalds    2005-04-16 @178  	parport_cs_release(link);
21c75ad65f8e52 YueHaibing        2019-03-21 @179  	kfree(link->priv);
fac3d7d7b11c82 Biancaa Ramesh    2025-10-22  180      link->priv = NULL;
15b99ac1729503 Dominik Brodowski 2006-03-31  181  	return -ENODEV;
^1da177e4c3f41 Linus Torvalds    2005-04-16  182  } /* parport_config */
^1da177e4c3f41 Linus Torvalds    2005-04-16  183  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

      parent reply	other threads:[~2025-10-22 20:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-21 19:00 [PATCH] pcmcia/parport_cs: Refactor probe function and improve error logging Biancaa Ramesh
2025-10-22 14:09 ` kernel test robot
2025-10-22 17:55   ` [PATCH] Subject: [PATCH v2] pcmcia/parport_cs: fix probe function syntax and error handling Biancaa Ramesh
2025-10-22 18:16     ` Markus Elfring
2025-10-22 16:30 ` [PATCH] parport_cs: Refactor probe function and improve error logging Markus Elfring
2025-10-22 20:24 ` kernel test robot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202510230450.v2a33A8Z-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=awalls@md.metrocast.net \
    --cc=biancaa2210329@ssn.edu.in \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=mchehab@kernel.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.