From: Jakub Kicinski <kuba@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>
Cc: Hangbin Liu <liuhangbin@gmail.com>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Simon Horman <horms@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>,
"Dr. David Alan Gilbert" <linux@treblig.org>,
Dong Chenchen <dongchenchen2@huawei.com>,
Oscar Maes <oscmaes92@gmail.com>
Subject: Re: [PATCH net] net: vlan: sync VLAN features with lower device
Date: Thu, 23 Oct 2025 06:55:17 -0700 [thread overview]
Message-ID: <20251023065517.2d3dfca0@kernel.org> (raw)
In-Reply-To: <38605efc-32f5-4c78-a628-11f8f07668f0@redhat.com>
On Thu, 23 Oct 2025 15:39:07 +0200 Paolo Abeni wrote:
> > @@ -193,6 +193,8 @@ int register_vlan_dev(struct net_device *dev, struct netlink_ext_ack *extack)
> > vlan_group_set_device(grp, vlan->vlan_proto, vlan_id, dev);
> > grp->nr_vlan_devs++;
> >
> > + netdev_change_features(dev);
>
> Is this just for NETIF_F_LRO? it feels a bit overkill for single flag.
> Also, why netdev_change_features() (vs netdev_update_features())?
Another thought -- isn't this a problem for more uppers?
Isn't this what all callers of netdev_upper_dev_link() effectively
need, and therefore perhaps we should stick it somewhere in the core
(netdev_upper_dev_link() itself or when device is registered) ?
next prev parent reply other threads:[~2025-10-23 13:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-21 9:56 [PATCH net] net: vlan: sync VLAN features with lower device Hangbin Liu
2025-10-23 13:39 ` Paolo Abeni
2025-10-23 13:55 ` Jakub Kicinski [this message]
2025-10-23 14:57 ` Hangbin Liu
2025-10-23 14:17 ` Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251023065517.2d3dfca0@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dongchenchen2@huawei.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux@treblig.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=oscmaes92@gmail.com \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.