From: Christoph Hellwig <hch@lst.de>
To: Gerd Bayer <gbayer@linux.ibm.com>
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Niklas Schnelle <schnelle@linux.ibm.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Chaitanya Kulkarni <kch@nvidia.com>,
Wilfred Mallawa <wilfred.mallawa@wdc.com>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] nvme-pci: Print error message on failure in nvme_probe
Date: Thu, 23 Oct 2025 10:13:25 +0200 [thread overview]
Message-ID: <20251023081325.GA302@lst.de> (raw)
In-Reply-To: <20251022-nvme_probefail-v2-1-26bbdf94280e@linux.ibm.com>
On Wed, Oct 22, 2025 at 12:33:16PM +0200, Gerd Bayer wrote:
> Add a new error message that makes failures to probe visible in the
> kernel log, like:
> nvme 0008:00:00.0: error -ENODEV: probe failed
>
> This highlights issues with a particular device right away instead of
> leaving users to search for missing drives.
>
> Signed-off-by: Gerd Bayer <gbayer@linux.ibm.com>
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2025-10-23 8:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-22 10:33 [PATCH v2 0/2] nvme-pci: Log failures to probe Gerd Bayer
2025-10-22 10:33 ` [PATCH v2 1/2] nvme-pci: Print error message on failure in nvme_probe Gerd Bayer
2025-10-22 10:53 ` Gerd Bayer
2025-10-23 8:13 ` Christoph Hellwig [this message]
2025-10-22 10:33 ` [PATCH v2 2/2] nvme-pci: Add debug message on fail to read CSTS Gerd Bayer
2025-10-23 8:13 ` Christoph Hellwig
2025-10-23 10:55 ` John Garry
2025-10-23 14:17 ` Gerd Bayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251023081325.GA302@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=gbayer@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=kbusch@kernel.org \
--cc=kch@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=schnelle@linux.ibm.com \
--cc=wilfred.mallawa@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.